Dactyloidae/editor/libeditor
Gaming4JC bdd709df2b Bug 1316302 - Part 1: Helper methods for HTMLEditRules::WillDeleteSelection() should have an out argument to indicates if it actually handles the action
When HTMLEditRules::WillDeleteSelection() tries to remove something from the end/start of a block to its last/first text node but it's contained by block elements, it tries to join the container and the block. However, JoinBlocks() always fails to join them since it's impossible operation. In this case, HTMLEditRules::WillDeleteSelection() should retry to remove something in the leaf, however, it's impossible for now because JoinBlocks() and its helper methods don't return if it handles the action actually.

This patch renames |JoinBlocks()| to |TryToJoinBlocks()| for representing what it is. And this patch adds |bool* aHandled| to the helper methods. Then, *aHandled and *aCancel are now always returns the result of each method. Therefore, for merging the result of multiple helper methods, callers need to receive the result with temporary variables and merge them by themselves.

Note that when they modify DOM node actually or the action should do nothing (for example, selection is across tables), aHandled is set to true.

Tag #1563
2020-06-20 06:44:45 +08:00
..
crashtests Bug 1348851 - Use new block when better selection isn't found. 2020-04-18 07:03:58 +08:00
tests Issue #1517 - Remove dom.event.highrestimestamp.enabled pref 2020-05-09 06:55:11 +08:00
ChangeAttributeTransaction.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
ChangeAttributeTransaction.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
ChangeStyleTransaction.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
ChangeStyleTransaction.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
CompositionTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
CompositionTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
CreateElementTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
CreateElementTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
CSSEditUtils.cpp Issue #1564 - Fix debug build dependencies 2020-05-30 07:13:05 +08:00
CSSEditUtils.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
DeleteNodeTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
DeleteNodeTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
DeleteRangeTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
DeleteRangeTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
DeleteTextTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
DeleteTextTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
EditActionListener.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditAggregateTransaction.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditAggregateTransaction.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditorBase.cpp Issue #1375 - Stop largely using the parser service 2020-04-18 07:04:57 +08:00
EditorBase.h Bug 1372829 - Part 2: mozilla::EditorBase should cache raw pointer of nsISelectionController and nsIDocument with nsWeakPtr 2020-04-18 07:04:22 +08:00
EditorCommands.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditorCommands.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditorController.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditorController.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditorEventListener.cpp Issue #12 Part 4: Don't access mEditorBase directly. 2019-02-16 00:05:43 +08:00
EditorEventListener.h Issue #12 Part 3: EditorEventListener should check if it's removed during a call of editor's method. 2019-02-16 00:05:42 +08:00
EditorUtils.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditorUtils.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditorUtils.js import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditorUtils.manifest import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditTransactionBase.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
EditTransactionBase.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
HTMLAbsPositionEditor.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
HTMLAnonymousNodeEditor.cpp Issue #1564 - Fix debug build dependencies 2020-05-30 07:13:05 +08:00
HTMLEditor.cpp Bug 1360154 - nsIPlaintextEditor might have to have hasText property for UpdateOverlayTextVisibility 2020-04-18 07:06:55 +08:00
HTMLEditor.h Bug 1337698 - Use UniquePtr instead of nsAutoPtr in editor 2020-04-18 07:04:07 +08:00
HTMLEditorDataTransfer.cpp Issue #80 - De-unify editor/libeditor 2020-05-23 06:52:28 +08:00
HTMLEditorEventListener.cpp Issue #12 Part 4: Don't access mEditorBase directly. 2019-02-16 00:05:43 +08:00
HTMLEditorEventListener.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
HTMLEditorObjectResizer.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
HTMLEditorObjectResizerUtils.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
HTMLEditRules.cpp Bug 1316302 - Part 1: Helper methods for HTMLEditRules::WillDeleteSelection() should have an out argument to indicates if it actually handles the action 2020-06-20 06:44:45 +08:00
HTMLEditRules.h Bug 1316302 - Part 1: Helper methods for HTMLEditRules::WillDeleteSelection() should have an out argument to indicates if it actually handles the action 2020-06-20 06:44:45 +08:00
HTMLEditUtils.cpp Bug 1418002 - Remove HTMLContentElement 2020-04-18 07:05:35 +08:00
HTMLEditUtils.h Issue #1564 - Fix debug build dependencies 2020-05-30 07:13:05 +08:00
HTMLInlineTableEditor.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
HTMLStyleEditor.cpp Issue #80 - De-unify editor/libeditor 2020-05-23 06:52:28 +08:00
HTMLTableEditor.cpp Bug 1377978 - Make nsRange use uint32_t to offset 2020-04-18 07:04:38 +08:00
HTMLURIRefObject.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
HTMLURIRefObject.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
InsertNodeTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
InsertNodeTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
InsertTextTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
InsertTextTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
InternetCiter.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
InternetCiter.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
JoinNodeTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
JoinNodeTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
moz.build Issue #80 - De-unify editor/libeditor 2020-05-23 06:52:28 +08:00
nsIAbsorbingTransaction.h Bug 1372829 - Part 1: Make mozilla::PlaceholderTransaction inherit mozilla::SupportsWeakPtr instead of nsSupportsWeakReference 2020-04-18 07:04:14 +08:00
nsIEditRules.h Bug 1360154 - nsIPlaintextEditor might have to have hasText property for UpdateOverlayTextVisibility 2020-04-18 07:06:55 +08:00
PlaceholderTransaction.cpp Bug 1372829 - Part 1: Make mozilla::PlaceholderTransaction inherit mozilla::SupportsWeakPtr instead of nsSupportsWeakReference 2020-04-18 07:04:14 +08:00
PlaceholderTransaction.h Bug 1372829 - Part 1: Make mozilla::PlaceholderTransaction inherit mozilla::SupportsWeakPtr instead of nsSupportsWeakReference 2020-04-18 07:04:14 +08:00
SelectionState.cpp Bug 1367683 - Optimize initializing nsRange 2020-04-18 07:04:01 +08:00
SelectionState.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
SetDocumentTitleTransaction.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
SetDocumentTitleTransaction.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
SplitNodeTransaction.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
SplitNodeTransaction.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
StyleSheetTransactions.cpp Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
StyleSheetTransactions.h Edit transactions should store their editor instance with strong reference 2019-02-15 23:30:05 +08:00
TextEditor.cpp Bug 1426494 - Share more code between nsIDocument and ShadowRoot 2020-06-20 06:43:47 +08:00
TextEditor.h Issue #12 Part 1: Stop using nsIDOMEvent in UpdateIMEComposition. 2019-02-16 00:05:39 +08:00
TextEditorDataTransfer.cpp moebius#56: Fix: DataTransfer - Pasting image from clipboard fails in some cases 2019-02-15 23:48:56 +08:00
TextEditorTest.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
TextEditorTest.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
TextEditRules.cpp Bug 1360154 - nsIPlaintextEditor might have to have hasText property for UpdateOverlayTextVisibility 2020-04-18 07:06:55 +08:00
TextEditRules.h Bug 1360154 - nsIPlaintextEditor might have to have hasText property for UpdateOverlayTextVisibility 2020-04-18 07:06:55 +08:00
TextEditRulesBidi.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
TextEditUtils.cpp import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
TextEditUtils.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00
TypeInState.cpp Bug 1337698 - Use UniquePtr instead of nsAutoPtr in editor 2020-04-18 07:04:07 +08:00
TypeInState.h Bug 1337698 - Use UniquePtr instead of nsAutoPtr in editor 2020-04-18 07:04:07 +08:00
WSRunObject.cpp Bug 1367683 - Optimize initializing nsRange 2020-04-18 07:04:01 +08:00
WSRunObject.h import FIREFOX_52_6_0esr_RELEASE from mozilla-esr52 hg repo 2018-01-19 03:59:58 +08:00