Commit graph

5,777 commits

Author SHA1 Message Date
Matt A. Tobin
d60003b8d1 Bug 1167982 - Do charset detection for all text/* attachments in composition, not just text/plain.
Tag #1273
2019-11-17 00:11:22 +08:00
Matt A. Tobin
d27ecf750c Bug 522450 - Place mail copy on the correct folder when using Reply to List
This bug never landed in c-c

Tag #1273
2019-11-17 00:11:20 +08:00
Matt A. Tobin
13a2cf2b8a Tails 6156 - Fix outdated error handling in accountcreation and remove buggy debug code
Tag #1273
2019-11-17 00:11:18 +08:00
Matt A. Tobin
0f7827bc8d Bug 971347 - Fix autoconfig vulnerable to active MITM attacks for all domains (including the ones in ISPDB)
Tag #1273
2019-11-17 00:11:17 +08:00
Matt A. Tobin
707ff44b81 Bug 1020971 - Port bug 1015664: Remove NS_HIDDEN and friends.
Tag #1273
2019-11-17 00:11:15 +08:00
Matt A. Tobin
87073feb8a Bug 1546840 - Allow GloDa queries for read or unread messages
Tag #1273
2019-11-17 00:11:13 +08:00
Matt A. Tobin
c173b90220 Bug 1508054 - reduce exposed API of nsMsgHdr.
Tag #1273
2019-11-17 00:11:12 +08:00
Matt A. Tobin
c45692398e Bug 1386601 - experimental patch to investigate Thunderbird topcrash, serializes S/MIME verification.
Tag #1273
2019-11-17 00:11:10 +08:00
Matt A. Tobin
3a92a80285 Bug 1495698 - Fix hang when HTML signature references non-existent image.
Tag #1273
2019-11-17 00:11:08 +08:00
Matt A. Tobin
84617f965f Bug 1525120 - Fix condition for decoding attachments (base64/qp) when saving or forwarding.
Tag #1273
2019-11-17 00:11:06 +08:00
Matt A. Tobin
6debc5b306 Bugs 1507218 and 1528615
Tag #1273
2019-11-17 00:11:05 +08:00
Matt A. Tobin
218ad487d8 Bugs 1402750 and 1490331 - Declare the character set correctly in the 'PGP add-on is missing' message.
Tag #1273
2019-11-17 00:11:03 +08:00
Matt A. Tobin
87953b53dc Bug 1523048 - when copying a filter, copy its triggering events too (filterType).
Tag #1273
2019-11-17 00:11:01 +08:00
Matt A. Tobin
0aed88f864 Bug 393302 - Correct memory handling in MAPISendMail() and CMapiImp::SendMail() to fix "Send to > Mail Recipient" crash.
Tag #1273
2019-11-17 00:10:59 +08:00
Matt A. Tobin
9a5ef5ff5d Bug 1517464 - Fix crash in SMTP DTOR by properly initializing/testing pointer.
Tag #1273
2019-11-17 00:10:57 +08:00
Matt A. Tobin
4046167650 Bug 906469 - fix maildir crash while parsing a folder.
Tag #1273
2019-11-17 00:10:56 +08:00
Matt A. Tobin
1e792c1fee Bugs 1512557 and 1470716 - Convert nsIStringBundle pointers to nsCOMPtrs and release them when shutting down.
Tag #1273
2019-11-17 00:10:54 +08:00
Matt A. Tobin
70d9e97b14 Bug 390721 - When parsing headers to cancel an article, also use folded lines.
Tag #1273
2019-11-17 00:10:52 +08:00
Matt A. Tobin
a3ac164730 Bug 809513 - Prevent unread Drafts from showing in new mail notification.
Change mainly affects Windows. However, Linux integration also changed so that it also allows new mail notification to occur for folder with SentMail flag.

Tag #1273
2019-11-17 00:10:51 +08:00
Matt A. Tobin
832d721135 Bug 1271353 - check own email addresses case-insensitively in correspondents column and ignore plus addressing part.
Tag #1273
2019-11-17 00:10:49 +08:00
Matt A. Tobin
6c3fade999 Bug 1401858 - add null check to avoid crash in EncodedHeader()/DecodedHeader().
Tag #1273
2019-11-17 00:10:47 +08:00
Matt A. Tobin
af2693fe73 Bug 342632 - Allow defaultAccount to return success with nullptr result when there is no usable account.
Tag #1273
2019-11-17 00:10:45 +08:00
Matt A. Tobin
07b587d4ed Bug 1508046 - return cleanly in LDAP autocomplete search if we are offline.
Tag #1273
2019-11-17 00:10:44 +08:00
Matt A. Tobin
8525e02caf Bug 1507718 - crash in nsImapProtocol::GetMessageSize(). Make m_hostSessionList an nsCOMPtr.
Tag #1273
2019-11-17 00:10:42 +08:00
Matt A. Tobin
d7d4339e24 Bug 1320475 - Fix broken controllers for cmd_printcard and cmd_printcardpreview.
Tag #1273
2019-11-17 00:10:40 +08:00
Matt A. Tobin
c6d3f84949 Bug 344205 - React correctly to NO/BAD tagged response to imap IDLE.
User is notifified and IDLE state is not entered if IDLE command fails.

Tag #1273
2019-11-17 00:10:38 +08:00
Matt A. Tobin
6ee94917fe Bug 1257058 - Distinguish 'empty password' from no password received to avoid shutdown crash.
Tag #1273
2019-11-17 00:10:36 +08:00
Matt A. Tobin
14590876b2 Bug 1333038 - Use 'modern' pointers to fix crash due to nsMsgLineStreamBuffer object being deleted while still in use.
Suspected "use after free" in nsMsgLineStreamBuffer::ReadNextLine() leading to crash since object may be destroyed while still in use on another thread.

Tag #1273
2019-11-17 00:10:35 +08:00
Matt A. Tobin
37c62668cb Bug 1494764 - Removed MOZ_ASSERT but now still process line where it would occur.
MOZ_ASSERT changed to NS_WARNING. Also correctly handle case where last chunk ends with \r. Tested to make sure that regression identified in Bug 1494764 comment 10 remains fixed and that non-chunked and chunked messages are handled correctly including when \r\n is split between chunks.

Tag #1273
2019-11-17 00:10:33 +08:00
Matt A. Tobin
791626aab1 Bug 145113 - Make "next chunk starts with newline" flag a member variable to fix MOZ_ASSERT().
Tag #1273
2019-11-17 00:10:31 +08:00
Matt A. Tobin
3f68fdb0f4 Bug 1442648 - Fix mismatched types in mingw-w64 builds (const char16_t*/char16ptr_t).
When cross-compiling for Windows on Linux, fix mismatched types in nsMsgImapSearch.cpp. nsString::get() returns a char16ptr_t (with MOZ_USE_CHAR16_WRAPPER) and that causes a mismatch so we cast it to a const char16_t*. usAsciiCharSet is declared as a nsAutoString so we instead declare it as a char16_t* to avoid subsequent type mismatches.

Tag #1273
2019-11-17 00:10:29 +08:00
Matt A. Tobin
0f885aaad1 Bug 1317117 - call msgStore folder deletion during imap/news empty trash.
Also factors out some common code into nsMSgDBFolder::Delete(), and makes a couple of incidental changes to try and clarify the responsibilies of nsIMsgPluggableStore::DeleteFolder().

Tag #1273
2019-11-17 00:10:28 +08:00
Matt A. Tobin
0ef88cc19d Bug 1444389 - Fix crash in nsImapProtocol::HandleMessageDownLoadLine().
Tag #1273
2019-11-17 00:10:26 +08:00
Matt A. Tobin
50786649ed Bug 1216951 - Fix broken handling of split CR and LF between chunks.
Tag #1273
2019-11-17 00:10:24 +08:00
Matt A. Tobin
8ca877d7d7 Revert "Issue #1273 - Remove Telemetry from Gloda"
This reverts commit 4db1ae892bad565e8e59ec6034b4c98946077248.
2019-11-17 00:10:23 +08:00
Matt A. Tobin
497286a00b Bug 1416033 - remove some unneeded includes in mailnews
Tag #1273
2019-11-17 00:10:21 +08:00
Matt A. Tobin
8ccc206d44 Bug 1399756 - (More) Code clean-up: Style nits, typos and trailing spaces
Tag #1273
2019-11-17 00:10:19 +08:00
Matt A. Tobin
c021f0c983 Bug 1393219 - Code clean-up: Style nits, typos and trailing spaces
Tag #1273
2019-11-17 00:10:17 +08:00
Matt A. Tobin
b706286c3d Bug 825513 - Fix crash in nsImapProtocol::GetMessageSize() by adding null check for m_runningUrl && m_hostSessionList.
Tag #1273
2019-11-17 00:10:16 +08:00
Matt A. Tobin
fc672dabc7 Bug 1462316 - fix crash in nsAbView::OnItemAdded().
Tag #1273
2019-11-17 00:10:14 +08:00
Matt A. Tobin
3141e9940a Bug 646901 - add error checking to fix crash in nsMsgXFVirtualFolderDBView::OnSearchHit().
dbToUse was null

Rag #1273
2019-11-17 00:10:12 +08:00
Matt A. Tobin
eaac1c967d Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
  Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().

Tag #1273
2019-11-17 00:10:10 +08:00
Matt A. Tobin
73af2ce033 Issue #1273 - Remove Telemetry from Gloda 2019-11-17 00:10:09 +08:00
Matt A. Tobin
11084d5e8c Bug 1427732 - fix newline handling when copying messages and compacting folders.
Tag #1273
2019-11-17 00:10:07 +08:00
Matt A. Tobin
f14a669d8b Bug 1227761 - Fix logic error in BuildAttachmentList().
First attachment cannot be saved if MIME message has no body part.

Tag #1273
2019-11-17 00:10:05 +08:00
Matt A. Tobin
87e80be2d1 Bug 1079280 - Don't transmit email when imap append response is bad.
This only applies to non-literal+ appends. Bad response typically occurs when {size} parameter of append command is larger than server can accept. This prevents TB from sending megabytes of data to a server that has already rejected it.

Tag #1273
2019-11-17 00:10:04 +08:00
Matt A. Tobin
f7f211f424 Bug 1404049 - fix that mail.imap.use_literal_plus set to false may have no effect.
This is because it was only used in response to a CAPABILITY imap request. However, often CAPABILITY response occurs without a request so TB sees no need to do a request. Fix by moving the usage of use_literal_plus to where LITERAL+ capability is actually used.

Tag #1273
2019-11-17 00:10:02 +08:00
Matt A. Tobin
52ff1c8f6b Bug 1461106 - Remove SMTP password from cache when deleted from password manager to prevent stale connection attempts.
Tag #1273
2019-11-17 00:10:00 +08:00
Matt A. Tobin
86d4e9d3a6 Bug 516464 - Remove passwords from cache when password manager contents are changed to prevent stale password attempts.
Tag #1273
2019-11-17 00:09:59 +08:00
Matt A. Tobin
d0d5ec75d5 Bug 1328847 - Change SEC_NORMAL to SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL where system principal is used.
Tag #1273
2019-11-17 00:09:57 +08:00