Commit graph

3,356 commits

Author SHA1 Message Date
Matt A. Tobin
af2693fe73 Bug 342632 - Allow defaultAccount to return success with nullptr result when there is no usable account.
Tag #1273
2019-11-17 00:10:45 +08:00
Matt A. Tobin
07b587d4ed Bug 1508046 - return cleanly in LDAP autocomplete search if we are offline.
Tag #1273
2019-11-17 00:10:44 +08:00
Matt A. Tobin
8525e02caf Bug 1507718 - crash in nsImapProtocol::GetMessageSize(). Make m_hostSessionList an nsCOMPtr.
Tag #1273
2019-11-17 00:10:42 +08:00
Matt A. Tobin
d7d4339e24 Bug 1320475 - Fix broken controllers for cmd_printcard and cmd_printcardpreview.
Tag #1273
2019-11-17 00:10:40 +08:00
Matt A. Tobin
c6d3f84949 Bug 344205 - React correctly to NO/BAD tagged response to imap IDLE.
User is notifified and IDLE state is not entered if IDLE command fails.

Tag #1273
2019-11-17 00:10:38 +08:00
Matt A. Tobin
6ee94917fe Bug 1257058 - Distinguish 'empty password' from no password received to avoid shutdown crash.
Tag #1273
2019-11-17 00:10:36 +08:00
Matt A. Tobin
14590876b2 Bug 1333038 - Use 'modern' pointers to fix crash due to nsMsgLineStreamBuffer object being deleted while still in use.
Suspected "use after free" in nsMsgLineStreamBuffer::ReadNextLine() leading to crash since object may be destroyed while still in use on another thread.

Tag #1273
2019-11-17 00:10:35 +08:00
Matt A. Tobin
37c62668cb Bug 1494764 - Removed MOZ_ASSERT but now still process line where it would occur.
MOZ_ASSERT changed to NS_WARNING. Also correctly handle case where last chunk ends with \r. Tested to make sure that regression identified in Bug 1494764 comment 10 remains fixed and that non-chunked and chunked messages are handled correctly including when \r\n is split between chunks.

Tag #1273
2019-11-17 00:10:33 +08:00
Matt A. Tobin
791626aab1 Bug 145113 - Make "next chunk starts with newline" flag a member variable to fix MOZ_ASSERT().
Tag #1273
2019-11-17 00:10:31 +08:00
Matt A. Tobin
3f68fdb0f4 Bug 1442648 - Fix mismatched types in mingw-w64 builds (const char16_t*/char16ptr_t).
When cross-compiling for Windows on Linux, fix mismatched types in nsMsgImapSearch.cpp. nsString::get() returns a char16ptr_t (with MOZ_USE_CHAR16_WRAPPER) and that causes a mismatch so we cast it to a const char16_t*. usAsciiCharSet is declared as a nsAutoString so we instead declare it as a char16_t* to avoid subsequent type mismatches.

Tag #1273
2019-11-17 00:10:29 +08:00
Matt A. Tobin
0f885aaad1 Bug 1317117 - call msgStore folder deletion during imap/news empty trash.
Also factors out some common code into nsMSgDBFolder::Delete(), and makes a couple of incidental changes to try and clarify the responsibilies of nsIMsgPluggableStore::DeleteFolder().

Tag #1273
2019-11-17 00:10:28 +08:00
Matt A. Tobin
0ef88cc19d Bug 1444389 - Fix crash in nsImapProtocol::HandleMessageDownLoadLine().
Tag #1273
2019-11-17 00:10:26 +08:00
Matt A. Tobin
50786649ed Bug 1216951 - Fix broken handling of split CR and LF between chunks.
Tag #1273
2019-11-17 00:10:24 +08:00
Matt A. Tobin
8ca877d7d7 Revert "Issue #1273 - Remove Telemetry from Gloda"
This reverts commit 4db1ae892bad565e8e59ec6034b4c98946077248.
2019-11-17 00:10:23 +08:00
Matt A. Tobin
497286a00b Bug 1416033 - remove some unneeded includes in mailnews
Tag #1273
2019-11-17 00:10:21 +08:00
Matt A. Tobin
8ccc206d44 Bug 1399756 - (More) Code clean-up: Style nits, typos and trailing spaces
Tag #1273
2019-11-17 00:10:19 +08:00
Matt A. Tobin
c021f0c983 Bug 1393219 - Code clean-up: Style nits, typos and trailing spaces
Tag #1273
2019-11-17 00:10:17 +08:00
Matt A. Tobin
b706286c3d Bug 825513 - Fix crash in nsImapProtocol::GetMessageSize() by adding null check for m_runningUrl && m_hostSessionList.
Tag #1273
2019-11-17 00:10:16 +08:00
Matt A. Tobin
fc672dabc7 Bug 1462316 - fix crash in nsAbView::OnItemAdded().
Tag #1273
2019-11-17 00:10:14 +08:00
Matt A. Tobin
3141e9940a Bug 646901 - add error checking to fix crash in nsMsgXFVirtualFolderDBView::OnSearchHit().
dbToUse was null

Rag #1273
2019-11-17 00:10:12 +08:00
Matt A. Tobin
eaac1c967d Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
  Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().

Tag #1273
2019-11-17 00:10:10 +08:00
Matt A. Tobin
73af2ce033 Issue #1273 - Remove Telemetry from Gloda 2019-11-17 00:10:09 +08:00
Matt A. Tobin
11084d5e8c Bug 1427732 - fix newline handling when copying messages and compacting folders.
Tag #1273
2019-11-17 00:10:07 +08:00
Matt A. Tobin
f14a669d8b Bug 1227761 - Fix logic error in BuildAttachmentList().
First attachment cannot be saved if MIME message has no body part.

Tag #1273
2019-11-17 00:10:05 +08:00
Matt A. Tobin
87e80be2d1 Bug 1079280 - Don't transmit email when imap append response is bad.
This only applies to non-literal+ appends. Bad response typically occurs when {size} parameter of append command is larger than server can accept. This prevents TB from sending megabytes of data to a server that has already rejected it.

Tag #1273
2019-11-17 00:10:04 +08:00
Matt A. Tobin
f7f211f424 Bug 1404049 - fix that mail.imap.use_literal_plus set to false may have no effect.
This is because it was only used in response to a CAPABILITY imap request. However, often CAPABILITY response occurs without a request so TB sees no need to do a request. Fix by moving the usage of use_literal_plus to where LITERAL+ capability is actually used.

Tag #1273
2019-11-17 00:10:02 +08:00
Matt A. Tobin
52ff1c8f6b Bug 1461106 - Remove SMTP password from cache when deleted from password manager to prevent stale connection attempts.
Tag #1273
2019-11-17 00:10:00 +08:00
Matt A. Tobin
86d4e9d3a6 Bug 516464 - Remove passwords from cache when password manager contents are changed to prevent stale password attempts.
Tag #1273
2019-11-17 00:09:59 +08:00
Matt A. Tobin
d0d5ec75d5 Bug 1328847 - Change SEC_NORMAL to SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL where system principal is used.
Tag #1273
2019-11-17 00:09:57 +08:00
Matt A. Tobin
1531d6498d Issue #1258 - Part 8: Ifdef MailNews OAuth2 Support
Use --disable-mailnews-oauth2 to exclude it. Confvars won't be respected.
2019-11-17 00:09:28 +08:00
Matt A. Tobin
971009881c Issue #1258 - Part 7: UXP Specific fixes
* This includes Bug 1326433 for Janek fallout (ldap already had this fix)
2019-11-17 00:09:17 +08:00
Matt A. Tobin
28473a58a2 Issue #1258 - Part 6: Add MOZ_MOVEMAIL to MOZ_MAILNEWS configure logic 2019-11-17 00:09:16 +08:00
Matt A. Tobin
8c31c0427a Issue #1258 - Part 5: Only IceDove cares about Thunderbird's baby mode account creation 2019-11-17 00:09:14 +08:00
Matt A. Tobin
0641178442 Issue #1258 - Part 4: Remove Add IM Account from Account Manager 2019-11-17 00:09:12 +08:00
Matt A. Tobin
18ffebc2a1 Issue #1258 - Part 3: Make mailnews and friends build 2019-11-17 00:09:10 +08:00
Matt A. Tobin
deb86ab699 Issue #1258 - Part 2: Use binoc-central version of ldap 2019-11-17 00:08:49 +08:00
Matt A. Tobin
e400f4130a Issue #1258 - Part 1: Import mailnews, ldap, and mork from comm-esr52.9.1 2019-11-17 00:08:36 +08:00
wolfbeast
23e0d82436 Issue #1291 - Part 4: Update patch files 2019-11-16 06:17:50 +08:00
wolfbeast
ddb1aaaee3 Issue #1291 - Part 3: Update fdlibm to Sept 2019 version 2019-11-16 06:17:48 +08:00
wolfbeast
b6c0bdd7da Issue #1291 - Part 2: Stop using the lib's sqrt() function
Use <cmath>'s functions over fdlibm's for performance reasons.
No significant precision loss when doing this.
2019-11-16 06:17:47 +08:00
wolfbeast
ddb27ac3e9 Issue #1291 - Part 1: Ensure exp(1) returns e exactly (use a const) 2019-11-16 06:17:45 +08:00
wolfbeast
a9493635c6 Issue #80 - Stop building embedded xz lib unified 2019-11-16 06:17:43 +08:00
wolfbeast
cd7696699c Issue #80 - Stop building woff2 lib unified 2019-11-16 06:17:42 +08:00
wolfbeast
792f16c5bf Issue #80 - Stop building brotli lib unified 2019-11-16 06:17:40 +08:00
wolfbeast
cb944199e0 Add Ekoru to the included search engines.
This provides a charity-supporting search engine option focused on
the planet's health and animal welfare.
Since this engine is based on Bing search, it provides a balancing
alternative to Ecosia (Google-based) with similar eco goals.
2019-11-16 06:17:39 +08:00
Gaming4JC
59a1758d89 Issue #1279 - Update js/src/builtin/TestingFunctions.cpp for regex lookbehind changes
This fixes debug builds
2019-11-15 14:24:14 +08:00
Matt A. Tobin
ac1fe973f4 [Mach] Add stage command to execute stage-package 2019-11-15 14:24:10 +08:00
wolfbeast
4749ba0047 Issue #1289 - Part 4: Update Pale Moon UI.
This swaps the UI choice to using the new boolean pref instead of
enforcement level.
2019-11-15 14:24:08 +08:00
wolfbeast
08a2dbad4c Issue #1289 - Part 3: Update tests. 2019-11-15 14:24:07 +08:00
wolfbeast
79593d40e1 Issue #1289 - Part 2: Clear out the preload list except for test
domains.
2019-11-15 14:24:05 +08:00