Commit graph

30 commits

Author SHA1 Message Date
roytam1
08feac8e97 ported from mozilla: Bug 1538409 - implement oAuth authentication for POP accounts r=benc a=mkmelin (f6219b04be) 2024-09-21 18:23:52 +08:00
Jeremy Andrews
e3aa3c2963 Issue #1312 - Fix potential crashes in MailNews.
These are straightforward, one-line changes with no obvious dependencies. Probably could have been taken a long time ago.

Ref: BZ 1638634, 1606091
2022-07-30 08:43:45 +08:00
Brian Smith
d5c43d1d35 Issue #1829 - Readd code cleanup that is not Mac related that got clobbered by reverting Issue #1751 2022-05-04 10:01:23 +08:00
Brian Smith
13fcc4a046 Issue #1829 - Revert "Issue #1751" 2022-05-04 09:40:24 +08:00
Moonchild
a4b0f333ba Issue #1751 -- Remove XP_MACOSX conditionals from the rest of the tree.
This also removes some PP abuse and takes file entries out of PP when no longer
needed without XP_MACOSX conditionals.
2021-05-07 09:53:59 +08:00
Moonchild
0cd673d720 Issue #1656 - Part 6: Clean up the build files 2020-09-25 22:04:23 +08:00
Gaming4JC
c0409464b6 Bug 1613623 - For IMAP, no longer allow STARTTLS when server sends PREAUTH greeting.
Tag #1312
2020-06-20 06:44:27 +08:00
Gaming4JC
671b973fe5 Bug 1453643 - Enable proper retry on oauth2 authenication failure.
This prevents mail applications from  attempting to use an unauthenticated connection to mailbox(s) and avoid unexpected deletion of local mbox files and subsequent re-download of mailbox content over imap.
2020-01-03 13:44:07 +08:00
Gaming4JC
f7a24c87f6 Bug 1176399 - Multiple requests for master password when GMail OAuth2 is enabled. 2020-01-03 13:44:05 +08:00
Matt A. Tobin
2e230a6c19 Bug 1494764 - Removed MOZ_ASSERT but now still process line where it would occur.
MOZ_ASSERT changed to NS_WARNING. Also correctly handle case where last chunk ends with \r. Tested to make sure that regression identified in Bug 1494764 comment 10 remains fixed and that non-chunked and chunked messages are handled correctly including when \r\n is split between chunks.

Tag #1273
2019-11-17 00:12:40 +08:00
Matt A. Tobin
725462eff3 Manually revert Bug 1494764 - Removed MOZ_ASSERT but now still process line where it would occur.
Tag #1273
2019-11-17 00:12:38 +08:00
Matt A. Tobin
fe11727f3d Issue #1258 - Follow up to Part 8: Ifdef MailNews OAuth2 Support 2019-11-17 00:12:34 +08:00
Matt A. Tobin
338383f722 Bug 1580187 - Add null check to avoid crash in nsImapService::NewChannel().
Tag #1273
2019-11-17 00:12:21 +08:00
Matt A. Tobin
8525e02caf Bug 1507718 - crash in nsImapProtocol::GetMessageSize(). Make m_hostSessionList an nsCOMPtr.
Tag #1273
2019-11-17 00:10:42 +08:00
Matt A. Tobin
c6d3f84949 Bug 344205 - React correctly to NO/BAD tagged response to imap IDLE.
User is notifified and IDLE state is not entered if IDLE command fails.

Tag #1273
2019-11-17 00:10:38 +08:00
Matt A. Tobin
6ee94917fe Bug 1257058 - Distinguish 'empty password' from no password received to avoid shutdown crash.
Tag #1273
2019-11-17 00:10:36 +08:00
Matt A. Tobin
14590876b2 Bug 1333038 - Use 'modern' pointers to fix crash due to nsMsgLineStreamBuffer object being deleted while still in use.
Suspected "use after free" in nsMsgLineStreamBuffer::ReadNextLine() leading to crash since object may be destroyed while still in use on another thread.

Tag #1273
2019-11-17 00:10:35 +08:00
Matt A. Tobin
37c62668cb Bug 1494764 - Removed MOZ_ASSERT but now still process line where it would occur.
MOZ_ASSERT changed to NS_WARNING. Also correctly handle case where last chunk ends with \r. Tested to make sure that regression identified in Bug 1494764 comment 10 remains fixed and that non-chunked and chunked messages are handled correctly including when \r\n is split between chunks.

Tag #1273
2019-11-17 00:10:33 +08:00
Matt A. Tobin
791626aab1 Bug 145113 - Make "next chunk starts with newline" flag a member variable to fix MOZ_ASSERT().
Tag #1273
2019-11-17 00:10:31 +08:00
Matt A. Tobin
0f885aaad1 Bug 1317117 - call msgStore folder deletion during imap/news empty trash.
Also factors out some common code into nsMSgDBFolder::Delete(), and makes a couple of incidental changes to try and clarify the responsibilies of nsIMsgPluggableStore::DeleteFolder().

Tag #1273
2019-11-17 00:10:28 +08:00
Matt A. Tobin
0ef88cc19d Bug 1444389 - Fix crash in nsImapProtocol::HandleMessageDownLoadLine().
Tag #1273
2019-11-17 00:10:26 +08:00
Matt A. Tobin
50786649ed Bug 1216951 - Fix broken handling of split CR and LF between chunks.
Tag #1273
2019-11-17 00:10:24 +08:00
Matt A. Tobin
497286a00b Bug 1416033 - remove some unneeded includes in mailnews
Tag #1273
2019-11-17 00:10:21 +08:00
Matt A. Tobin
b706286c3d Bug 825513 - Fix crash in nsImapProtocol::GetMessageSize() by adding null check for m_runningUrl && m_hostSessionList.
Tag #1273
2019-11-17 00:10:16 +08:00
Matt A. Tobin
eaac1c967d Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
  Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().

Tag #1273
2019-11-17 00:10:10 +08:00
Matt A. Tobin
87e80be2d1 Bug 1079280 - Don't transmit email when imap append response is bad.
This only applies to non-literal+ appends. Bad response typically occurs when {size} parameter of append command is larger than server can accept. This prevents TB from sending megabytes of data to a server that has already rejected it.

Tag #1273
2019-11-17 00:10:04 +08:00
Matt A. Tobin
f7f211f424 Bug 1404049 - fix that mail.imap.use_literal_plus set to false may have no effect.
This is because it was only used in response to a CAPABILITY imap request. However, often CAPABILITY response occurs without a request so TB sees no need to do a request. Fix by moving the usage of use_literal_plus to where LITERAL+ capability is actually used.

Tag #1273
2019-11-17 00:10:02 +08:00
Matt A. Tobin
d0d5ec75d5 Bug 1328847 - Change SEC_NORMAL to SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL where system principal is used.
Tag #1273
2019-11-17 00:09:57 +08:00
Matt A. Tobin
1531d6498d Issue #1258 - Part 8: Ifdef MailNews OAuth2 Support
Use --disable-mailnews-oauth2 to exclude it. Confvars won't be respected.
2019-11-17 00:09:28 +08:00
Matt A. Tobin
e400f4130a Issue #1258 - Part 1: Import mailnews, ldap, and mork from comm-esr52.9.1 2019-11-17 00:08:36 +08:00