Fix singed/unsigned type confusion for intersection threshold.

Tag #249
This commit is contained in:
wolfbeast 2018-12-22 14:35:26 +01:00 • committed by Roy Tam
commit f82da789c8

View file

@ -424,15 +424,15 @@ DOMIntersectionObserver::Update(nsIDocument* aDocument, DOMHighResTimeStamp time
intersectionRatio = intersectionRect.isSome() ? 1.0 : 0.0; intersectionRatio = intersectionRect.isSome() ? 1.0 : 0.0;
} }
size_t threshold = -1; int32_t threshold = -1;
if (intersectionRatio > 0.0) { if (intersectionRatio > 0.0) {
if (intersectionRatio >= 1.0) { if (intersectionRatio >= 1.0) {
intersectionRatio = 1.0; intersectionRatio = 1.0;
threshold = mThresholds.Length(); threshold = (int32_t)mThresholds.Length();
} else { } else {
for (size_t k = 0; k < mThresholds.Length(); ++k) { for (size_t k = 0; k < mThresholds.Length(); ++k) {
if (mThresholds[k] <= intersectionRatio) { if (mThresholds[k] <= intersectionRatio) {
threshold = k + 1; threshold = (int32_t)k + 1;
} else { } else {
break; break;
} }