wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-24 17:37:30 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1407669 - Fix custom element creation hides uncatchable exceptions from the constructor.

Browse source 
Tag UXP Issue #1344
This commit is contained in:
Gaming4JC 2020-01-22 21:39:34 -05:00 • committed by Roy Tam
commit f64c7135b4
3 changed files with 40 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
dom/base/CustomElementRegistry.cpp
View file

@ -77,6 +77,7 @@ CustomElementConstructor::Construct(const char* aExecutionReason,
JS::Rooted<JSObject*> result(cx); JS::Rooted<JSObject*> result(cx);
JS::Rooted<JS::Value> constructor(cx, JS::ObjectValue(*mCallback)); JS::Rooted<JS::Value> constructor(cx, JS::ObjectValue(*mCallback));
if (!JS::Construct(cx, constructor, JS::HandleValueArray::empty(), &result)) { if (!JS::Construct(cx, constructor, JS::HandleValueArray::empty(), &result)) {
aRv.NoteJSContextException(cx);
return nullptr; return nullptr;
} }

2
dom/tests/mochitest/webcomponents/mochitest.ini
View file

@ -21,6 +21,8 @@ skip-if = true || stylo # disabled - See bug 1390396 and 1293844
[test_custom_element_throw_on_dynamic_markup_insertion.html] [test_custom_element_throw_on_dynamic_markup_insertion.html]
[test_custom_element_get.html] [test_custom_element_get.html]
[test_custom_element_when_defined.html] [test_custom_element_when_defined.html]
[test_custom_element_uncatchable_exception.html]
skip-if = !debug # TestFunctions only applied in debug builds
[test_nested_content_element.html] [test_nested_content_element.html]
[test_dest_insertion_points.html] [test_dest_insertion_points.html]
[test_dest_insertion_points_shadow.html] [test_dest_insertion_points_shadow.html]

37
dom/tests/mochitest/webcomponents/test_custom_element_uncatchable_exception.html Normal file
View file

@ -0,0 +1,37 @@
<!DOCTYPE HTML>
<html>
<!--
https://bugzilla.mozilla.org/show_bug.cgi?id=1407669
-->
<head>
<title>Test custom elements runtime exception</title>
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
</head>
<body>
<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1407669">Bug 1407669</a>
<script type="text/javascript">
SimpleTest.waitForExplicitFinish();
SpecialPowers.pushPrefEnv({set: [['dom.expose_test_interfaces', true]]}, function() {
window.onerror = function (e) {
ok(false, "How did we get here!?");
}
class Foo extends HTMLElement {
constructor() {
super()
TestFunctions.throwUncatchableException();
}
}
customElements.define("test-custom-element", Foo);
let element = document.createElement("test-custom-element");
is(element instanceof HTMLUnknownElement, true, "It should be a HTMLUnknownElement when uncatchable exception throws in constructor");
ok(true, "Uncatchable exception should not report");
SimpleTest.finish();
});
</script>
</body>
</html>