wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-09 09:18:42 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #2053 - Part 5: Throw a DOMException instead of a JS exception for some errors

Browse source
This commit is contained in:
FranklinDM 2023-04-06 23:22:50 +08:00 • committed by roytam1
commit ef8e3b5419
7 changed files with 23 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
dom/performance/Performance.cpp
View file

@ -269,13 +269,13 @@ already_AddRefed<PerformanceMark> Performance::Mark(
nsCOMPtr<nsIGlobalObject> parent = GetParentObject();
if (!parent || parent->IsDying() || !parent->GetGlobalJSObject()) {
aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR);
aRv.Throw(NS_ERROR_DOM_UT_UNAVAILABLE_GLOBAL_OBJECT);
return nullptr;
}
GlobalObject global(aCx, parent->GetGlobalJSObject());
if (global.Failed()) {
aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR);
aRv.Throw(NS_ERROR_DOM_UT_UNAVAILABLE_GLOBAL_OBJECT);
return nullptr;
}
@ -340,7 +340,7 @@ Performance::ConvertMarkToTimestampWithString(const nsAString& aName,
return arr.LastElement()->StartTime();
}
aRv.ThrowTypeError<MSG_PMO_UNKNOWN_MARK_NAME>(aName);
aRv.Throw(NS_ERROR_DOM_UT_UNKNOWN_MARK_NAME);
return 0;
}
@ -403,8 +403,7 @@ DOMHighResTimeStamp Performance::ConvertNameToTimestamp(const nsAString& aName,
GetPerformanceTimingFromString(aName);
MOZ_ASSERT(endTime >= 0);
if (endTime == 0) {
// Was given a PerformanceTiming attribute which isn't available yet.
aRv.Throw(NS_ERROR_DOM_INVALID_ACCESS_ERR);
aRv.Throw(NS_ERROR_DOM_UT_UNAVAILABLE_ATTR);
return 0;
}