wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-05 23:07:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

Revert "Enable Array.prototype.values"

Browse source 
This reverts commit 424ed1b165e50f2e71c082c0c70fcda2a2764d18.
This commit is contained in:
wolfbeast 2018-03-28 11:32:03 +02:00 • committed by Roy Tam
commit ef6478af8c
3 changed files with 17 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
js/src/jsarray.cpp
View file

@ -3165,7 +3165,9 @@ static const JSFunctionSpec array_methods[] = {
JS_SELF_HOSTED_SYM_FN(iterator, "ArrayValues", 0,0), JS_SELF_HOSTED_SYM_FN(iterator, "ArrayValues", 0,0),
JS_SELF_HOSTED_FN("entries", "ArrayEntries", 0,0), JS_SELF_HOSTED_FN("entries", "ArrayEntries", 0,0),
JS_SELF_HOSTED_FN("keys", "ArrayKeys", 0,0), JS_SELF_HOSTED_FN("keys", "ArrayKeys", 0,0),
#ifdef NIGHTLY_BUILD
JS_SELF_HOSTED_FN("values", "ArrayValues", 0,0), JS_SELF_HOSTED_FN("values", "ArrayValues", 0,0),
#endif
/* ES7 additions */ /* ES7 additions */
JS_SELF_HOSTED_FN("includes", "ArrayIncludes", 2,0), JS_SELF_HOSTED_FN("includes", "ArrayIncludes", 2,0),

20
js/src/tests/ecma_6/Array/values.js
View file

@ -1,18 +1,20 @@
/* Any copyright is dedicated to the Public Domain. /* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/licenses/publicdomain/ */ * http://creativecommons.org/licenses/publicdomain/ */
assertEq(Array.prototype.values, Array.prototype[Symbol.iterator]); if (Array.prototype.values) {
assertEq(Array.prototype.values.name, "values"); assertEq(Array.prototype.values, Array.prototype[Symbol.iterator]);
assertEq(Array.prototype.values.length, 0); assertEq(Array.prototype.values.name, "values");
assertEq(Array.prototype.values.length, 0);
function valuesUnscopeable() { function valuesUnscopeable() {
var values = "foo"; var values = "foo";
with ([1, 2, 3]) { with ([1, 2, 3]) {
assertEq(indexOf, Array.prototype.indexOf); assertEq(indexOf, Array.prototype.indexOf);
assertEq(values, "foo"); assertEq(values, "foo");
}
} }
valuesUnscopeable();
} }
valuesUnscopeable();
if (typeof reportCompare === 'function') if (typeof reportCompare === 'function')
reportCompare(0, 0); reportCompare(0, 0);

5
js/xpconnect/tests/chrome/test_xrayToJS.xul
View file

@ -198,7 +198,10 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=933681
"pop", "shift", "unshift", "splice", "concat", "slice", "lastIndexOf", "indexOf", "pop", "shift", "unshift", "splice", "concat", "slice", "lastIndexOf", "indexOf",
"includes", "forEach", "map", "reduce", "reduceRight", "filter", "some", "every", "find", "includes", "forEach", "map", "reduce", "reduceRight", "filter", "some", "every", "find",
"findIndex", "copyWithin", "fill", Symbol.iterator, Symbol.unscopables, "entries", "keys", "findIndex", "copyWithin", "fill", Symbol.iterator, Symbol.unscopables, "entries", "keys",
"values", "constructor"]; "constructor"];
if (isNightlyBuild) {
gPrototypeProperties['Array'].push("values");
}
gConstructorProperties['Array'] = gConstructorProperties['Array'] =
constructorProps(["join", "reverse", "sort", "push", "pop", "shift", constructorProps(["join", "reverse", "sort", "push", "pop", "shift",
"unshift", "splice", "concat", "slice", "isArray", "unshift", "splice", "concat", "slice", "isArray",