From edb82ec9f248e708092ba7f6163baa321fa3ae9e Mon Sep 17 00:00:00 2001 From: Brian Smith Date: Sat, 22 Apr 2023 03:57:28 -0500 Subject: [PATCH] Issue #1691 - Part 11: Fix incorrect reference counting in ModuleScript class. (cherry picked from commit 4ef1fa98c9518f5c107424667229ddb6f9f97767) --- dom/script/ModuleScript.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dom/script/ModuleScript.cpp b/dom/script/ModuleScript.cpp index 8004ede3c6..425da8207a 100644 --- a/dom/script/ModuleScript.cpp +++ b/dom/script/ModuleScript.cpp @@ -132,6 +132,7 @@ ModuleScript::UnlinkModuleRecord() this); JS::SetModulePrivate(mModuleRecord, JS::UndefinedValue()); mModuleRecord = nullptr; + Release(); } } @@ -156,6 +157,7 @@ ModuleScript::SetModuleRecord(JS::Handle aModuleRecord) MOZ_ASSERT(JS::GetModulePrivate(mModuleRecord).isUndefined()); JS::SetModulePrivate(mModuleRecord, JS::PrivateValue(this)); HoldJSObjects(this); + AddRef(); } void @@ -168,7 +170,6 @@ ModuleScript::SetParseError(const JS::Value& aError) UnlinkModuleRecord(); mParseError = aError; HoldJSObjects(this); - AddRef(); } void