wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-21 15:57:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors

Browse source 
* Part 1: make conversion CTORs explicit.
  Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().

Tag #1273
This commit is contained in:
Matt A. Tobin 2019-11-10 19:11:03 -05:00 • committed by Roy Tam
commit eaac1c967d
57 changed files with 71 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mailnews/local/src/nsMailboxProtocol.h
View file

@ -50,7 +50,7 @@ class nsMailboxProtocol : public nsMsgProtocol
public:
// Creating a protocol instance requires the URL which needs to be run AND it requires
// a transport layer.
nsMailboxProtocol(nsIURI * aURL);
explicit nsMailboxProtocol(nsIURI * aURL);
virtual ~nsMailboxProtocol();
// initialization function given a new url and transport layer

2
mailnews/local/src/nsParseMailbox.h
View file

@ -133,7 +133,7 @@ protected:
class nsMsgMailboxParser : public nsIStreamListener, public nsParseMailMessageState, public nsMsgLineBuffer
{
public:
nsMsgMailboxParser(nsIMsgFolder *);
explicit nsMsgMailboxParser(nsIMsgFolder *);
nsMsgMailboxParser();
nsresult Init();

2
mailnews/local/src/nsPop3Protocol.h
View file

@ -254,7 +254,7 @@ class nsPop3Protocol : public nsMsgProtocol,
public nsIMsgAsyncPromptListener
{
public:
nsPop3Protocol(nsIURI* aURL);
explicit nsPop3Protocol(nsIURI* aURL);
NS_DECL_ISUPPORTS_INHERITED
NS_DECL_NSIPOP3PROTOCOL