wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-22 08:27:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors

Browse source 
* Part 1: make conversion CTORs explicit.
  Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().

Tag #1273
This commit is contained in:
Matt A. Tobin 2019-11-10 19:11:03 -05:00 • committed by Roy Tam
commit eaac1c967d
57 changed files with 71 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mailnews/import/src/nsImportFieldMap.h
View file

@ -24,7 +24,7 @@ public:
NS_DECL_NSIIMPORTFIELDMAP
nsImportFieldMap(nsIStringBundle *aBundle);
explicit nsImportFieldMap(nsIStringBundle *aBundle);
static NS_METHOD Create(nsIStringBundle *aBundle, nsISupports *aOuter, REFNSIID aIID, void **aResult);

4
mailnews/import/src/nsImportMail.cpp
View file

@ -993,7 +993,7 @@ bool nsImportGenericMail::CreateFolder(nsIMsgFolder **ppFolder)
class GetSubFoldersRunnable : public mozilla::Runnable
{
public:
GetSubFoldersRunnable(nsIMsgFolder *aFolder);
explicit GetSubFoldersRunnable(nsIMsgFolder *aFolder);
NS_DECL_NSIRUNNABLE
private:
nsCOMPtr<nsIMsgFolder> m_folder;
@ -1182,7 +1182,7 @@ nsresult ProxyCreateSubfolder(nsIMsgFolder *aFolder, const nsAString &aName)
class ForceDBClosedRunnable : public mozilla::Runnable
{
public:
ForceDBClosedRunnable(nsIMsgFolder *aFolder);
explicit ForceDBClosedRunnable(nsIMsgFolder *aFolder);
NS_DECL_NSIRUNNABLE
protected:
nsCOMPtr<nsIMsgFolder> m_folder;