wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-23 00:47:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors

Browse source 
* Part 1: make conversion CTORs explicit.
  Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().

Tag #1273
This commit is contained in:
Matt A. Tobin 2019-11-10 19:11:03 -05:00 • committed by Roy Tam
commit eaac1c967d
57 changed files with 71 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp
View file

@ -898,7 +898,7 @@ public:
NS_DECL_NSISTREAMLISTENER
NS_DECL_NSIMSGHEADERSINK
TokenStreamListener(TokenAnalyzer* analyzer);
explicit TokenStreamListener(TokenAnalyzer* analyzer);
protected:
virtual ~TokenStreamListener();
TokenAnalyzer* mAnalyzer;

4
mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h
View file

@ -40,7 +40,7 @@ struct CorpusToken;
*/
class TokenEnumeration {
public:
TokenEnumeration(PLDHashTable* table);
explicit TokenEnumeration(PLDHashTable* table);
bool hasMoreTokens();
BaseToken* nextToken();
@ -96,7 +96,7 @@ public:
BaseToken* add(const char* word);
protected:
TokenHash(uint32_t entrySize);
explicit TokenHash(uint32_t entrySize);
PLArenaPool mWordPool;
uint32_t mEntrySize;
PLDHashTable mTokenTable;