wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-20 23:37:33 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors

Browse source 
* Part 1: make conversion CTORs explicit.
  Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().

Tag #1273
This commit is contained in:
Matt A. Tobin 2019-11-10 19:11:03 -05:00 • committed by Roy Tam
commit eaac1c967d
57 changed files with 71 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mailnews/db/msgdb/public/nsDBFolderInfo.h
View file

@ -31,7 +31,7 @@ class nsDBFolderInfo : public nsIDBFolderInfo
public:
friend class nsMsgDatabase;
nsDBFolderInfo(nsMsgDatabase *mdb);
explicit nsDBFolderInfo(nsMsgDatabase *mdb);
NS_DECL_ISUPPORTS
// interface methods.

2
mailnews/db/msgdb/src/nsMailDatabase.cpp
View file

@ -336,7 +336,7 @@ public:
// nsISimpleEnumerator methods:
NS_DECL_NSISIMPLEENUMERATOR
nsMsgOfflineOpEnumerator(nsMailDatabase* db);
explicit nsMsgOfflineOpEnumerator(nsMailDatabase* db);
protected:
virtual ~nsMsgOfflineOpEnumerator();

2
mailnews/db/msgdb/src/nsMsgDatabase.cpp
View file

@ -1024,7 +1024,7 @@ class MsgDBReporter final : public nsIMemoryReporter
{
nsMsgDatabase *mDatabase;
public:
MsgDBReporter(nsMsgDatabase *db) : mDatabase(db) {}
explicit MsgDBReporter(nsMsgDatabase *db) : mDatabase(db) {}
NS_DECL_ISUPPORTS
NS_IMETHOD GetName(nsACString &aName)

2
mailnews/db/msgdb/src/nsMsgHdr.cpp
View file

@ -998,7 +998,7 @@ public:
NS_DECL_ISUPPORTS
NS_DECL_NSIUTF8STRINGENUMERATOR
nsMsgPropertyEnumerator(nsMsgHdr* aHdr);
explicit nsMsgPropertyEnumerator(nsMsgHdr* aHdr);
void PrefetchNext();
protected: