wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-23 00:47:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors

Browse source 
* Part 1: make conversion CTORs explicit.
  Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().

Tag #1273
This commit is contained in:
Matt A. Tobin 2019-11-10 19:11:03 -05:00 • committed by Roy Tam
commit eaac1c967d
57 changed files with 71 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mailnews/base/src/nsMailDirProvider.h
View file

@ -29,7 +29,7 @@ private:
NS_DECL_ISUPPORTS
NS_DECL_NSISIMPLEENUMERATOR
AppendingEnumerator(nsISimpleEnumerator* aBase);
explicit AppendingEnumerator(nsISimpleEnumerator* aBase);
private:
~AppendingEnumerator() {}

2
mailnews/base/src/nsMsgCopyService.h
View file

@ -29,7 +29,7 @@ class nsCopySource
{
public:
nsCopySource();
nsCopySource(nsIMsgFolder* srcFolder);
explicit nsCopySource(nsIMsgFolder* srcFolder);
~nsCopySource();
void AddMessage(nsIMsgDBHdr* aMsg);

2
mailnews/base/src/nsMsgDBView.h
View file

@ -500,7 +500,7 @@ private:
NS_DECL_NSISIMPLEENUMERATOR
// nsMsgThreadEnumerator methods:
nsMsgViewHdrEnumerator(nsMsgDBView *view);
explicit nsMsgViewHdrEnumerator(nsMsgDBView *view);
RefPtr<nsMsgDBView> m_view;
nsMsgViewIndex m_curHdrIndex;

2
mailnews/base/src/nsMsgGroupThread.h
View file

@ -21,7 +21,7 @@ public:
friend class nsMsgGroupView;
nsMsgGroupThread();
nsMsgGroupThread(nsIMsgDatabase *db);
explicit nsMsgGroupThread(nsIMsgDatabase *db);
NS_DECL_NSIMSGTHREAD
NS_DECL_ISUPPORTS

4
mailnews/base/src/nsMsgPrintEngine.cpp
View file

@ -653,7 +653,7 @@ nsMsgPrintEngine::PrintMsgWindow()
class nsPrintMsgWindowEvent : public mozilla::Runnable
{
public:
nsPrintMsgWindowEvent(nsMsgPrintEngine *mpe)
explicit nsPrintMsgWindowEvent(nsMsgPrintEngine *mpe)
: mMsgPrintEngine(mpe)
{}
@ -672,7 +672,7 @@ private:
class nsStartNextPrintOpEvent : public mozilla::Runnable
{
public:
nsStartNextPrintOpEvent(nsMsgPrintEngine *mpe)
explicit nsStartNextPrintOpEvent(nsMsgPrintEngine *mpe)
: mMsgPrintEngine(mpe)
{}