Ensure we AddRef prior to early return in MediaType::Assign.

This commit is contained in:
wolfbeast 2019-05-28 14:41:20 +02:00 committed by Roy Tam
commit dfb01e0384

View file

@ -82,7 +82,10 @@ MediaType::Assign(const AM_MEDIA_TYPE* aMediaType)
Clear();
// Shallow copy.
memcpy(this, aMediaType, sizeof(AM_MEDIA_TYPE));
memcpy(static_cast<AM_MEDIA_TYPE*>(this), aMediaType, sizeof(AM_MEDIA_TYPE));
if (pUnk)
pUnk->AddRef();
// Create deep copy of incoming data...
if (cbFormat) {
@ -92,9 +95,6 @@ MediaType::Assign(const AM_MEDIA_TYPE* aMediaType)
memcpy(pbFormat, aMediaType->pbFormat, cbFormat);
}
if (pUnk)
pUnk->AddRef();
return S_OK;
}