wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-14 19:27:30 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1397114 - Disable smooth scrolling when value changes come from input box

Browse source
This commit is contained in:
janekptacijarabaci 2018-03-31 07:05:58 +02:00 • committed by Roy Tam
commit def56bfceb
2 changed files with 8 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

16
toolkit/content/widgets/spinner.js
View file

@ -123,8 +123,6 @@ function Spinner(props, context) {
/**
* Whenever scroll event is detected:
* - Update the index state
* - If a smooth scroll has reached its destination, set [isScrolling] state
* to false
* - If the value has changed, update the [value] state and call [setValue]
* - If infinite scrolling is on, reset the scrolling position if necessary
*/
@ -137,14 +135,8 @@ function Spinner(props, context) {
const value = itemsView[this.state.index + viewportTopOffset].value;
// Check if smooth scrolling has reached its destination.
// This prevents input box jump when input box changes values.
if (this.state.value == value && this.state.isScrolling) {
this.state.isScrolling = false;
}
// Call setValue if value has changed, and is not smooth scrolling
if (this.state.value != value && !this.state.isScrolling) {
// Call setValue if value has changed
if (this.state.value != value) {
this.state.value = value;
this.props.setValue(value);
}
@ -443,10 +435,6 @@ function Spinner(props, context) {
_smoothScrollToIndex(index) {
const element = this.elements.spinner.children[index];
if (element) {
// Set the isScrolling flag before smooth scrolling begins
// and remove it when it has reached the destination.
// This prevents input box jump when input box changes values
this.state.isScrolling = true;
element.scrollIntoView({
behavior: "smooth", block: "start"
});