Hard-disable the use of sponsored tiles.

This commit is contained in:
wolfbeast 2017-11-01 02:42:25 +01:00 • committed by Roy Tam
commit d789488825
5 changed files with 14 additions and 25 deletions

View file

@ -1061,7 +1061,6 @@ pref("services.sync.prefs.sync.browser.download.useDownloadDir", true);
pref("services.sync.prefs.sync.browser.formfill.enable", true); pref("services.sync.prefs.sync.browser.formfill.enable", true);
pref("services.sync.prefs.sync.browser.link.open_newwindow", true); pref("services.sync.prefs.sync.browser.link.open_newwindow", true);
pref("services.sync.prefs.sync.browser.newtabpage.enabled", true); pref("services.sync.prefs.sync.browser.newtabpage.enabled", true);
pref("services.sync.prefs.sync.browser.newtabpage.enhanced", true);
pref("services.sync.prefs.sync.browser.newtabpage.pinned", true); pref("services.sync.prefs.sync.browser.newtabpage.pinned", true);
pref("services.sync.prefs.sync.browser.offline-apps.notify", true); pref("services.sync.prefs.sync.browser.offline-apps.notify", true);
pref("services.sync.prefs.sync.browser.safebrowsing.phishing.enabled", true); pref("services.sync.prefs.sync.browser.safebrowsing.phishing.enabled", true);
@ -1156,7 +1155,7 @@ pref("browser.newtabpage.introShown", false);
pref("browser.newtabpage.enabled", true); pref("browser.newtabpage.enabled", true);
// Toggles the enhanced content of 'about:newtab'. Shows sponsored tiles. // Toggles the enhanced content of 'about:newtab'. Shows sponsored tiles.
sticky_pref("browser.newtabpage.enhanced", true); sticky_pref("browser.newtabpage.enhanced", false);
// enables Activity Stream inspired layout // enables Activity Stream inspired layout
pref("browser.newtabpage.compact", false); pref("browser.newtabpage.compact", false);

View file

@ -25,7 +25,6 @@ var gCustomize = {
this._nodes.button.addEventListener("click", e => this.showPanel(e)); this._nodes.button.addEventListener("click", e => this.showPanel(e));
this._nodes.blank.addEventListener("click", this); this._nodes.blank.addEventListener("click", this);
this._nodes.classic.addEventListener("click", this); this._nodes.classic.addEventListener("click", this);
this._nodes.enhanced.addEventListener("click", this);
this._nodes.learn.addEventListener("click", this); this._nodes.learn.addEventListener("click", this);
this.updateSelected(); this.updateSelected();
@ -87,11 +86,7 @@ var gCustomize = {
sendAsyncMessage("NewTab:Customize", {enabled: false, enhanced: false}); sendAsyncMessage("NewTab:Customize", {enabled: false, enhanced: false});
break; break;
case "newtab-customize-classic": case "newtab-customize-classic":
if (this._nodes.enhanced.getAttribute("selected")){ sendAsyncMessage("NewTab:Customize", {enabled: true, enhanced: false});
sendAsyncMessage("NewTab:Customize", {enabled: true, enhanced: true});
} else {
sendAsyncMessage("NewTab:Customize", {enabled: true, enhanced: false});
}
break; break;
case "newtab-customize-enhanced": case "newtab-customize-enhanced":
sendAsyncMessage("NewTab:Customize", {enabled: true, enhanced: !gAllPages.enhanced}); sendAsyncMessage("NewTab:Customize", {enabled: true, enhanced: !gAllPages.enhanced});
@ -114,9 +109,9 @@ var gCustomize = {
}, },
updateSelected: function() { updateSelected: function() {
let {enabled, enhanced} = gAllPages; let {enabled} = gAllPages;
let selected = enabled ? enhanced ? "enhanced" : "classic" : "blank"; let selected = enabled ? "classic" : "blank";
["enhanced", "classic", "blank"].forEach(id => { ["classic", "blank"].forEach(id => {
let node = this._nodes[id]; let node = this._nodes[id];
if (id == selected) { if (id == selected) {
node.setAttribute("selected", true); node.setAttribute("selected", true);
@ -125,9 +120,5 @@ var gCustomize = {
node.removeAttribute("selected"); node.removeAttribute("selected");
} }
}); });
if (selected == "enhanced") {
// If enhanced is selected, so is classic (since enhanced is a subitem of classic)
this._nodes.classic.setAttribute("selected", true);
}
}, },
}; };

View file

@ -33,15 +33,8 @@
<div id="newtab-customize-title" class="newtab-customize-panel-item"> <div id="newtab-customize-title" class="newtab-customize-panel-item">
<label>&newtab.customize.cog.title2;</label> <label>&newtab.customize.cog.title2;</label>
</div> </div>
<div id="newtab-customize-classic" class="newtab-customize-panel-item selectable">
<div class="newtab-customize-complex-option"> <label>&newtab.customize.classic;</label>
<div id="newtab-customize-classic" class="newtab-customize-panel-superitem newtab-customize-panel-item selectable">
<label>&newtab.customize.classic;</label>
</div>
<div id="newtab-customize-enhanced" class="newtab-customize-panel-subitem">
<label class="checkbox"></label>
<label>&newtab.customize.cog.enhanced;</label>
</div>
</div> </div>
<div id="newtab-customize-blank" class="newtab-customize-panel-item selectable"> <div id="newtab-customize-blank" class="newtab-customize-panel-item selectable">
<label>&newtab.customize.blank2;</label> <label>&newtab.customize.blank2;</label>

View file

@ -249,10 +249,15 @@ var AllPages = {
* Returns whether the history tiles are enhanced. * Returns whether the history tiles are enhanced.
*/ */
get enhanced() { get enhanced() {
#ifdef MC_BASILISK
// Hard-block the use of sponsored tiles.
return false;
#else
if (this._enhanced === null) if (this._enhanced === null)
this._enhanced = Services.prefs.getBoolPref(PREF_NEWTAB_ENHANCED); this._enhanced = Services.prefs.getBoolPref(PREF_NEWTAB_ENHANCED);
return this._enhanced; return this._enhanced;
#endif
}, },
/** /**

View file

@ -57,7 +57,6 @@ EXTRA_JS_MODULES += [
'Locale.jsm', 'Locale.jsm',
'Log.jsm', 'Log.jsm',
'Memory.jsm', 'Memory.jsm',
'NewTabUtils.jsm',
'NLP.jsm', 'NLP.jsm',
'ObjectUtils.jsm', 'ObjectUtils.jsm',
'PageMenu.jsm', 'PageMenu.jsm',
@ -104,6 +103,8 @@ EXTRA_JS_MODULES += [
EXTRA_JS_MODULES.third_party.jsesc += ['third_party/jsesc/jsesc.js'] EXTRA_JS_MODULES.third_party.jsesc += ['third_party/jsesc/jsesc.js']
EXTRA_JS_MODULES.sessionstore += ['sessionstore/Utils.jsm'] EXTRA_JS_MODULES.sessionstore += ['sessionstore/Utils.jsm']
EXTRA_PP_JS_MODULES += ['NewTabUtils.jsm']
if not CONFIG['MOZ_WEBEXTENSIONS']: if not CONFIG['MOZ_WEBEXTENSIONS']:
EXTRA_PP_JS_MODULES += ['UpdateChannel.jsm'] EXTRA_PP_JS_MODULES += ['UpdateChannel.jsm']