wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-08 00:38:39 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #1319 - Remove stderr_to_file.

Browse source 
This local-debug function is only useful for Android to work around
issues with logspewing and should never be in production builds anyway.
This commit is contained in:
wolfbeast 2020-01-14 13:23:39 +01:00 • committed by Roy Tam
commit d28c0b15a6
2 changed files with 0 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

24
xpcom/glue/nsCRTGlue.cpp
View file

@ -321,30 +321,6 @@ set_stderr_callback(StderrCallback aCallback)
sStderrCallback = aCallback;
}
#if defined(ANDROID) && !defined(RELEASE_OR_BETA)
static FILE* sStderrCopy = nullptr;
void
stderr_to_file(const char* aFmt, va_list aArgs)
{
vfprintf(sStderrCopy, aFmt, aArgs);
}
void
copy_stderr_to_file(const char* aFile)
{
if (sStderrCopy) {
return;
}
size_t buflen = strlen(aFile) + 16;
char* buf = (char*)malloc(buflen);
snprintf(buf, buflen, "%s.%u", aFile, (uint32_t)getpid());
sStderrCopy = fopen(buf, "w");
free(buf);
set_stderr_callback(stderr_to_file);
}
#endif
#ifdef HAVE_VA_COPY
#define VARARGS_ASSIGN(foo, bar) VA_COPY(foo,bar)
#elif defined(HAVE_VA_LIST_AS_ARRAY)

27
xpcom/glue/nsDebug.h
View file

@ -426,33 +426,6 @@ void fprintf_stderr(FILE* aFile, const char* aFmt, ...) MOZ_FORMAT_PRINTF(2, 3);
// advanced performance debugging and display/layers visualization.
void set_stderr_callback(StderrCallback aCallback);
#if defined(ANDROID) && !defined(RELEASE_OR_BETA)
// Call this if you want a copy of stderr logging sent to a file. This is
// useful to get around logcat overflow problems on android devices, which use
// a circular logcat buffer and can intermittently drop messages if there's too
// much spew.
//
// This is intended for local debugging only, DO NOT USE IN PRODUCTION CODE.
// (This is ifndef RELEASE_OR_BETA to catch uses of it that accidentally get
// checked in). Using this will also prevent the profiler from getting a copy of
// the stderr messages which it uses for various visualization features.
//
// This function can be called from any thread, but if it is called multiple
// times all invocations must be on the same thread. Invocations after the
// first one are ignored, so you can safely put it inside a loop, for example.
// Once this is called there is no way to turn it off; all stderr output from
// that point forward will go to the file. Note that the output is subject to
// buffering so make sure you have enough output to flush the messages you care
// about before you terminate the process.
//
// The file passed in should be writable, so on Android devices a path like
// "/data/local/tmp/blah" is a good one to use as it is world-writable and will
// work even in B2G child processes which have reduced privileges. Note that the
// actual file created will have the PID appended to the path you pass in, so
// that on B2G the output from each process goes to a separate file.
void copy_stderr_to_file(const char* aFile);
#endif
#ifdef __cplusplus
}
#endif