diff --git a/js/src/wasm/WasmCompile.cpp b/js/src/wasm/WasmCompile.cpp index 51f27f17a8..b8c113049f 100644 --- a/js/src/wasm/WasmCompile.cpp +++ b/js/src/wasm/WasmCompile.cpp @@ -72,7 +72,7 @@ DecodeCodeSection(Decoder& d, ModuleGenerator& mg) return false; if (sectionStart == Decoder::NotStarted) { - if (mg.numFuncDefs() != 0) + if (mg.env().numFuncDefs() != 0) return d.fail("expected function bodies"); return mg.finishFuncDefs(); @@ -82,11 +82,11 @@ DecodeCodeSection(Decoder& d, ModuleGenerator& mg) if (!d.readVarU32(&numFuncDefs)) return d.fail("expected function body count"); - if (numFuncDefs != mg.numFuncDefs()) + if (numFuncDefs != mg.env().numFuncDefs()) return d.fail("function body count does not match function signature count"); for (uint32_t funcDefIndex = 0; funcDefIndex < numFuncDefs; funcDefIndex++) { - if (!DecodeFunctionBody(d, mg, mg.numFuncImports() + funcDefIndex)) + if (!DecodeFunctionBody(d, mg, mg.env().numFuncImports() + funcDefIndex)) return false; } diff --git a/js/src/wasm/WasmGenerator.cpp b/js/src/wasm/WasmGenerator.cpp index ce05cc2aae..3e395738c3 100644 --- a/js/src/wasm/WasmGenerator.cpp +++ b/js/src/wasm/WasmGenerator.cpp @@ -792,15 +792,6 @@ ModuleGenerator::numFuncImports() const return metadata_->funcImports.length(); } -uint32_t -ModuleGenerator::numFuncDefs() const -{ - // asm.js overallocates the length of funcSigs and in general does not know - // the number of function definitions until it's done compiling. - MOZ_ASSERT(!isAsmJS()); - return env_->funcSigs.length() - numFuncImports(); -} - const SigWithId& ModuleGenerator::funcSig(uint32_t funcIndex) const { @@ -965,7 +956,7 @@ ModuleGenerator::finishFuncDefs() for (uint32_t i = AsmJSFirstDefFuncIndex; i < numFinishedFuncDefs_; i++) MOZ_ASSERT(funcCodeRange(i).funcIndex() == i); } else { - MOZ_ASSERT(numFinishedFuncDefs_ == numFuncDefs()); + MOZ_ASSERT(numFinishedFuncDefs_ == env_->numFuncDefs()); for (uint32_t i = 0; i < env_->numFuncs(); i++) MOZ_ASSERT(funcCodeRange(i).funcIndex() == i); } diff --git a/js/src/wasm/WasmGenerator.h b/js/src/wasm/WasmGenerator.h index 844e9c9ea1..f20ee70cda 100644 --- a/js/src/wasm/WasmGenerator.h +++ b/js/src/wasm/WasmGenerator.h @@ -286,10 +286,6 @@ private: // Globals: const GlobalDescVector& globals() const { return env_->globals; } - // Functions declarations: - uint32_t numFuncImports() const; - uint32_t numFuncDefs() const; - // Function definitions: MOZ_MUST_USE bool startFuncDefs(); MOZ_MUST_USE bool startFuncDef(uint32_t lineOrBytecode, FunctionGenerator* fg);