From a0aabcdaba47bead47279cfa9875acbe667a4f62 Mon Sep 17 00:00:00 2001 From: trav90 Date: Fri, 29 Jan 2021 16:28:26 -0600 Subject: [PATCH 1/6] Issue #1723 - Fix Linux build bustage in HTMLMenuItemElement.cpp --- dom/html/HTMLMenuItemElement.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dom/html/HTMLMenuItemElement.cpp b/dom/html/HTMLMenuItemElement.cpp index 6cf4eb40c2..42cee132e6 100644 --- a/dom/html/HTMLMenuItemElement.cpp +++ b/dom/html/HTMLMenuItemElement.cpp @@ -16,11 +16,10 @@ nsGenericHTMLElement* NS_NewHTMLMenuItemElement(already_AddRefed&& aNodeInfo, mozilla::dom::FromParser aFromParser) { - RefPtr nodeInfo(aNodeInfo); if (mozilla::Preferences::GetBool("dom.menuitem.enabled")) { - return new mozilla::dom::HTMLMenuItemElement(nodeInfo.forget(), aFromParser); + return new mozilla::dom::HTMLMenuItemElement(aNodeInfo, aFromParser); } else { - return new mozilla::dom::HTMLUnknownElement(nodeInfo.forget()); + return new mozilla::dom::HTMLUnknownElement(aNodeInfo); } } From 0989dc6d2d89ccb86c145125957be14d107d6dfd Mon Sep 17 00:00:00 2001 From: Moonchild Date: Sat, 30 Jan 2021 01:06:36 +0000 Subject: [PATCH 2/6] [js] Remove unused promise selfhosting functions. These are leftovers from when promises were fully self-hosted and could cause confusion if left in place. --- js/src/vm/SelfHosting.cpp | 107 -------------------------------------- 1 file changed, 107 deletions(-) diff --git a/js/src/vm/SelfHosting.cpp b/js/src/vm/SelfHosting.cpp index df326a69e7..9c20bbe9df 100644 --- a/js/src/vm/SelfHosting.cpp +++ b/js/src/vm/SelfHosting.cpp @@ -2156,105 +2156,6 @@ intrinsic_PromiseResolve(JSContext* cx, unsigned argc, Value* vp) return true; } -static bool -intrinsic_CreatePendingPromise(JSContext* cx, unsigned argc, Value* vp) -{ - CallArgs args = CallArgsFromVp(argc, vp); - MOZ_ASSERT(args.length() == 0); - RootedObject promise(cx, PromiseObject::createSkippingExecutor(cx)); - if (!promise) - return false; - args.rval().setObject(*promise); - return true; -} - -static bool -intrinsic_CreatePromiseResolvedWith(JSContext* cx, unsigned argc, Value* vp) -{ - CallArgs args = CallArgsFromVp(argc, vp); - MOZ_ASSERT(args.length() == 1); - RootedObject promise(cx, PromiseObject::unforgeableResolve(cx, args[0])); - if (!promise) - return false; - args.rval().setObject(*promise); - return true; -} - -static bool -intrinsic_CreatePromiseRejectedWith(JSContext* cx, unsigned argc, Value* vp) -{ - CallArgs args = CallArgsFromVp(argc, vp); - MOZ_ASSERT(args.length() == 1); - RootedObject promise(cx, PromiseObject::unforgeableReject(cx, args[0])); - if (!promise) - return false; - args.rval().setObject(*promise); - return true; -} - -static bool -intrinsic_ResolvePromise(JSContext* cx, unsigned argc, Value* vp) -{ - CallArgs args = CallArgsFromVp(argc, vp); - MOZ_ASSERT(args.length() == 2); - Rooted promise(cx, &args[0].toObject().as()); - if (!PromiseObject::resolve(cx, promise, args[1])) - return false; - args.rval().setUndefined(); - return true; -} - -static bool -intrinsic_RejectPromise(JSContext* cx, unsigned argc, Value* vp) -{ - CallArgs args = CallArgsFromVp(argc, vp); - MOZ_ASSERT(args.length() == 2); - Rooted promise(cx, &args[0].toObject().as()); - if (!PromiseObject::reject(cx, promise, args[1])) - return false; - args.rval().setUndefined(); - return true; -} - -static bool -intrinsic_CallOriginalPromiseThen(JSContext* cx, unsigned argc, Value* vp) -{ - CallArgs args = CallArgsFromVp(argc, vp); - MOZ_ASSERT(args.length() >= 2); - - RootedObject promise(cx, &args[0].toObject()); - Value val = args[1]; - RootedObject onResolvedObj(cx, val.isUndefined() ? nullptr : val.toObjectOrNull()); - val = args.get(2); - RootedObject onRejectedObj(cx, val.isUndefined() ? nullptr : val.toObjectOrNull()); - - RootedObject resultPromise(cx, JS::CallOriginalPromiseThen(cx, promise, onResolvedObj, - onRejectedObj)); - if (!resultPromise) - return false; - args.rval().setObject(*resultPromise); - return true; -} - -static bool -intrinsic_AddPromiseReactions(JSContext* cx, unsigned argc, Value* vp) -{ - CallArgs args = CallArgsFromVp(argc, vp); - MOZ_ASSERT(args.length() >= 2); - - RootedObject promise(cx, &args[0].toObject()); - Value val = args[1]; - RootedObject onResolvedObj(cx, val.isUndefined() ? nullptr : val.toObjectOrNull()); - val = args.get(2); - RootedObject onRejectedObj(cx, val.isUndefined() ? nullptr : val.toObjectOrNull()); - - bool result = JS::AddPromiseReactions(cx, promise, onResolvedObj, onRejectedObj); - if (!result) - return false; - args.rval().setUndefined(); - return true; -} - // The self-hosting global isn't initialized with the normal set of builtins. // Instead, individual C++-implemented functions that're required by // self-hosted code are defined as global functions. Accessing these @@ -2659,14 +2560,6 @@ static const JSFunctionSpec intrinsic_functions[] = { JS_FN("AddModuleNamespaceBinding", intrinsic_AddModuleNamespaceBinding, 4, 0), JS_FN("ModuleNamespaceExports", intrinsic_ModuleNamespaceExports, 1, 0), - JS_FN("CreatePendingPromise", intrinsic_CreatePendingPromise, 0, 0), - JS_FN("CreatePromiseResolvedWith", intrinsic_CreatePromiseResolvedWith, 1, 0), - JS_FN("CreatePromiseRejectedWith", intrinsic_CreatePromiseRejectedWith, 1, 0), - JS_FN("ResolvePromise", intrinsic_ResolvePromise, 2, 0), - JS_FN("RejectPromise", intrinsic_RejectPromise, 2, 0), - JS_FN("AddPromiseReactions", intrinsic_AddPromiseReactions, 3, 0), - JS_FN("CallOriginalPromiseThen", intrinsic_CallOriginalPromiseThen, 3, 0), - JS_FN("IsPromiseObject", intrinsic_IsInstanceOfBuiltin, 1, 0), JS_FN("CallPromiseMethodIfWrapped", CallNonGenericSelfhostedMethod>, 2, 0), JS_FN("PromiseResolve", intrinsic_PromiseResolve, 2, 0), From 6de0687efc8ea7ddbc7034b5a8c90c36b831b26c Mon Sep 17 00:00:00 2001 From: Moonchild Date: Sat, 30 Jan 2021 13:16:33 +0000 Subject: [PATCH 3/6] Issue #1720 - Remove explicit header inclusion from npapi.h This should allow the header to be used outside of the UXP tree for compiling plugins etc. Resolves #1720 --- dom/plugins/base/npapi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/dom/plugins/base/npapi.h b/dom/plugins/base/npapi.h index 38b296c63d..aa6a66b2bd 100644 --- a/dom/plugins/base/npapi.h +++ b/dom/plugins/base/npapi.h @@ -46,7 +46,6 @@ #if defined(MOZ_X11) #include #include -#include "X11UndefineNone.h" #endif #endif From 065bbb79406d2a1747e11bec95151b097c84afee Mon Sep 17 00:00:00 2001 From: Moonchild Date: Sun, 31 Jan 2021 19:53:17 +0000 Subject: [PATCH 4/6] [Basilisk] Remove unused nsis var --- application/basilisk/installer/windows/nsis/uninstaller.nsi | 1 - 1 file changed, 1 deletion(-) diff --git a/application/basilisk/installer/windows/nsis/uninstaller.nsi b/application/basilisk/installer/windows/nsis/uninstaller.nsi index c556b0a900..7f577d27f3 100644 --- a/application/basilisk/installer/windows/nsis/uninstaller.nsi +++ b/application/basilisk/installer/windows/nsis/uninstaller.nsi @@ -40,7 +40,6 @@ RequestExecutionLevel user "Software\Microsoft\Windows\CurrentVersion\Uninstall\MozillaMaintenanceService" Var TmpVal -Var MaintCertKey ; Other included files may depend upon these includes! ; The following includes are provided by NSIS. From 9b0375dffd9fb19811a4db05b5365b9b8e887687 Mon Sep 17 00:00:00 2001 From: roytam1 Date: Wed, 3 Feb 2021 10:09:12 +0800 Subject: [PATCH 5/6] [Pale-Moon] (a late) version bump for reflecting engine version change --- application/palemoon/config/version.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/application/palemoon/config/version.txt b/application/palemoon/config/version.txt index 80701602f5..1a7d407756 100644 --- a/application/palemoon/config/version.txt +++ b/application/palemoon/config/version.txt @@ -1 +1 @@ -28.10.2a1 \ No newline at end of file +28.10.3a1 \ No newline at end of file From ad0f41898a5884f1d056494ea964a951c3cd9b9a Mon Sep 17 00:00:00 2001 From: Moonchild Date: Sun, 31 Jan 2021 19:52:58 +0000 Subject: [PATCH 6/6] [Pale-Moon] Remove unused nsis var --- application/palemoon/installer/windows/nsis/uninstaller.nsi | 1 - 1 file changed, 1 deletion(-) diff --git a/application/palemoon/installer/windows/nsis/uninstaller.nsi b/application/palemoon/installer/windows/nsis/uninstaller.nsi index 44b7c060b9..bee091d6fb 100644 --- a/application/palemoon/installer/windows/nsis/uninstaller.nsi +++ b/application/palemoon/installer/windows/nsis/uninstaller.nsi @@ -40,7 +40,6 @@ RequestExecutionLevel user "Software\Microsoft\Windows\CurrentVersion\Uninstall\MozillaMaintenanceService" Var TmpVal -Var MaintCertKey ; Other included files may depend upon these includes! ; The following includes are provided by NSIS.