From c9a887d46b595f63661662325048450c1ab23d5f Mon Sep 17 00:00:00 2001 From: wolfbeast Date: Tue, 14 Jan 2020 13:35:03 +0100 Subject: [PATCH] Issue #1319 - Disable MOZ_LOGGING in production builds. This makes it only enabled in debug builds, instead, where logging would be most useful. --- xpcom/base/Logging.h | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/xpcom/base/Logging.h b/xpcom/base/Logging.h index 040fb9c497..765fdf0852 100644 --- a/xpcom/base/Logging.h +++ b/xpcom/base/Logging.h @@ -22,16 +22,7 @@ // work progresses more functionality will be swapped out in favor of // mozilla logging implementations. -// We normally have logging enabled everywhere, but measurements showed that -// having logging enabled on Android is quite expensive (hundreds of kilobytes -// for both the format strings for logging and the code to perform all the -// logging calls). Because retrieving logs from a mobile device is -// comparatively more difficult for Android than it is for desktop and because -// desktop machines tend to be less space/bandwidth-constrained than Android -// devices, we've chosen to leave logging enabled on desktop, but disabled on -// Android. Given that logging can still be useful for development purposes, -// however, we leave logging enabled on Android developer builds. -#if !defined(ANDROID) || !defined(RELEASE_OR_BETA) +#ifdef DEBUG #define MOZ_LOGGING_ENABLED 1 #else #define MOZ_LOGGING_ENABLED 0