wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-22 16:37:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

imported changes from mozilla NSS:

Browse source 
- Bug 1755555 - Hold tokensLock through nssToken_GetSlot calls in nssTrustDomain_GetActiveSlots. r=rrelyea (a36477f0)
- Bug 1370866 - Check return value of PK11Slot_GetNSSToken. r=djackson (d7e8c2df)
- Bug 1751157 - Throw illegal_parameter alert for illegal extensions in handshake message. r=djackson (8fd5ca0c)
This commit is contained in:
roytam1 2022-02-25 13:02:18 +08:00
commit c403014cbe
14 changed files with 282 additions and 106 deletions
Download patch file Download diff file Expand all files Collapse all files

73
security/nss/gtests/ssl_gtest/ssl_extension_unittest.cc
View file

@ -730,7 +730,7 @@ TEST_F(TlsExtensionTest13Stream, AddServerSignatureAlgorithmsOnResumption) {
DataBuffer empty; DataBuffer empty;
MakeTlsFilter<TlsExtensionInjector>(server_, ssl_signature_algorithms_xtn, MakeTlsFilter<TlsExtensionInjector>(server_, ssl_signature_algorithms_xtn,
empty); empty);
client_->ExpectSendAlert(kTlsAlertUnsupportedExtension); client_->ExpectSendAlert(kTlsAlertIllegalParameter);
server_->ExpectSendAlert(kTlsAlertUnexpectedMessage); server_->ExpectSendAlert(kTlsAlertUnexpectedMessage);
ConnectExpectFail(); ConnectExpectFail();
EXPECT_EQ(SSL_ERROR_EXTENSION_DISALLOWED_FOR_VERSION, client_->error_code()); EXPECT_EQ(SSL_ERROR_EXTENSION_DISALLOWED_FOR_VERSION, client_->error_code());
@ -1178,19 +1178,6 @@ TEST_P(TlsBogusExtensionTest13, AddBogusExtensionHelloRetryRequest) {
Run(kTlsHandshakeHelloRetryRequest); Run(kTlsHandshakeHelloRetryRequest);
} }
TEST_P(TlsBogusExtensionTest13, AddVersionExtensionEncryptedExtensions) {
Run(kTlsHandshakeEncryptedExtensions, ssl_tls13_supported_versions_xtn);
}
TEST_P(TlsBogusExtensionTest13, AddVersionExtensionCertificate) {
Run(kTlsHandshakeCertificate, ssl_tls13_supported_versions_xtn);
}
TEST_P(TlsBogusExtensionTest13, AddVersionExtensionCertificateRequest) {
server_->RequestClientAuth(false);
Run(kTlsHandshakeCertificateRequest, ssl_tls13_supported_versions_xtn);
}
// NewSessionTicket allows unknown extensions AND it isn't protected by the // NewSessionTicket allows unknown extensions AND it isn't protected by the
// Finished. So adding an unknown extension doesn't cause an error. // Finished. So adding an unknown extension doesn't cause an error.
TEST_P(TlsBogusExtensionTest13, AddBogusExtensionNewSessionTicket) { TEST_P(TlsBogusExtensionTest13, AddBogusExtensionNewSessionTicket) {
@ -1208,6 +1195,55 @@ TEST_P(TlsBogusExtensionTest13, AddBogusExtensionNewSessionTicket) {
SendReceive(); SendReceive();
} }
class TlsDisallowedExtensionTest13 : public TlsBogusExtensionTest {
protected:
void ConnectAndFail(uint8_t message) override {
ConnectExpectAlert(client_, kTlsAlertIllegalParameter);
}
};
TEST_P(TlsDisallowedExtensionTest13, AddVersionExtensionEncryptedExtensions) {
Run(kTlsHandshakeEncryptedExtensions, ssl_tls13_supported_versions_xtn);
}
TEST_P(TlsDisallowedExtensionTest13, AddVersionExtensionCertificate) {
Run(kTlsHandshakeCertificate, ssl_tls13_supported_versions_xtn);
}
TEST_P(TlsDisallowedExtensionTest13, AddVersionExtensionCertificateRequest) {
server_->RequestClientAuth(false);
Run(kTlsHandshakeCertificateRequest, ssl_tls13_supported_versions_xtn);
}
/* For unadvertised disallowed extensions an unsupported_extension alert is
* thrown since NSS checks for unadvertised extensions before its disallowed
* extension check. */
class TlsDisallowedUnadvertisedExtensionTest13 : public TlsBogusExtensionTest {
protected:
void ConnectAndFail(uint8_t message) override {
uint8_t alert = kTlsAlertUnsupportedExtension;
if (message == kTlsHandshakeCertificateRequest) {
alert = kTlsAlertIllegalParameter;
}
ConnectExpectAlert(client_, alert);
}
};
TEST_P(TlsDisallowedUnadvertisedExtensionTest13,
AddPSKExtensionEncryptedExtensions) {
Run(kTlsHandshakeEncryptedExtensions, ssl_tls13_pre_shared_key_xtn);
}
TEST_P(TlsDisallowedUnadvertisedExtensionTest13, AddPSKExtensionCertificate) {
Run(kTlsHandshakeCertificate, ssl_tls13_pre_shared_key_xtn);
}
TEST_P(TlsDisallowedUnadvertisedExtensionTest13,
AddPSKExtensionCertificateRequest) {
server_->RequestClientAuth(false);
Run(kTlsHandshakeCertificateRequest, ssl_tls13_pre_shared_key_xtn);
}
TEST_P(TlsConnectStream, IncludePadding) { TEST_P(TlsConnectStream, IncludePadding) {
EnsureTlsSetup(); EnsureTlsSetup();
@ -1269,4 +1305,13 @@ INSTANTIATE_TEST_CASE_P(BogusExtension13, TlsBogusExtensionTest13,
::testing::Combine(TlsConnectTestBase::kTlsVariantsAll, ::testing::Combine(TlsConnectTestBase::kTlsVariantsAll,
TlsConnectTestBase::kTlsV13)); TlsConnectTestBase::kTlsV13));
INSTANTIATE_TEST_SUITE_P(DisallowedExtension13, TlsDisallowedExtensionTest13,
::testing::Combine(TlsConnectTestBase::kTlsVariantsAll,
TlsConnectTestBase::kTlsV13));
INSTANTIATE_TEST_SUITE_P(DisallowedUnadvertisedExtension13,
TlsDisallowedUnadvertisedExtensionTest13,
::testing::Combine(TlsConnectTestBase::kTlsVariantsAll,
TlsConnectTestBase::kTlsV13));
} // namespace nss_test } // namespace nss_test

2
security/nss/lib/certdb/crl.c
View file

@ -1391,6 +1391,7 @@ TokenCRLStillExists(CERTSignedCrl* crl)
arena = NSSArena_Create(); arena = NSSArena_Create();
PORT_Assert(arena); PORT_Assert(arena);
if (!arena) { if (!arena) {
(void)nssToken_Destroy(instance.token);
return PR_FALSE; return PR_FALSE;
} }
@ -1412,6 +1413,7 @@ TokenCRLStillExists(CERTSignedCrl* crl)
xstatus = PR_FALSE; xstatus = PR_FALSE;
} }
NSSArena_Destroy(arena); NSSArena_Destroy(arena);
(void)nssToken_Destroy(instance.token);
return xstatus; return xstatus;
} }

6
security/nss/lib/certdb/stanpcertdb.c
View file

@ -299,9 +299,15 @@ __CERT_AddTempCertToPerm(CERTCertificate *cert, char *nickname,
/* Import the perm instance onto the internal token */ /* Import the perm instance onto the internal token */
slot = PK11_GetInternalKeySlot(); slot = PK11_GetInternalKeySlot();
internal = PK11Slot_GetNSSToken(slot); internal = PK11Slot_GetNSSToken(slot);
if (!internal) {
PK11_FreeSlot(slot);
PORT_SetError(SEC_ERROR_NO_TOKEN);
return SECFailure;
}
permInstance = nssToken_ImportCertificate( permInstance = nssToken_ImportCertificate(
internal, NULL, NSSCertificateType_PKIX, &c->id, stanNick, &c->encoding, internal, NULL, NSSCertificateType_PKIX, &c->id, stanNick, &c->encoding,
&c->issuer, &c->subject, &c->serial, cert->emailAddr, PR_TRUE); &c->issuer, &c->subject, &c->serial, cert->emailAddr, PR_TRUE);
(void)nssToken_Destroy(internal);
nss_ZFreeIf(stanNick); nss_ZFreeIf(stanNick);
stanNick = NULL; stanNick = NULL;
PK11_FreeSlot(slot); PK11_FreeSlot(slot);

13
security/nss/lib/dev/devtoken.c
View file

@ -53,13 +53,6 @@ nssToken_Remove(
nssTokenObjectCache_Clear(tok->cache); nssTokenObjectCache_Clear(tok->cache);
} }
NSS_IMPLEMENT void
NSSToken_Destroy(
NSSToken *tok)
{
(void)nssToken_Destroy(tok);
}
NSS_IMPLEMENT NSSToken * NSS_IMPLEMENT NSSToken *
nssToken_AddRef( nssToken_AddRef(
NSSToken *tok) NSSToken *tok)
@ -996,8 +989,9 @@ sha1_hash(NSSItem *input, NSSItem *output)
NSSToken *token = PK11Slot_GetNSSToken(internal); NSSToken *token = PK11Slot_GetNSSToken(internal);
ap = NSSAlgorithmAndParameters_CreateSHA1Digest(NULL); ap = NSSAlgorithmAndParameters_CreateSHA1Digest(NULL);
(void)nssToken_Digest(token, NULL, ap, input, output, NULL); (void)nssToken_Digest(token, NULL, ap, input, output, NULL);
PK11_FreeSlot(token->pk11slot);
nss_ZFreeIf(ap); nss_ZFreeIf(ap);
(void)nssToken_Destroy(token);
PK11_FreeSlot(internal);
} }
static void static void
@ -1008,8 +1002,9 @@ md5_hash(NSSItem *input, NSSItem *output)
NSSToken *token = PK11Slot_GetNSSToken(internal); NSSToken *token = PK11Slot_GetNSSToken(internal);
ap = NSSAlgorithmAndParameters_CreateMD5Digest(NULL); ap = NSSAlgorithmAndParameters_CreateMD5Digest(NULL);
(void)nssToken_Digest(token, NULL, ap, input, output, NULL); (void)nssToken_Digest(token, NULL, ap, input, output, NULL);
PK11_FreeSlot(token->pk11slot);
nss_ZFreeIf(ap); nss_ZFreeIf(ap);
(void)nssToken_Destroy(token);
PK11_FreeSlot(internal);
} }
static CK_TRUST static CK_TRUST

18
security/nss/lib/dev/devutil.c
View file

@ -56,7 +56,7 @@ nssCryptokiObject_Destroy(
nssCryptokiObject *object) nssCryptokiObject *object)
{ {
if (object) { if (object) {
nssToken_Destroy(object->token); (void)nssToken_Destroy(object->token);
nss_ZFreeIf(object->label); nss_ZFreeIf(object->label);
nss_ZFreeIf(object); nss_ZFreeIf(object);
} }
@ -150,19 +150,12 @@ nssTokenArray_Destroy(
if (tokens) { if (tokens) {
NSSToken **tokenp; NSSToken **tokenp;
for (tokenp = tokens; *tokenp; tokenp++) { for (tokenp = tokens; *tokenp; tokenp++) {
nssToken_Destroy(*tokenp); (void)nssToken_Destroy(*tokenp);
} }
nss_ZFreeIf(tokens); nss_ZFreeIf(tokens);
} }
} }
NSS_IMPLEMENT void
NSSTokenArray_Destroy(
NSSToken **tokens)
{
nssTokenArray_Destroy(tokens);
}
NSS_IMPLEMENT void NSS_IMPLEMENT void
nssCryptokiObjectArray_Destroy( nssCryptokiObjectArray_Destroy(
nssCryptokiObject **objects) nssCryptokiObject **objects)
@ -365,7 +358,7 @@ create_object(
/* The cache is tied to the token, and therefore the objects /* The cache is tied to the token, and therefore the objects
* in it should not hold references to the token. * in it should not hold references to the token.
*/ */
nssToken_Destroy(object->token); (void)nssToken_Destroy(object->token);
rvCachedObject->object = object; rvCachedObject->object = object;
rvCachedObject->attributes = nss_ZNEWARRAY(arena, CK_ATTRIBUTE, numTypes); rvCachedObject->attributes = nss_ZNEWARRAY(arena, CK_ATTRIBUTE, numTypes);
if (!rvCachedObject->attributes) { if (!rvCachedObject->attributes) {
@ -568,7 +561,7 @@ get_token_objects_for_cache(
&numObjects, &numObjects,
&status); &status);
if (status != PR_SUCCESS) { if (status != PR_SUCCESS) {
nss_ZFreeIf(objects); nssCryptokiObjectArray_Destroy(objects);
return status; return status;
} }
for (i = 0; i < numObjects; i++) { for (i = 0; i < numObjects; i++) {
@ -584,7 +577,8 @@ get_token_objects_for_cache(
} else { } else {
PRUint32 j; PRUint32 j;
for (j = 0; j < i; j++) { for (j = 0; j < i; j++) {
/* sigh */ /* Any token references that were removed in successful loop iterations
* need to be restored before we call nssCryptokiObjectArray_Destroy */
nssToken_AddRef(cache->objects[objectType][j]->object->token); nssToken_AddRef(cache->objects[objectType][j]->object->token);
nssArena_Destroy(cache->objects[objectType][j]->arena); nssArena_Destroy(cache->objects[objectType][j]->arena);
} }

9
security/nss/lib/pk11wrap/pk11auth.c
View file

@ -4,6 +4,8 @@
/* /*
* This file deals with PKCS #11 passwords and authentication. * This file deals with PKCS #11 passwords and authentication.
*/ */
#include "dev.h"
#include "dev3hack.h"
#include "seccomon.h" #include "seccomon.h"
#include "secmod.h" #include "secmod.h"
#include "secmodi.h" #include "secmodi.h"
@ -637,8 +639,11 @@ PK11_DoPassword(PK11SlotInfo *slot, CK_SESSION_HANDLE session,
} }
if (rv == SECSuccess) { if (rv == SECSuccess) {
if (!contextSpecific && !PK11_IsFriendly(slot)) { if (!contextSpecific && !PK11_IsFriendly(slot)) {
nssTrustDomain_UpdateCachedTokenCerts(slot->nssToken->trustDomain, NSSToken *token = PK11Slot_GetNSSToken(slot);
slot->nssToken); if (token) {
nssTrustDomain_UpdateCachedTokenCerts(token->trustDomain, token);
(void)nssToken_Destroy(token);
}
} }
} else if (!attempt) } else if (!attempt)
PORT_SetError(SEC_ERROR_BAD_PASSWORD); PORT_SetError(SEC_ERROR_BAD_PASSWORD);

74
security/nss/lib/pk11wrap/pk11cert.c
View file

@ -240,16 +240,17 @@ pk11_fastCert(PK11SlotInfo *slot, CK_OBJECT_HANDLE certID,
NSSCertificate *c; NSSCertificate *c;
nssCryptokiObject *co = NULL; nssCryptokiObject *co = NULL;
nssPKIObject *pkio; nssPKIObject *pkio;
NSSToken *token;
NSSTrustDomain *td = STAN_GetDefaultTrustDomain(); NSSTrustDomain *td = STAN_GetDefaultTrustDomain();
/* Get the cryptoki object from the handle */ /* Get the cryptoki object from the handle */
token = PK11Slot_GetNSSToken(slot); NSSToken *token = PK11Slot_GetNSSToken(slot);
if (token && token->defaultSession) { if (!token || !token->defaultSession) {
co = nssCryptokiObject_Create(token, token->defaultSession, certID); (void)nssToken_Destroy(token); /* null token is ok */
} else {
PORT_SetError(SEC_ERROR_NO_TOKEN); PORT_SetError(SEC_ERROR_NO_TOKEN);
return NULL;
} }
co = nssCryptokiObject_Create(token, token->defaultSession, certID);
(void)nssToken_Destroy(token);
if (!co) { if (!co) {
return NULL; return NULL;
} }
@ -752,7 +753,7 @@ find_certs_from_uri(const char *uriString, void *wincx)
nssPKIObjectCollection_AddInstances(collection, instances, 0); nssPKIObjectCollection_AddInstances(collection, instances, 0);
nss_ZFreeIf(instances); nss_ZFreeIf(instances);
} }
nssToken_Destroy(*tok); (void)nssToken_Destroy(*tok);
} }
nss_ZFreeIf(tokens); nss_ZFreeIf(tokens);
nssList_Destroy(certList); nssList_Destroy(certList);
@ -861,9 +862,7 @@ find_certs_from_nickname(const char *nickname, void *wincx)
} else { } else {
slot = PK11_GetInternalKeySlot(); slot = PK11_GetInternalKeySlot();
token = PK11Slot_GetNSSToken(slot); token = PK11Slot_GetNSSToken(slot);
if (token) { if (!token) {
nssToken_AddRef(token);
} else {
PORT_SetError(SEC_ERROR_NO_TOKEN); PORT_SetError(SEC_ERROR_NO_TOKEN);
} }
} }
@ -927,7 +926,7 @@ find_certs_from_nickname(const char *nickname, void *wincx)
} }
loser: loser:
if (token) { if (token) {
nssToken_Destroy(token); (void)nssToken_Destroy(token);
} }
if (slot) { if (slot) {
PK11_FreeSlot(slot); PK11_FreeSlot(slot);
@ -1127,15 +1126,15 @@ PK11_ImportCert(PK11SlotInfo *slot, CERTCertificate *cert,
PRStatus status; PRStatus status;
NSSCertificate *c; NSSCertificate *c;
nssCryptokiObject *keyobj, *certobj; nssCryptokiObject *keyobj, *certobj;
NSSToken *token = PK11Slot_GetNSSToken(slot); NSSToken *token = NULL;
SECItem *keyID = pk11_mkcertKeyID(cert);
char *emailAddr = NULL; char *emailAddr = NULL;
nssCertificateStoreTrace lockTrace = { NULL, NULL, PR_FALSE, PR_FALSE }; nssCertificateStoreTrace lockTrace = { NULL, NULL, PR_FALSE, PR_FALSE };
nssCertificateStoreTrace unlockTrace = { NULL, NULL, PR_FALSE, PR_FALSE }; nssCertificateStoreTrace unlockTrace = { NULL, NULL, PR_FALSE, PR_FALSE };
SECItem *keyID = pk11_mkcertKeyID(cert);
if (keyID == NULL) { if (keyID == NULL) {
goto loser; /* error code should be set already */ goto loser; /* error code should be set already */
} }
token = PK11Slot_GetNSSToken(slot);
if (!token) { if (!token) {
PORT_SetError(SEC_ERROR_NO_TOKEN); PORT_SetError(SEC_ERROR_NO_TOKEN);
goto loser; goto loser;
@ -1228,8 +1227,12 @@ PK11_ImportCert(PK11SlotInfo *slot, CERTCertificate *cert,
(void)STAN_ForceCERTCertificateUpdate(c); (void)STAN_ForceCERTCertificateUpdate(c);
nssCertificate_Destroy(c); nssCertificate_Destroy(c);
SECITEM_FreeItem(keyID, PR_TRUE); SECITEM_FreeItem(keyID, PR_TRUE);
(void)nssToken_Destroy(token);
return SECSuccess; return SECSuccess;
loser: loser:
if (token) {
(void)nssToken_Destroy(token);
}
CERT_MapStanError(); CERT_MapStanError();
SECITEM_FreeItem(keyID, PR_TRUE); SECITEM_FreeItem(keyID, PR_TRUE);
if (PORT_GetError() != SEC_ERROR_TOKEN_NOT_LOGGED_IN) { if (PORT_GetError() != SEC_ERROR_TOKEN_NOT_LOGGED_IN) {
@ -1508,7 +1511,7 @@ PK11_FindCertByIssuerAndSNOnToken(PK11SlotInfo *slot,
NSSCertificate *cert = NULL; NSSCertificate *cert = NULL;
NSSDER issuer, serial; NSSDER issuer, serial;
NSSTrustDomain *td = STAN_GetDefaultTrustDomain(); NSSTrustDomain *td = STAN_GetDefaultTrustDomain();
NSSToken *token = slot->nssToken; NSSToken *token = NULL;
nssSession *session; nssSession *session;
nssCryptokiObject *instance = NULL; nssCryptokiObject *instance = NULL;
nssPKIObject *object = NULL; nssPKIObject *object = NULL;
@ -1523,12 +1526,18 @@ PK11_FindCertByIssuerAndSNOnToken(PK11SlotInfo *slot,
return NULL; return NULL;
} }
/* Paranoia */ token = PK11Slot_GetNSSToken(slot);
if (token == NULL) { if (!token) {
PORT_SetError(SEC_ERROR_NO_TOKEN); PORT_SetError(SEC_ERROR_NO_TOKEN);
return NULL; return NULL;
} }
session = nssToken_GetDefaultSession(token); /* non-owning */
if (!session) {
(void)nssToken_Destroy(token);
return NULL;
}
/* PKCS#11 needs to use DER-encoded serial numbers. Create a /* PKCS#11 needs to use DER-encoded serial numbers. Create a
* CERTIssuerAndSN that actually has the encoded value and pass that * CERTIssuerAndSN that actually has the encoded value and pass that
* to PKCS#11 (and the crypto context). * to PKCS#11 (and the crypto context).
@ -1537,20 +1546,17 @@ PK11_FindCertByIssuerAndSNOnToken(PK11SlotInfo *slot,
&issuerSN->serialNumber, &issuerSN->serialNumber,
SEC_ASN1_GET(SEC_IntegerTemplate)); SEC_ASN1_GET(SEC_IntegerTemplate));
if (!derSerial) { if (!derSerial) {
(void)nssToken_Destroy(token);
return NULL; return NULL;
} }
NSSITEM_FROM_SECITEM(&issuer, &issuerSN->derIssuer); NSSITEM_FROM_SECITEM(&issuer, &issuerSN->derIssuer);
NSSITEM_FROM_SECITEM(&serial, derSerial); NSSITEM_FROM_SECITEM(&serial, derSerial);
session = nssToken_GetDefaultSession(token);
if (!session) {
goto loser;
}
instance = nssToken_FindCertificateByIssuerAndSerialNumber(token, session, instance = nssToken_FindCertificateByIssuerAndSerialNumber(token, session,
&issuer, &serial, nssTokenSearchType_TokenForced, &status); &issuer, &serial, nssTokenSearchType_TokenForced, &status);
(void)nssToken_Destroy(token);
SECITEM_FreeItem(derSerial, PR_TRUE); SECITEM_FreeItem(derSerial, PR_TRUE);
if (!instance) { if (!instance) {
@ -2220,16 +2226,22 @@ PK11_TraverseCertsForSubjectInSlot(CERTCertificate *cert, PK11SlotInfo *slot,
td = STAN_GetDefaultTrustDomain(); td = STAN_GetDefaultTrustDomain();
NSSITEM_FROM_SECITEM(&subject, &cert->derSubject); NSSITEM_FROM_SECITEM(&subject, &cert->derSubject);
token = PK11Slot_GetNSSToken(slot); token = PK11Slot_GetNSSToken(slot);
if (!token) {
return SECSuccess;
}
if (!nssToken_IsPresent(token)) { if (!nssToken_IsPresent(token)) {
(void)nssToken_Destroy(token);
return SECSuccess; return SECSuccess;
} }
collection = nssCertificateCollection_Create(td, NULL); collection = nssCertificateCollection_Create(td, NULL);
if (!collection) { if (!collection) {
(void)nssToken_Destroy(token);
return SECFailure; return SECFailure;
} }
subjectList = nssList_Create(NULL, PR_FALSE); subjectList = nssList_Create(NULL, PR_FALSE);
if (!subjectList) { if (!subjectList) {
nssPKIObjectCollection_Destroy(collection); nssPKIObjectCollection_Destroy(collection);
(void)nssToken_Destroy(token);
return SECFailure; return SECFailure;
} }
(void)nssTrustDomain_GetCertsForSubjectFromCache(td, &subject, (void)nssTrustDomain_GetCertsForSubjectFromCache(td, &subject,
@ -2244,6 +2256,7 @@ PK11_TraverseCertsForSubjectInSlot(CERTCertificate *cert, PK11SlotInfo *slot,
certs = nssPKIObjectCollection_GetCertificates(collection, certs = nssPKIObjectCollection_GetCertificates(collection,
NULL, 0, NULL); NULL, 0, NULL);
nssPKIObjectCollection_Destroy(collection); nssPKIObjectCollection_Destroy(collection);
(void)nssToken_Destroy(token);
if (certs) { if (certs) {
CERTCertificate *oldie; CERTCertificate *oldie;
NSSCertificate **cp; NSSCertificate **cp;
@ -2277,7 +2290,8 @@ PK11_TraverseCertsForNicknameInSlot(SECItem *nickname, PK11SlotInfo *slot,
nssList *nameList = NULL; nssList *nameList = NULL;
nssTokenSearchType tokenOnly = nssTokenSearchType_TokenOnly; nssTokenSearchType tokenOnly = nssTokenSearchType_TokenOnly;
token = PK11Slot_GetNSSToken(slot); token = PK11Slot_GetNSSToken(slot);
if (!nssToken_IsPresent(token)) { if (!token || !nssToken_IsPresent(token)) {
(void)nssToken_Destroy(token);
return SECSuccess; return SECSuccess;
} }
if (nickname->data[nickname->len - 1] != '\0') { if (nickname->data[nickname->len - 1] != '\0') {
@ -2307,6 +2321,7 @@ PK11_TraverseCertsForNicknameInSlot(SECItem *nickname, PK11SlotInfo *slot,
certs = nssPKIObjectCollection_GetCertificates(collection, certs = nssPKIObjectCollection_GetCertificates(collection,
NULL, 0, NULL); NULL, 0, NULL);
nssPKIObjectCollection_Destroy(collection); nssPKIObjectCollection_Destroy(collection);
(void)nssToken_Destroy(token);
if (certs) { if (certs) {
CERTCertificate *oldie; CERTCertificate *oldie;
NSSCertificate **cp; NSSCertificate **cp;
@ -2326,6 +2341,7 @@ PK11_TraverseCertsForNicknameInSlot(SECItem *nickname, PK11SlotInfo *slot,
nss_ZFreeIf(nick); nss_ZFreeIf(nick);
return (nssrv == PR_SUCCESS) ? SECSuccess : SECFailure; return (nssrv == PR_SUCCESS) ? SECSuccess : SECFailure;
loser: loser:
(void)nssToken_Destroy(token);
if (created) { if (created) {
nss_ZFreeIf(nick); nss_ZFreeIf(nick);
} }
@ -2351,16 +2367,22 @@ PK11_TraverseCertsInSlot(PK11SlotInfo *slot,
NSSCertificate **certs; NSSCertificate **certs;
nssTokenSearchType tokenOnly = nssTokenSearchType_TokenOnly; nssTokenSearchType tokenOnly = nssTokenSearchType_TokenOnly;
tok = PK11Slot_GetNSSToken(slot); tok = PK11Slot_GetNSSToken(slot);
if (!tok) {
return SECSuccess;
}
if (!nssToken_IsPresent(tok)) { if (!nssToken_IsPresent(tok)) {
(void)nssToken_Destroy(tok);
return SECSuccess; return SECSuccess;
} }
collection = nssCertificateCollection_Create(td, NULL); collection = nssCertificateCollection_Create(td, NULL);
if (!collection) { if (!collection) {
(void)nssToken_Destroy(tok);
return SECFailure; return SECFailure;
} }
certList = nssList_Create(NULL, PR_FALSE); certList = nssList_Create(NULL, PR_FALSE);
if (!certList) { if (!certList) {
nssPKIObjectCollection_Destroy(collection); nssPKIObjectCollection_Destroy(collection);
(void)nssToken_Destroy(tok);
return SECFailure; return SECFailure;
} }
(void)nssTrustDomain_GetCertsFromCache(td, certList); (void)nssTrustDomain_GetCertsFromCache(td, certList);
@ -2373,6 +2395,7 @@ PK11_TraverseCertsInSlot(PK11SlotInfo *slot,
certs = nssPKIObjectCollection_GetCertificates(collection, certs = nssPKIObjectCollection_GetCertificates(collection,
NULL, 0, NULL); NULL, 0, NULL);
nssPKIObjectCollection_Destroy(collection); nssPKIObjectCollection_Destroy(collection);
(void)nssToken_Destroy(tok);
if (certs) { if (certs) {
CERTCertificate *oldie; CERTCertificate *oldie;
NSSCertificate **cp; NSSCertificate **cp;
@ -2412,7 +2435,6 @@ PK11_FindCertFromDERCertItem(PK11SlotInfo *slot, const SECItem *inDerCert,
SECStatus rv; SECStatus rv;
CERTCertificate *cert = NULL; CERTCertificate *cert = NULL;
tok = PK11Slot_GetNSSToken(slot);
NSSITEM_FROM_SECITEM(&derCert, inDerCert); NSSITEM_FROM_SECITEM(&derCert, inDerCert);
rv = pk11_AuthenticateUnfriendly(slot, PR_TRUE, wincx); rv = pk11_AuthenticateUnfriendly(slot, PR_TRUE, wincx);
if (rv != SECSuccess) { if (rv != SECSuccess) {
@ -2420,8 +2442,14 @@ PK11_FindCertFromDERCertItem(PK11SlotInfo *slot, const SECItem *inDerCert,
return NULL; return NULL;
} }
tok = PK11Slot_GetNSSToken(slot);
if (!tok) {
PK11_FreeSlot(slot);
return NULL;
}
co = nssToken_FindCertificateByEncodedCertificate(tok, NULL, &derCert, co = nssToken_FindCertificateByEncodedCertificate(tok, NULL, &derCert,
nssTokenSearchType_TokenOnly, NULL); nssTokenSearchType_TokenOnly, NULL);
(void)nssToken_Destroy(tok);
if (co) { if (co) {
cert = PK11_MakeCertFromHandle(slot, co->handle, NULL); cert = PK11_MakeCertFromHandle(slot, co->handle, NULL);

28
security/nss/lib/pk11wrap/pk11nobj.c
View file

@ -411,12 +411,17 @@ PK11_FindCrlByName(PK11SlotInfo **slot, CK_OBJECT_HANDLE *crlHandle,
nssPKIObjectCollection *collection; nssPKIObjectCollection *collection;
nssTokenSearchType tokenOnly = nssTokenSearchType_TokenOnly; nssTokenSearchType tokenOnly = nssTokenSearchType_TokenOnly;
NSSToken *token = PK11Slot_GetNSSToken(*slot); NSSToken *token = PK11Slot_GetNSSToken(*slot);
if (!token) {
goto loser;
}
collection = nssCRLCollection_Create(td, NULL); collection = nssCRLCollection_Create(td, NULL);
if (!collection) { if (!collection) {
(void)nssToken_Destroy(token);
goto loser; goto loser;
} }
instances = nssToken_FindCRLsBySubject(token, NULL, &subject, instances = nssToken_FindCRLsBySubject(token, NULL, &subject,
tokenOnly, 0, NULL); tokenOnly, 0, NULL);
(void)nssToken_Destroy(token);
nssPKIObjectCollection_AddInstances(collection, instances, 0); nssPKIObjectCollection_AddInstances(collection, instances, 0);
nss_ZFreeIf(instances); nss_ZFreeIf(instances);
crls = nssPKIObjectCollection_GetCRLs(collection, NULL, 0, NULL); crls = nssPKIObjectCollection_GetCRLs(collection, NULL, 0, NULL);
@ -480,16 +485,21 @@ PK11_PutCrl(PK11SlotInfo *slot, SECItem *crl, SECItem *name,
char *url, int type) char *url, int type)
{ {
NSSItem derCRL, derSubject; NSSItem derCRL, derSubject;
NSSToken *token = PK11Slot_GetNSSToken(slot); NSSToken *token;
nssCryptokiObject *object; nssCryptokiObject *object;
PRBool isKRL = (type == SEC_CRL_TYPE) ? PR_FALSE : PR_TRUE; PRBool isKRL = (type == SEC_CRL_TYPE) ? PR_FALSE : PR_TRUE;
CK_OBJECT_HANDLE rvH; CK_OBJECT_HANDLE rvH;
NSSITEM_FROM_SECITEM(&derSubject, name); NSSITEM_FROM_SECITEM(&derSubject, name);
NSSITEM_FROM_SECITEM(&derCRL, crl); NSSITEM_FROM_SECITEM(&derCRL, crl);
token = PK11Slot_GetNSSToken(slot);
if (!token) {
PORT_SetError(SEC_ERROR_NO_TOKEN);
return CK_INVALID_HANDLE;
}
object = nssToken_ImportCRL(token, NULL, object = nssToken_ImportCRL(token, NULL,
&derSubject, &derCRL, isKRL, url, PR_TRUE); &derSubject, &derCRL, isKRL, url, PR_TRUE);
(void)nssToken_Destroy(token);
if (object) { if (object) {
rvH = object->handle; rvH = object->handle;
@ -508,8 +518,8 @@ SECStatus
SEC_DeletePermCRL(CERTSignedCrl *crl) SEC_DeletePermCRL(CERTSignedCrl *crl)
{ {
PRStatus status; PRStatus status;
NSSToken *token;
nssCryptokiObject *object; nssCryptokiObject *object;
NSSToken *token;
PK11SlotInfo *slot = crl->slot; PK11SlotInfo *slot = crl->slot;
if (slot == NULL) { if (slot == NULL) {
@ -518,13 +528,17 @@ SEC_DeletePermCRL(CERTSignedCrl *crl)
PORT_SetError(SEC_ERROR_CRL_INVALID); PORT_SetError(SEC_ERROR_CRL_INVALID);
return SECFailure; return SECFailure;
} }
token = PK11Slot_GetNSSToken(slot);
object = nss_ZNEW(NULL, nssCryptokiObject); token = PK11Slot_GetNSSToken(slot);
if (!object) { if (!token) {
return SECFailure; return SECFailure;
} }
object->token = nssToken_AddRef(token); object = nss_ZNEW(NULL, nssCryptokiObject);
if (!object) {
(void)nssToken_Destroy(token);
return SECFailure;
}
object->token = token; /* object takes ownership */
object->handle = crl->pkcs11ID; object->handle = crl->pkcs11ID;
object->isTokenObject = PR_TRUE; object->isTokenObject = PR_TRUE;

73
security/nss/lib/pk11wrap/pk11slot.c
View file

@ -359,19 +359,24 @@ PK11_NewSlotInfo(SECMODModule *mod)
PK11SlotInfo *slot; PK11SlotInfo *slot;
slot = (PK11SlotInfo *)PORT_Alloc(sizeof(PK11SlotInfo)); slot = (PK11SlotInfo *)PORT_Alloc(sizeof(PK11SlotInfo));
if (slot == NULL) if (slot == NULL) {
return slot; return slot;
slot->sessionLock = mod->isThreadSafe ? PZ_NewLock(nssILockSession) : mod->refLock;
if (slot->sessionLock == NULL) {
PORT_Free(slot);
return NULL;
} }
slot->freeListLock = PZ_NewLock(nssILockFreelist); slot->freeListLock = PZ_NewLock(nssILockFreelist);
if (slot->freeListLock == NULL) { if (slot->freeListLock == NULL) {
if (mod->isThreadSafe) { PORT_Free(slot);
PZ_DestroyLock(slot->sessionLock); return NULL;
} }
slot->nssTokenLock = PZ_NewLock(nssILockOther);
if (slot->nssTokenLock == NULL) {
PZ_DestroyLock(slot->freeListLock);
PORT_Free(slot);
return NULL;
}
slot->sessionLock = mod->isThreadSafe ? PZ_NewLock(nssILockSession) : mod->refLock;
if (slot->sessionLock == NULL) {
PZ_DestroyLock(slot->nssTokenLock);
PZ_DestroyLock(slot->freeListLock);
PORT_Free(slot); PORT_Free(slot);
return NULL; return NULL;
} }
@ -459,6 +464,10 @@ PK11_DestroySlot(PK11SlotInfo *slot)
PZ_DestroyLock(slot->freeListLock); PZ_DestroyLock(slot->freeListLock);
slot->freeListLock = NULL; slot->freeListLock = NULL;
} }
if (slot->nssTokenLock) {
PZ_DestroyLock(slot->nssTokenLock);
slot->nssTokenLock = NULL;
}
/* finally Tell our parent module that we've gone away so it can unload */ /* finally Tell our parent module that we've gone away so it can unload */
if (slot->module) { if (slot->module) {
@ -1257,6 +1266,7 @@ PK11_InitToken(PK11SlotInfo *slot, PRBool loadCerts)
CK_RV crv; CK_RV crv;
SECStatus rv; SECStatus rv;
PRStatus status; PRStatus status;
NSSToken *nssToken;
/* set the slot flags to the current token values */ /* set the slot flags to the current token values */
if (!slot->isThreadSafe) if (!slot->isThreadSafe)
@ -1294,7 +1304,9 @@ PK11_InitToken(PK11SlotInfo *slot, PRBool loadCerts)
slot->maxPassword = slot->tokenInfo.ulMaxPinLen; slot->maxPassword = slot->tokenInfo.ulMaxPinLen;
PORT_Memcpy(slot->serial, slot->tokenInfo.serialNumber, sizeof(slot->serial)); PORT_Memcpy(slot->serial, slot->tokenInfo.serialNumber, sizeof(slot->serial));
nssToken_UpdateName(slot->nssToken); nssToken = PK11Slot_GetNSSToken(slot);
nssToken_UpdateName(nssToken); /* null token is OK */
(void)nssToken_Destroy(nssToken);
slot->defRWSession = (PRBool)((!slot->readOnly) && slot->defRWSession = (PRBool)((!slot->readOnly) &&
(slot->tokenInfo.ulMaxSessionCount == 1)); (slot->tokenInfo.ulMaxSessionCount == 1));
@ -1362,7 +1374,9 @@ PK11_InitToken(PK11SlotInfo *slot, PRBool loadCerts)
PK11_ExitSlotMonitor(slot); PK11_ExitSlotMonitor(slot);
} }
status = nssToken_Refresh(slot->nssToken); nssToken = PK11Slot_GetNSSToken(slot);
status = nssToken_Refresh(nssToken); /* null token is OK */
(void)nssToken_Destroy(nssToken);
if (status != PR_SUCCESS) if (status != PR_SUCCESS)
return SECFailure; return SECFailure;
@ -1596,8 +1610,11 @@ pk11_IsPresentCertLoad(PK11SlotInfo *slot, PRBool loadCerts)
return PR_TRUE; return PR_TRUE;
} }
if (slot->nssToken) { NSSToken *nssToken = PK11Slot_GetNSSToken(slot);
return nssToken_IsPresent(slot->nssToken); if (nssToken) {
PRBool present = nssToken_IsPresent(nssToken);
(void)nssToken_Destroy(nssToken);
return present;
} }
/* removable slots have a flag that says they are present */ /* removable slots have a flag that says they are present */
@ -2634,20 +2651,44 @@ PK11_ResetToken(PK11SlotInfo *slot, char *sso_pwd)
PORT_SetError(PK11_MapError(crv)); PORT_SetError(PK11_MapError(crv));
return SECFailure; return SECFailure;
} }
nssTrustDomain_UpdateCachedTokenCerts(slot->nssToken->trustDomain, NSSToken *token = PK11Slot_GetNSSToken(slot);
slot->nssToken); if (token) {
nssTrustDomain_UpdateCachedTokenCerts(token->trustDomain, token);
(void)nssToken_Destroy(token);
}
return SECSuccess; return SECSuccess;
} }
void void
PK11Slot_SetNSSToken(PK11SlotInfo *sl, NSSToken *nsst) PK11Slot_SetNSSToken(PK11SlotInfo *sl, NSSToken *nsst)
{ {
NSSToken *old;
if (nsst) {
nsst = nssToken_AddRef(nsst);
}
PZ_Lock(sl->nssTokenLock);
old = sl->nssToken;
sl->nssToken = nsst; sl->nssToken = nsst;
PZ_Unlock(sl->nssTokenLock);
if (old) {
(void)nssToken_Destroy(old);
}
} }
NSSToken * NSSToken *
PK11Slot_GetNSSToken(PK11SlotInfo *sl) PK11Slot_GetNSSToken(PK11SlotInfo *sl)
{ {
return sl->nssToken; NSSToken *rv = NULL;
PZ_Lock(sl->nssTokenLock);
if (sl->nssToken) {
rv = nssToken_AddRef(sl->nssToken);
}
PZ_Unlock(sl->nssTokenLock);
return rv;
} }
/* /*

27
security/nss/lib/pk11wrap/pk11util.c
View file

@ -13,6 +13,7 @@
#include "pki3hack.h" #include "pki3hack.h"
#include "secerr.h" #include "secerr.h"
#include "dev.h" #include "dev.h"
#include "dev3hack.h"
#include "utilpars.h" #include "utilpars.h"
#include "pkcs11uri.h" #include "pkcs11uri.h"
@ -1266,8 +1267,14 @@ SECMOD_WaitForAnyTokenEvent(SECMODModule *mod, unsigned long flags,
} }
/* if we are in the delay period for the "isPresent" call, reset /* if we are in the delay period for the "isPresent" call, reset
* the delay since we know things have probably changed... */ * the delay since we know things have probably changed... */
if (slot && slot->nssToken && slot->nssToken->slot) { if (slot) {
nssSlot_ResetDelay(slot->nssToken->slot); NSSToken *nssToken = PK11Slot_GetNSSToken(slot);
if (nssToken) {
if (nssToken->slot) {
nssSlot_ResetDelay(nssToken->slot);
}
(void)nssToken_Destroy(nssToken);
}
} }
return slot; return slot;
@ -1500,8 +1507,12 @@ SECMOD_OpenNewSlot(SECMODModule *mod, const char *moduleSpec)
if (slot) { if (slot) {
/* if we are in the delay period for the "isPresent" call, reset /* if we are in the delay period for the "isPresent" call, reset
* the delay since we know things have probably changed... */ * the delay since we know things have probably changed... */
if (slot->nssToken && slot->nssToken->slot) { NSSToken *nssToken = PK11Slot_GetNSSToken(slot);
nssSlot_ResetDelay(slot->nssToken->slot); if (nssToken) {
if (nssToken->slot) {
nssSlot_ResetDelay(nssToken->slot);
}
(void)nssToken_Destroy(nssToken);
} }
/* force the slot info structures to properly reset */ /* force the slot info structures to properly reset */
(void)PK11_IsPresent(slot); (void)PK11_IsPresent(slot);
@ -1631,8 +1642,12 @@ SECMOD_CloseUserDB(PK11SlotInfo *slot)
PR_smprintf_free(sendSpec); PR_smprintf_free(sendSpec);
/* if we are in the delay period for the "isPresent" call, reset /* if we are in the delay period for the "isPresent" call, reset
* the delay since we know things have probably changed... */ * the delay since we know things have probably changed... */
if (slot->nssToken && slot->nssToken->slot) { NSSToken *nssToken = PK11Slot_GetNSSToken(slot);
nssSlot_ResetDelay(slot->nssToken->slot); if (nssToken) {
if (nssToken->slot) {
nssSlot_ResetDelay(nssToken->slot);
}
(void)nssToken_Destroy(nssToken);
/* force the slot info structures to properly reset */ /* force the slot info structures to properly reset */
(void)PK11_IsPresent(slot); (void)PK11_IsPresent(slot);
} }

1
security/nss/lib/pk11wrap/secmodti.h
View file

@ -107,6 +107,7 @@ struct PK11SlotInfoStr {
unsigned int lastState; unsigned int lastState;
/* for Stan */ /* for Stan */
NSSToken *nssToken; NSSToken *nssToken;
PZLock *nssTokenLock;
/* the tokeninfo struct */ /* the tokeninfo struct */
CK_TOKEN_INFO tokenInfo; CK_TOKEN_INFO tokenInfo;
/* fast mechanism lookup */ /* fast mechanism lookup */

23
security/nss/lib/pki/pki3hack.c
View file

@ -72,12 +72,16 @@ STAN_InitTokenForSlotInfo(NSSTrustDomain *td, PK11SlotInfo *slot)
} }
} }
token = nssToken_CreateFromPK11SlotInfo(td, slot); token = nssToken_CreateFromPK11SlotInfo(td, slot);
PK11Slot_SetNSSToken(slot, token);
/* Don't add nonexistent token to TD's token list */
if (token) { if (token) {
/* PK11Slot_SetNSSToken increments the refcount on |token| to 2 */
PK11Slot_SetNSSToken(slot, token);
/* we give our reference to |td->tokenList| */
NSSRWLock_LockWrite(td->tokensLock); NSSRWLock_LockWrite(td->tokensLock);
nssList_Add(td->tokenList, token); nssList_Add(td->tokenList, token);
NSSRWLock_UnlockWrite(td->tokensLock); NSSRWLock_UnlockWrite(td->tokensLock);
} else {
PK11Slot_SetNSSToken(slot, NULL);
} }
return PR_SUCCESS; return PR_SUCCESS;
} }
@ -188,7 +192,8 @@ STAN_RemoveModuleFromDefaultTrustDomain(
nssList_Remove(td->tokenList, token); nssList_Remove(td->tokenList, token);
NSSRWLock_UnlockWrite(td->tokensLock); NSSRWLock_UnlockWrite(td->tokensLock);
PK11Slot_SetNSSToken(module->slots[i], NULL); PK11Slot_SetNSSToken(module->slots[i], NULL);
nssToken_Destroy(token); (void)nssToken_Destroy(token); /* for the |td->tokenList| reference */
(void)nssToken_Destroy(token); /* for our PK11Slot_GetNSSToken reference */
} }
} }
NSSRWLock_LockWrite(td->tokensLock); NSSRWLock_LockWrite(td->tokensLock);
@ -1076,7 +1081,11 @@ STAN_GetNSSCertificate(CERTCertificate *cc)
nssArena_Destroy(arena); nssArena_Destroy(arena);
return NULL; return NULL;
} }
instance->token = nssToken_AddRef(PK11Slot_GetNSSToken(cc->slot)); instance->token = PK11Slot_GetNSSToken(cc->slot);
if (!instance->token) {
nssArena_Destroy(arena);
return NULL;
}
instance->handle = cc->pkcs11ID; instance->handle = cc->pkcs11ID;
instance->isTokenObject = PR_TRUE; instance->isTokenObject = PR_TRUE;
if (cc->nickname) { if (cc->nickname) {
@ -1269,6 +1278,10 @@ STAN_ChangeCertTrust(CERTCertificate *cc, CERTCertTrust *trust)
NSSASCII7 *email = c->email; NSSASCII7 *email = c->email;
tok = PK11Slot_GetNSSToken(slot); tok = PK11Slot_GetNSSToken(slot);
PK11_FreeSlot(slot); PK11_FreeSlot(slot);
if (!tok) {
nssrv = PR_FAILURE;
goto done;
}
newInstance = nssToken_ImportCertificate(tok, NULL, newInstance = nssToken_ImportCertificate(tok, NULL,
NSSCertificateType_PKIX, NSSCertificateType_PKIX,
@ -1283,6 +1296,7 @@ STAN_ChangeCertTrust(CERTCertificate *cc, CERTCertTrust *trust)
nss_ZFreeIf(nickname); nss_ZFreeIf(nickname);
nickname = NULL; nickname = NULL;
if (!newInstance) { if (!newInstance) {
(void)nssToken_Destroy(tok);
nssrv = PR_FAILURE; nssrv = PR_FAILURE;
goto done; goto done;
} }
@ -1294,6 +1308,7 @@ STAN_ChangeCertTrust(CERTCertificate *cc, CERTCertTrust *trust)
nssTrust->codeSigning, nssTrust->codeSigning,
nssTrust->emailProtection, nssTrust->emailProtection,
nssTrust->stepUpApproved, PR_TRUE); nssTrust->stepUpApproved, PR_TRUE);
(void)nssToken_Destroy(tok);
} }
if (newInstance) { if (newInstance) {
nssCryptokiObject_Destroy(newInstance); nssCryptokiObject_Destroy(newInstance);

28
security/nss/lib/pki/trustdomain.c
View file

@ -11,6 +11,7 @@
#endif /* PKIM_H */ #endif /* PKIM_H */
#include "cert.h" #include "cert.h"
#include "dev3hack.h"
#include "pki3hack.h" #include "pki3hack.h"
#include "pk11pub.h" #include "pk11pub.h"
#include "nssrwlk.h" #include "nssrwlk.h"
@ -61,11 +62,14 @@ static void
token_destructor(void *t) token_destructor(void *t)
{ {
NSSToken *tok = (NSSToken *)t; NSSToken *tok = (NSSToken *)t;
/* The token holds the first/last reference to the slot. /* Remove the token list's reference to the token */
* When the token is actually destroyed (ref count == 0), (void)nssToken_Destroy(tok);
* the slot will also be destroyed.
*/ /* Signal that the slot should not give out any more references to the
nssToken_Destroy(tok); * token. The token might still have a positive refcount after this call.
* The token has a reference to the slot, so the slot will not be destroyed
* until after the token's refcount drops to 0. */
PK11Slot_SetNSSToken(tok->pk11slot, NULL);
} }
NSS_IMPLEMENT PRStatus NSS_IMPLEMENT PRStatus
@ -127,7 +131,6 @@ nssTrustDomain_GetActiveSlots(
return NULL; return NULL;
} }
nssList_GetArray(td->tokenList, (void **)tokens, count); nssList_GetArray(td->tokenList, (void **)tokens, count);
NSSRWLock_UnlockRead(td->tokensLock);
count = 0; count = 0;
for (tp = tokens; *tp; tp++) { for (tp = tokens; *tp; tp++) {
NSSSlot *slot = nssToken_GetSlot(*tp); NSSSlot *slot = nssToken_GetSlot(*tp);
@ -137,6 +140,7 @@ nssTrustDomain_GetActiveSlots(
nssSlot_Destroy(slot); nssSlot_Destroy(slot);
} }
} }
NSSRWLock_UnlockRead(td->tokensLock);
nss_ZFreeIf(tokens); nss_ZFreeIf(tokens);
if (!count) { if (!count) {
nss_ZFreeIf(slots); nss_ZFreeIf(slots);
@ -469,7 +473,7 @@ nssTrustDomain_FindCertificatesByNickname(
numRemaining, numRemaining,
&status); &status);
} }
nssToken_Destroy(token); (void)nssToken_Destroy(token);
if (status != PR_SUCCESS) { if (status != PR_SUCCESS) {
errors++; errors++;
continue; continue;
@ -618,7 +622,7 @@ nssTrustDomain_FindCertificatesBySubject(
numRemaining, numRemaining,
&status); &status);
} }
nssToken_Destroy(token); (void)nssToken_Destroy(token);
if (status != PR_SUCCESS) { if (status != PR_SUCCESS) {
errors++; errors++;
continue; continue;
@ -779,7 +783,7 @@ nssTrustDomain_FindCertificateByIssuerAndSerialNumber(
tokenOnly, tokenOnly,
&status); &status);
} }
nssToken_Destroy(token); (void)nssToken_Destroy(token);
if (status != PR_SUCCESS) { if (status != PR_SUCCESS) {
continue; continue;
} }
@ -1022,7 +1026,7 @@ NSSTrustDomain_TraverseCertificates(
collector, collector,
collection); collection);
} }
nssToken_Destroy(token); (void)nssToken_Destroy(token);
} }
} }
@ -1076,7 +1080,7 @@ nssTrustDomain_FindTrustForCertificate(
nssCryptokiObject_Destroy(to); nssCryptokiObject_Destroy(to);
} }
} }
nssToken_Destroy(token); (void)nssToken_Destroy(token);
} }
} }
if (pkio) { if (pkio) {
@ -1126,7 +1130,7 @@ nssTrustDomain_FindCRLsBySubject(
instances = nssToken_FindCRLsBySubject(token, session, subject, instances = nssToken_FindCRLsBySubject(token, session, subject,
tokenOnly, 0, &status); tokenOnly, 0, &status);
} }
nssToken_Destroy(token); (void)nssToken_Destroy(token);
if (status == PR_SUCCESS) { if (status == PR_SUCCESS) {
/* add the found CRL's to the collection */ /* add the found CRL's to the collection */
status = nssPKIObjectCollection_AddInstances(collection, status = nssPKIObjectCollection_AddInstances(collection,

17
security/nss/lib/ssl/ssl3ext.c
View file

@ -528,12 +528,23 @@ ssl3_HandleParsedExtensions(sslSocket *ss, SSLHandshakeType message)
if (allowNotOffered) { if (allowNotOffered) {
continue; /* Skip over unknown extensions. */ continue; /* Skip over unknown extensions. */
} }
/* Fall through. */ /* RFC8446 Section 4.2 - Implementations MUST NOT send extension responses if
* the remote endpoint did not send the corresponding extension request ...
* Upon receiving such an extension, an endpoint MUST abort the handshake with
* an "unsupported_extension" alert. */
SSL_TRC(3, ("%d: TLS13: unknown extension %d in message %d",
SSL_GETPID(), extension, message));
tls13_FatalError(ss, SSL_ERROR_RX_UNEXPECTED_EXTENSION,
unsupported_extension);
return SECFailure;
case tls13_extension_disallowed: case tls13_extension_disallowed:
SSL_TRC(3, ("%d: TLS13: unexpected extension %d in message %d", /* RFC8446 Section 4.2 - If an implementation receives an extension which it
* recognizes and which is not specified for the message in which it appears,
* it MUST abort the handshake with an "illegal_parameter" alert. */
SSL_TRC(3, ("%d: TLS13: disallowed extension %d in message %d",
SSL_GETPID(), extension, message)); SSL_GETPID(), extension, message));
tls13_FatalError(ss, SSL_ERROR_EXTENSION_DISALLOWED_FOR_VERSION, tls13_FatalError(ss, SSL_ERROR_EXTENSION_DISALLOWED_FOR_VERSION,
unsupported_extension); illegal_parameter);
return SECFailure; return SECFailure;
} }
} }