From bebaa470c620c0764d8e28a2029ba3d1b6429e27 Mon Sep 17 00:00:00 2001 From: roytam1 Date: Wed, 27 Apr 2022 16:24:56 +0800 Subject: [PATCH] Revert "Issue #21 - Change MappedAttrParser to store its nsIPrincipal instead of nsSVGElement" This reverts commit e5962d9f4c71ff0b2bbf8df7eb2ca4b2cbbc1f3f. --- dom/svg/nsSVGElement.cpp | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/dom/svg/nsSVGElement.cpp b/dom/svg/nsSVGElement.cpp index 63209d15d4..0b726623a0 100644 --- a/dom/svg/nsSVGElement.cpp +++ b/dom/svg/nsSVGElement.cpp @@ -1150,7 +1150,7 @@ public: MappedAttrParser(css::Loader* aLoader, nsIURI* aDocURI, already_AddRefed aBaseURI, - nsIPrincipal* aNodePrincipal); + nsSVGElement* aElement); ~MappedAttrParser(); // Parses a mapped attribute value. @@ -1170,18 +1170,20 @@ private: // Arguments for nsCSSParser::ParseProperty nsIURI* mDocURI; nsCOMPtr mBaseURI; - nsIPrincipal* mNodePrincipal; // Declaration for storing parsed values (lazily initialized) css::Declaration* mDecl; + + // For reporting use counters + nsSVGElement* mElement; }; MappedAttrParser::MappedAttrParser(css::Loader* aLoader, nsIURI* aDocURI, already_AddRefed aBaseURI, - nsIPrincipal* aNodePrincipal) + nsSVGElement* aElement) : mParser(aLoader), mDocURI(aDocURI), mBaseURI(aBaseURI), - mNodePrincipal(aNodePrincipal), mDecl(nullptr) + mDecl(nullptr), mElement(aElement) { } @@ -1208,7 +1210,7 @@ MappedAttrParser::ParseMappedAttrValue(nsIAtom* aMappedAttrName, if (propertyID != eCSSProperty_UNKNOWN) { bool changed; // outparam for ParseProperty. (ignored) mParser.ParseProperty(propertyID, aMappedAttrValue, mDocURI, mBaseURI, - mNodePrincipal, mDecl, &changed, false, true); + mElement->NodePrincipal(), mDecl, &changed, false, true); return; } MOZ_ASSERT(aMappedAttrName == nsGkAtoms::lang, @@ -1255,7 +1257,7 @@ nsSVGElement::UpdateContentStyleRule() nsIDocument* doc = OwnerDoc(); MappedAttrParser mappedAttrParser(doc->CSSLoader(), doc->GetDocumentURI(), - GetBaseURI(), NodePrincipal()); + GetBaseURI(), this); for (uint32_t i = 0; i < attrCount; ++i) { const nsAttrName* attrName = mAttrsAndChildren.AttrNameAt(i); @@ -1346,7 +1348,7 @@ nsSVGElement::UpdateAnimatedContentStyleRule() } MappedAttrParser mappedAttrParser(doc->CSSLoader(), doc->GetDocumentURI(), - GetBaseURI(), NodePrincipal()); + GetBaseURI(), this); doc->PropertyTable(SMIL_MAPPED_ATTR_ANIMVAL)-> Enumerate(this, ParseMappedAttrAnimValueCallback, &mappedAttrParser);