Bug 1341339 - Check for duplicates in processIterators

Issue #74

js/src/jit-test/tests/for-of/bug-1341339.js

@@ -0,0 +1,9 @@
+let m = parseModule(`
+function* values() {}
+var iterator = values();
+for (var i=0; i < 10000; ++i) {
+    for (var x of iterator) {}
+}
+`);
+m.declarationInstantiation();
+m.evaluation();

js/src/jit/IonBuilder.cpp

@@ -963,9 +963,12 @@ IonBuilder::processIterators()
     Vector<MDefinition*, 8, SystemAllocPolicy> worklist;
 
     for (size_t i = 0; i < iterators_.length(); i++) {
-        if (!worklist.append(iterators_[i]))
+        MDefinition* iter = iterators_[i];
-            return false;
+        if (!iter->isInWorklist()) {
-        iterators_[i]->setInWorklist();
+            if (!worklist.append(iter))
+                return false;
+            iter->setInWorklist();
+        }
     }
 
     while (!worklist.empty()) {