From b70a9b1d12e8b737a498883aa5436d512d97a88b Mon Sep 17 00:00:00 2001 From: Gaming4JC Date: Mon, 20 Jan 2020 18:13:15 -0500 Subject: [PATCH] Bug 1405335 - Remove custom element attached and detached callbacks validation checks Tag UXP Issue #1344 --- dom/base/CustomElementRegistry.cpp | 4 +--- .../test_custom_element_register_invalid_callbacks.html | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/dom/base/CustomElementRegistry.cpp b/dom/base/CustomElementRegistry.cpp index 59e107b14b..830f06fedf 100644 --- a/dom/base/CustomElementRegistry.cpp +++ b/dom/base/CustomElementRegistry.cpp @@ -523,9 +523,7 @@ static const char* kLifeCycleCallbackNames[] = { "adoptedCallback", "attributeChangedCallback", // The life cycle callbacks from v0 spec. - "createdCallback", - "attachedCallback", - "detachedCallback" + "createdCallback" }; static void diff --git a/dom/tests/mochitest/webcomponents/test_custom_element_register_invalid_callbacks.html b/dom/tests/mochitest/webcomponents/test_custom_element_register_invalid_callbacks.html index a349f4aa50..d1b1b1e04c 100644 --- a/dom/tests/mochitest/webcomponents/test_custom_element_register_invalid_callbacks.html +++ b/dom/tests/mochitest/webcomponents/test_custom_element_register_invalid_callbacks.html @@ -20,8 +20,6 @@ const testWindow = iframe.contentDocument.defaultView; // We should do the same checks for the callbacks from v0 spec. [ 'createdCallback', - 'attachedCallback', - 'detachedCallback', 'attributeChangedCallback', ].forEach(callback => { var c = class {};