wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-06 07:48:38 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1333946 - Make IonBuilder::processIterators transitive

Browse source 
Issue #74
This commit is contained in:
janekptacijarabaci 2018-03-25 13:34:31 +02:00 • committed by Roy Tam
commit b2e86b0087
2 changed files with 27 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

6
js/src/jit-test/tests/ion/bug1333946.js Normal file
View file

@ -0,0 +1,6 @@
// |jit-test| exitstatus: 6;
for (var x of [0]) {
timeout(0.001);
for (;;) {}
}

43
js/src/jit/IonBuilder.cpp
View file

@ -958,35 +958,32 @@ IonBuilder::build()
bool
IonBuilder::processIterators()
{
// Find phis that must directly hold an iterator live.
Vector<MPhi*, 0, SystemAllocPolicy> worklist;
// Find and mark phis that must transitively hold an iterator live.
Vector<MDefinition*, 8, SystemAllocPolicy> worklist;
for (size_t i = 0; i < iterators_.length(); i++) {
MDefinition* def = iterators_[i];
if (def->isPhi()) {
if (!worklist.append(def->toPhi()))
return false;
} else {
for (MUseDefIterator iter(def); iter; iter++) {
if (iter.def()->isPhi()) {
if (!worklist.append(iter.def()->toPhi()))
return false;
}
}
}
if (!worklist.append(iterators_[i]))
return false;
iterators_[i]->setInWorklist();
}
// Propagate the iterator and live status of phis to all other connected
// phis.
while (!worklist.empty()) {
MPhi* phi = worklist.popCopy();
phi->setIterator();
phi->setImplicitlyUsedUnchecked();
MDefinition* def = worklist.popCopy();
def->setNotInWorklist();
for (MUseDefIterator iter(phi); iter; iter++) {
if (iter.def()->isPhi()) {
MPhi* other = iter.def()->toPhi();
if (!other->isIterator() && !worklist.append(other))
if (def->isPhi()) {
MPhi* phi = def->toPhi();
phi->setIterator();
phi->setImplicitlyUsedUnchecked();
}
for (MUseDefIterator iter(def); iter; iter++) {
MDefinition* use = iter.def();
if (!use->isInWorklist() && (!use->isPhi() || !use->toPhi()->isIterator())) {
if (!worklist.append(use))
return false;
use->setInWorklist();
}
}
}