From b2c7373dbae6f7cfb4b5c8db0f4511251bc2a3c0 Mon Sep 17 00:00:00 2001 From: janekptacijarabaci Date: Fri, 20 Jul 2018 09:15:48 +0200 Subject: [PATCH] Bug 958714 Remove obsolete assertion & comment + Used "mFrame->GetType()" instead of "mFrame->Type()" --- layout/generic/ReflowInput.cpp | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/layout/generic/ReflowInput.cpp b/layout/generic/ReflowInput.cpp index 04f4ef3e59..bbff77ad47 100644 --- a/layout/generic/ReflowInput.cpp +++ b/layout/generic/ReflowInput.cpp @@ -154,11 +154,6 @@ FontSizeInflationListMarginAdjustment(const nsIFrame* aFrame) return 0; } -// NOTE: If we ever want to use SizeComputationInput for a flex item or a -// grid item, we need to make it take the containing-block block-size as -// well as the inline-size, since flex items and grid items resolve -// block-direction percent margins and padding against the -// containing-block block-size, rather than its inline-size. SizeComputationInput::SizeComputationInput(nsIFrame *aFrame, nsRenderingContext *aRenderingContext, WritingMode aContainingBlockWritingMode, @@ -167,15 +162,9 @@ SizeComputationInput::SizeComputationInput(nsIFrame *aFrame, , mRenderingContext(aRenderingContext) , mWritingMode(aFrame->GetWritingMode()) { - MOZ_ASSERT(!aFrame->IsFlexOrGridItem(), - "We're about to resolve percent margin & padding " - "values against CB inline size, which is incorrect for " - "flex/grid items. " - "Additionally for grid items, this path doesn't handle baseline " - "padding contribution - see SizeComputationInput::InitOffsets"); ReflowInputFlags flags; InitOffsets(aContainingBlockWritingMode, aContainingBlockISize, - mFrame->Type(), flags); + mFrame->GetType(), flags); } // Initialize a reflow state for a child frame's reflow. Some state