Prevent suppressing executable warnings using the "don't ask me this again" checkbox.

A hidden preference matching the behavior of "browser.download.manager.alertOnEXEOpen" is kept, but is renamed in order to recover cases where the checkbox was used accidentally.
While there, simplify the `confirmLaunchExecutable` function by converting from promises to async function.
Since Basilisk moved this prompting to toolkit, we also clean up some unused duplicate strings from application/basilisk while we're there.

This resolves #581
This commit is contained in:
wolfbeast 2018-07-02 19:05:56 +02:00 committed by Roy Tam
commit ad2c18b0f2
6 changed files with 25 additions and 53 deletions

View file

@ -86,8 +86,7 @@ const kDownloadsStringsRequiringFormatting = {
shortTimeLeftHours: true,
shortTimeLeftDays: true,
statusSeparator: true,
statusSeparatorBeforeNumber: true,
fileExecutableSecurityWarning: true
statusSeparatorBeforeNumber: true
};
const kDownloadsStringsRequiringPluralForm = {