Issue #2073 - m-c 1546500: Avoid dispatching synchronous thread shutdown runnables

This commit is contained in:
Martok 2023-01-01 13:46:00 +01:00 committed by roytam1
commit a6a420259c
4 changed files with 4 additions and 4 deletions

View file

@ -1770,7 +1770,7 @@ Manager::~Manager()
// Don't spin the event loop in the destructor waiting for the thread to
// shutdown. Defer this to the main thread, instead.
MOZ_ALWAYS_SUCCEEDS(NS_DispatchToMainThread(NewRunnableMethod(ioThread, &nsIThread::Shutdown)));
MOZ_ALWAYS_SUCCEEDS(NS_DispatchToMainThread(NewRunnableMethod(ioThread, &nsIThread::AsyncShutdown)));
}
void

View file

@ -12487,7 +12487,7 @@ ConnectionPool::ShutdownThread(ThreadInfo& aThreadInfo)
NS_DISPATCH_NORMAL));
MOZ_ALWAYS_SUCCEEDS(NS_DispatchToMainThread(
NewRunnableMethod(thread, &nsIThread::Shutdown)));
NewRunnableMethod(thread, &nsIThread::AsyncShutdown)));
mTotalThreadCount--;
}

View file

@ -72,7 +72,7 @@ public:
{
// Threads have to be shut down from another thread, so we'll ask the
// main thread to do it for us.
NS_DispatchToMainThread(NewRunnableMethod(aThisThread, &nsIThread::Shutdown));
NS_DispatchToMainThread(NewRunnableMethod(aThisThread, &nsIThread::AsyncShutdown));
}
/**

View file

@ -238,7 +238,7 @@ DataChannelConnection::~DataChannelConnection()
// Avoid spinning the event thread from here (which if we're mainthread
// is in the event loop already)
NS_DispatchToMainThread(WrapRunnable(nsCOMPtr<nsIThread>(mInternalIOThread),
&nsIThread::Shutdown),
&nsIThread::AsyncShutdown),
NS_DISPATCH_NORMAL);
}
} else {