Remove proprietary constructor on AudioContext.

This is a B2G leftover, was proprietary, and is causing issues
because `AudioContext` can now have a parameter that is a property bag,
per spec (we do not do anything with the property bag now; the audio
back-end will use automatic values for everything).

This resolves #924.
This commit is contained in:
wolfbeast 2019-01-04 16:18:03 +01:00 • committed by Roy Tam
commit a0d362b6e3
5 changed files with 1 additions and 33 deletions

View file

@ -1,13 +0,0 @@
<!DOCTYPE html>
<html>
<head>
<script>
var htmlAudio = new Audio(URL.createObjectURL(new window.MediaSource()));
(new window.AudioContext("ringer")).createMediaElementSource(htmlAudio);
(new window.AudioContext("alarm")).createMediaElementSource(htmlAudio);
</script>
</head>
</html>

View file

@ -81,8 +81,6 @@ load 1157994.html
load 1158427.html load 1158427.html
load 1185176.html load 1185176.html
load 1185192.html load 1185192.html
load 1223670.html
load 1228484.html
load 1304948.html load 1304948.html
load 1319486.html load 1319486.html
load 1291702.html load 1291702.html

View file

@ -178,16 +178,6 @@ AudioContext::WrapObject(JSContext* aCx, JS::Handle<JSObject*> aGivenProto)
/* static */ already_AddRefed<AudioContext> /* static */ already_AddRefed<AudioContext>
AudioContext::Constructor(const GlobalObject& aGlobal, AudioContext::Constructor(const GlobalObject& aGlobal,
ErrorResult& aRv) ErrorResult& aRv)
{
return AudioContext::Constructor(aGlobal,
AudioChannelService::GetDefaultAudioChannel(),
aRv);
}
/* static */ already_AddRefed<AudioContext>
AudioContext::Constructor(const GlobalObject& aGlobal,
AudioChannel aChannel,
ErrorResult& aRv)
{ {
nsCOMPtr<nsPIDOMWindowInner> window = do_QueryInterface(aGlobal.GetAsSupports()); nsCOMPtr<nsPIDOMWindowInner> window = do_QueryInterface(aGlobal.GetAsSupports());
if (!window) { if (!window) {
@ -195,7 +185,7 @@ AudioContext::Constructor(const GlobalObject& aGlobal,
return nullptr; return nullptr;
} }
RefPtr<AudioContext> object = new AudioContext(window, false, aChannel); RefPtr<AudioContext> object = new AudioContext(window, false, AudioChannelService::GetDefaultAudioChannel());
aRv = object->Init(); aRv = object->Init();
if (NS_WARN_IF(aRv.Failed())) { if (NS_WARN_IF(aRv.Failed())) {
return nullptr; return nullptr;

View file

@ -151,12 +151,6 @@ public:
static already_AddRefed<AudioContext> static already_AddRefed<AudioContext>
Constructor(const GlobalObject& aGlobal, ErrorResult& aRv); Constructor(const GlobalObject& aGlobal, ErrorResult& aRv);
// Constructor for regular AudioContext. A default audio channel is needed.
static already_AddRefed<AudioContext>
Constructor(const GlobalObject& aGlobal,
AudioChannel aChannel,
ErrorResult& aRv);
// Constructor for offline AudioContext // Constructor for offline AudioContext
static already_AddRefed<AudioContext> static already_AddRefed<AudioContext>
Constructor(const GlobalObject& aGlobal, Constructor(const GlobalObject& aGlobal,

View file

@ -24,7 +24,6 @@ dictionary PeriodicWaveConstraints {
}; };
[Constructor, [Constructor,
Constructor(AudioChannel audioChannelType),
Pref="dom.webaudio.enabled"] Pref="dom.webaudio.enabled"]
interface AudioContext : EventTarget { interface AudioContext : EventTarget {