wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-25 00:27:29 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #2340 - Return an array (actually frozen sequence) for {border|content}BoxSize

Browse source 
Resolves #2340
This commit is contained in:
Moonchild 2023-10-14 14:16:26 +02:00 • committed by roytam1
commit 9cd7fd3bf4
3 changed files with 33 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

24
dom/base/ResizeObserver.cpp
View file

@ -303,6 +303,30 @@ ResizeObserverEntry::Constructor(const GlobalObject& aGlobal,
return observerEntry.forget(); return observerEntry.forget();
} }
void ResizeObserverEntry::GetBorderBoxSize(
nsTArray<RefPtr<ResizeObserverSize>>& aRetVal) const {
// In the resize-observer-1 spec, there will only be a single
// ResizeObserverSize returned in the FrozenArray.
//
// Note: the usage of FrozenArray is to support elements that have multiple
// fragments, which occur in multi-column scenarios. See:
// https://drafts.csswg.org/resize-observer/#resize-observer-entry-interface
aRetVal.Clear();
aRetVal.AppendElement(mBorderBoxSize);
}
void ResizeObserverEntry::GetContentBoxSize(
nsTArray<RefPtr<ResizeObserverSize>>& aRetVal) const {
// In the resize-observer-1 spec, there will only be a single
// ResizeObserverSize returned in the FrozenArray.
//
// Note: the usage of FrozenArray is to support elements that have multiple
// fragments, which occur in multi-column scenarios.
// https://drafts.csswg.org/resize-observer/#resize-observer-entry-interface
aRetVal.Clear();
aRetVal.AppendElement(mContentBoxSize);
}
void void
ResizeObserverEntry::SetBorderBoxSize(const nsSize& aSize) { ResizeObserverEntry::SetBorderBoxSize(const nsSize& aSize) {
nsIFrame* frame = mTarget->GetPrimaryFrame(); nsIFrame* frame = mTarget->GetPrimaryFrame();

10
dom/base/ResizeObserver.h
View file

@ -163,14 +163,10 @@ public:
/** /**
* Returns target's logical border-box size and content-box size as * Returns target's logical border-box size and content-box size as
* ResizeObserverSize. * a ResizeObserverSize array.
*/ */
ResizeObserverSize* BorderBoxSize() const { void GetBorderBoxSize(nsTArray<RefPtr<ResizeObserverSize>>& aRetVal) const;
return mBorderBoxSize; void GetContentBoxSize(nsTArray<RefPtr<ResizeObserverSize>>& aRetVal) const;
}
ResizeObserverSize* ContentBoxSize() const {
return mContentBoxSize;
}
// Set borderBoxSize. // Set borderBoxSize.
void SetBorderBoxSize(const nsSize& aSize); void SetBorderBoxSize(const nsSize& aSize);

8
dom/webidl/ResizeObserver.webidl
View file

@ -34,8 +34,12 @@ callback ResizeObserverCallback = void (sequence<ResizeObserverEntry> entries, R
interface ResizeObserverEntry { interface ResizeObserverEntry {
readonly attribute Element target; readonly attribute Element target;
readonly attribute DOMRectReadOnly? contentRect; readonly attribute DOMRectReadOnly? contentRect;
readonly attribute ResizeObserverSize borderBoxSize; // We are using a [Pure, Cached, Frozen] sequence since `FrozenArray` is not implemented in webidl.
readonly attribute ResizeObserverSize contentBoxSize; // This is functionally similar enough. As of #2340 Mozilla has not implemented this yet, either.
[Frozen, Cached, Pure]
readonly attribute sequence<ResizeObserverSize> borderBoxSize;
[Frozen, Cached, Pure]
readonly attribute sequence<ResizeObserverSize> contentBoxSize;
}; };
[Pref="layout.css.resizeobserver.enabled"] [Pref="layout.css.resizeobserver.enabled"]