wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-23 23:57:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

Track strict mode errors in for...in and for...of correctly when

Browse source 
syntax-parsing.
This commit is contained in:
wolfbeast 2019-04-05 21:38:21 +02:00 • committed by Roy Tam
commit 9a97be75ac
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
js/src/frontend/Parser.cpp
View file

@ -4458,6 +4458,10 @@ Parser<ParseHandler>::initializerInNameDeclaration(Node decl, Node binding,
{ {
MOZ_ASSERT(tokenStream.isCurrentTokenType(TOK_ASSIGN)); MOZ_ASSERT(tokenStream.isCurrentTokenType(TOK_ASSIGN));
uint32_t initializerOffset;
if (!tokenStream.peekOffset(&initializerOffset, TokenStream::Operand))
return false;
Node initializer = assignExpr(forHeadKind ? InProhibited : InAllowed, Node initializer = assignExpr(forHeadKind ? InProhibited : InAllowed,
yieldHandling, TripledotProhibited); yieldHandling, TripledotProhibited);
if (!initializer) if (!initializer)
@ -4491,11 +4495,8 @@ Parser<ParseHandler>::initializerInNameDeclaration(Node decl, Node binding,
// This leaves only initialized for-in |var| declarations. ES6 // This leaves only initialized for-in |var| declarations. ES6
// forbids these; later ES un-forbids in non-strict mode code. // forbids these; later ES un-forbids in non-strict mode code.
*forHeadKind = PNK_FORIN; *forHeadKind = PNK_FORIN;
if (!reportWithNode(ParseStrictError, pc->sc()->strict(), initializer, if (!strictModeErrorAt(initializerOffset, JSMSG_INVALID_FOR_IN_DECL_WITH_INIT))
JSMSG_INVALID_FOR_IN_DECL_WITH_INIT))
{
return false; return false;
}
*forInOrOfExpression = expressionAfterForInOrOf(PNK_FORIN, yieldHandling); *forInOrOfExpression = expressionAfterForInOrOf(PNK_FORIN, yieldHandling);
if (!*forInOrOfExpression) if (!*forInOrOfExpression)