From 91fc5614ec0a8c38ccfa199ebd7af73c948457c9 Mon Sep 17 00:00:00 2001 From: Moonchild Date: Sat, 20 Mar 2021 07:35:30 +0000 Subject: [PATCH] Issue #1749 - Remove restriction of SVG width/height element attributes. According to the original SVG spec, the SVG element in documents had to follow special rules as to what was allowed for width/height attributes. This is no longer the case, so we can decouple it from whatever internal units SVG/XML language uses and allow all units like every other element. --- dom/svg/nsSVGElement.cpp | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/dom/svg/nsSVGElement.cpp b/dom/svg/nsSVGElement.cpp index 9698617042..77dbcb939d 100644 --- a/dom/svg/nsSVGElement.cpp +++ b/dom/svg/nsSVGElement.cpp @@ -1268,24 +1268,6 @@ nsSVGElement::UpdateContentStyleRule() continue; // xml:lang has precedence } - if (IsSVGElement(nsGkAtoms::svg)) { - // Special case: we don't want 'width'/'height' mapped into style - // if the attribute value isn't a valid according to SVG (which - // only supports a subset of the CSS values). We don't enforce - // this by checking the attribute value in SVGSVGElement:: - // IsAttributeMapped since we don't want that method to depend on the - // value of the attribute that is being checked. Rather we just prevent - // the actual mapping here, as necessary. - if (attrName->Atom() == nsGkAtoms::width && - !GetAnimatedLength(nsGkAtoms::width)->HasBaseVal()) { - continue; - } - if (attrName->Atom() == nsGkAtoms::height && - !GetAnimatedLength(nsGkAtoms::height)->HasBaseVal()) { - continue; - } - } - nsAutoString value; mAttrsAndChildren.AttrAt(i)->ToString(value); mappedAttrParser.ParseMappedAttrValue(attrName->Atom(), value);