wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-08-25 16:59:01 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1343937 - Fix a crash in nsWrapperCache.h

Browse source 
* Implement and use GetInFlowParent
* Exempt scrollbar NAC from the new NAC semantics

Tag #1375
This commit is contained in:
Matt A. Tobin 2020-04-16 17:51:36 -04:00 • committed by Roy Tam
commit 8e51f64cad
5 changed files with 41 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
layout/base/nsCSSFrameConstructor.cpp
View file

@ -10730,6 +10730,12 @@ nsCSSFrameConstructor::AddFCItemsForAnonymousContent(
// first element that is not itself NAC (distinct from whether it happens
// to be in a NAC subtree).
//
// The one exception to all of this is scrollbar content, which we parent
// directly to the scrollframe. This is because the special-snowflake
// construction of scroll frames doesn't result in the placeholder frame
// being constructed until later, which means that GetInFlowParent() doesn't
// work right in the case of out-of-flow scrollframes.
//
// To implement all this, we need to pass the correct parent style context
// here because SetPrimaryFrame() may not have been called on the content
// yet and thus ResolveStyleContext can't find it otherwise.
@ -10739,9 +10745,12 @@ nsCSSFrameConstructor::AddFCItemsForAnonymousContent(
// to worry about anonymous boxes, which CorrectStyleParentFrame handles
// for us.
nsIFrame* inheritFrame = aFrame;
while (inheritFrame->GetContent()->IsNativeAnonymous()) {
inheritFrame = inheritFrame->GetParent();
if (!content->IsNativeScrollbarContent()) {
while (inheritFrame->GetContent()->IsNativeAnonymous()) {
inheritFrame = inheritFrame->GetInFlowParent();
}
}
if (inheritFrame->GetType() == nsGkAtoms::canvasFrame) {
// CorrectStyleParentFrame returns nullptr if the prospective parent is
// the canvas frame, so avoid calling it in that situation.