wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-22 23:27:30 +09:00
Code Issues Projects Releases Packages Wiki Activity

Revert "Issue #1909 - Guard against empty update manifest URL"

Browse source 
This reverts commit 7b3f9fb7c0.
This commit is contained in:
roytam1 2022-06-06 08:53:49 +08:00
commit 8c7e1338ce
2 changed files with 1 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

8
toolkit/mozapps/extensions/internal/AddonUpdateChecker.jsm
View file

@ -611,14 +611,6 @@ function UpdateParser(aId, aUpdateKey, aUrl, aObserver) {
let requireBuiltIn = Services.prefs.getBoolPref(PREF_UPDATE_REQUIREBUILTINCERTS, true); let requireBuiltIn = Services.prefs.getBoolPref(PREF_UPDATE_REQUIREBUILTINCERTS, true);
logger.debug("Requesting " + aUrl); logger.debug("Requesting " + aUrl);
if (!aUrl) {
logger.warn("Request failed: empty update manifest URL");
this._doneAt = new Error("UP_emptyManifestURL");
this.notifyError(AddonUpdateChecker.ERROR_DOWNLOAD_ERROR);
return;
}
try { try {
this.request = new ServiceRequest(); this.request = new ServiceRequest();
this.request.open("GET", this.url, true); this.request.open("GET", this.url, true);

6
toolkit/mozapps/extensions/internal/XPIProvider.jsm
View file

@ -6135,11 +6135,7 @@ function UpdateChecker(aAddon, aListener, aReason, aAppVersion, aPlatformVersion
if ("onUpdateAvailable" in this.listener) if ("onUpdateAvailable" in this.listener)
aReason |= UPDATE_TYPE_NEWVERSION; aReason |= UPDATE_TYPE_NEWVERSION;
// Don't perform substitutions on the update URL if we still don't let url = escapeAddonURI(aAddon, updateURL, aReason, aAppVersion);
// have one at this point.
let url = updateURL ?
escapeAddonURI(aAddon, url, aReason, aAppVersion) :
updateURL;
this._parser = AddonUpdateChecker.checkForUpdates(aAddon.id, aAddon.updateKey, this._parser = AddonUpdateChecker.checkForUpdates(aAddon.id, aAddon.updateKey,
url, this); url, this);
} }