wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-30 12:27:29 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1377648 - Fix HTMLSummaryElement::IsSummary() on removing the element

Browse source 
* Use inFlowFrame to check the target frame is summary and its parent is details
* Check summary frame instead of summary element on removing the summary

Tag #1375
This commit is contained in:
Matt A. Tobin 2020-04-17 06:09:37 -04:00 • committed by Roy Tam
commit 84d3b44b86
4 changed files with 35 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
layout/generic/DetailsFrame.cpp
View file

@ -129,3 +129,12 @@ DetailsFrame::AppendAnonymousContentTo(nsTArray<nsIContent*>& aElements,
aElements.AppendElement(mDefaultSummary);
}
}
bool
DetailsFrame::HasMainSummaryFrame(nsIFrame* aSummaryFrame)
{
nsIFrame* firstChild =
nsPlaceholderFrame::GetRealFrameFor(mFrames.FirstChild());
return aSummaryFrame == firstChild;
}

6
layout/generic/DetailsFrame.h
View file

@ -54,6 +54,12 @@ public:
void AppendAnonymousContentTo(nsTArray<nsIContent*>& aElements,
uint32_t aFilter) override;
// Returns true if |aSummaryFrame| is the main summary (i.e. the first child
// of this details frame).
// This function is used when the summary element is removed from the parent
// details element since at that moment the summary element has been already
// removed from the details element children.
bool HasMainSummaryFrame(nsIFrame* aSummaryFrame);
private:
nsCOMPtr<nsIContent> mDefaultSummary;