wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-19 23:07:33 +09:00
Code Issues Projects Releases Packages Wiki Activity

moebius#242: XPCOM: exportFunction() - fix wrong .length attribute

Browse source 
https://github.com/MoonchildProductions/moebius/pull/243
This commit is contained in:
janekptacijarabaci 2018-04-14 22:20:43 +02:00 • committed by Roy Tam
commit 8375cbc1a3
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
js/xpconnect/src/ExportHelpers.cpp
View file

@ -329,11 +329,20 @@ NewFunctionForwarder(JSContext* cx, HandleId idArg, HandleObject callable,
if (id == JSID_VOIDHANDLE)
id = GetJSIDByIndex(cx, XPCJSContext::IDX_EMPTYSTRING);
// If our callable is a (possibly wrapped) function, we can give
// the exported thing the right number of args.
unsigned nargs = 0;
RootedObject unwrapped(cx, js::UncheckedUnwrap(callable));
if (unwrapped) {
if (JSFunction* fun = JS_GetObjectFunction(unwrapped))
nargs = JS_GetFunctionArity(fun);
}
// We have no way of knowing whether the underlying function wants to be a
// constructor or not, so we just mark all forwarders as constructors, and
// let the underlying function throw for construct calls if it wants.
JSFunction* fun = js::NewFunctionByIdWithReserved(cx, FunctionForwarder,
0, JSFUN_CONSTRUCTOR, id);
nargs, JSFUN_CONSTRUCTOR, id);
if (!fun)
return false;