wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-29 20:07:30 +09:00
Code Issues Projects Releases Packages Wiki Activity

Fix TODO in WasmBaselineCompile

Browse source
This commit is contained in:
ownedbywuigi 2026-03-28 06:54:56 +00:00
commit 8128507f32
1 changed files with 111 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

97
js/src/wasm/WasmBaselineCompile.cpp
View file

@ -3858,7 +3858,49 @@ BaseCompiler::emitSubtractF64()
void void
BaseCompiler::emitMultiplyI32() BaseCompiler::emitMultiplyI32()
{ {
// TODO / OPTIMIZE: Multiplication by constant is common (Bug 1275442, 1316803) int32_t c;
if (popConstI32(c)) {
RegI32 r = popI32();
if (c == 0) {
masm.move32(Imm32(0), r.reg);
pushI32(r);
return;
}
if (c == 1) {
pushI32(r);
return;
}
if (c == -1) {
masm.neg32(r.reg);
pushI32(r);
return;
}
uint32_t mag = c < 0 ? uint32_t(0) - uint32_t(c) : uint32_t(c);
if (IsPowerOfTwo(mag)) {
uint32_t shift = 0;
while ((uint32_t(1) << shift) != mag)
shift++;
masm.lshift32(Imm32(shift), r.reg);
if (c < 0)
masm.neg32(r.reg);
pushI32(r);
return;
}
RegI32 rhs = needI32();
masm.move32(Imm32(c), rhs.reg);
masm.mul32(rhs.reg, r.reg);
freeI32(rhs);
pushI32(r);
return;
}
RegI32 r0, r1; RegI32 r0, r1;
pop2xI32ForIntMulDiv(&r0, &r1); pop2xI32ForIntMulDiv(&r0, &r1);
masm.mul32(r1.reg, r0.reg); masm.mul32(r1.reg, r0.reg);
@ -3934,7 +3976,33 @@ BaseCompiler::emitQuotientI32()
void void
BaseCompiler::emitQuotientU32() BaseCompiler::emitQuotientU32()
{ {
// TODO / OPTIMIZE: Fast case if lhs >= 0 and rhs is power of two (Bug 1316803) int32_t c;
if (popConstI32(c)) {
uint32_t uc = uint32_t(c);
RegI32 r = popI32();
if (uc != 0 && IsPowerOfTwo(uc)) {
uint32_t shift = 0;
while ((uint32_t(1) << shift) != uc)
shift++;
masm.rshift32(Imm32(shift), r.reg);
pushI32(r);
return;
}
RegI32 rhs = needI32();
masm.move32(Imm32(c), rhs.reg);
Label done;
checkDivideByZeroI32(rhs, r, &done);
masm.quotient32(rhs.reg, r.reg, IsUnsigned(true));
masm.bind(&done);
freeI32(rhs);
pushI32(r);
return;
}
RegI32 r0, r1; RegI32 r0, r1;
pop2xI32ForIntMulDiv(&r0, &r1); pop2xI32ForIntMulDiv(&r0, &r1);
@ -3967,7 +4035,30 @@ BaseCompiler::emitRemainderI32()
void void
BaseCompiler::emitRemainderU32() BaseCompiler::emitRemainderU32()
{ {
// TODO / OPTIMIZE: Fast case if lhs >= 0 and rhs is power of two (Bug 1316803) int32_t c;
if (popConstI32(c)) {
uint32_t uc = uint32_t(c);
RegI32 r = popI32();
if (uc != 0 && IsPowerOfTwo(uc)) {
masm.and32(Imm32(int32_t(uc - 1)), r.reg);
pushI32(r);
return;
}
RegI32 rhs = needI32();
masm.move32(Imm32(c), rhs.reg);
Label done;
checkDivideByZeroI32(rhs, r, &done);
masm.remainder32(rhs.reg, r.reg, IsUnsigned(true));
masm.bind(&done);
freeI32(rhs);
pushI32(r);
return;
}
RegI32 r0, r1; RegI32 r0, r1;
pop2xI32ForIntMulDiv(&r0, &r1); pop2xI32ForIntMulDiv(&r0, &r1);