wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-05 07:18:39 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #2720 - Implement two-location color stop logic.

Browse source 
This allows for two-location color stops (`color x% y%`) which is shorthand
for `color x%, color y%` where both colors are equal. (pct/length accepted)
See code comment for the reason it's implemented the way it is.

Resolves #2720
This commit is contained in:
Moonchild 2025-03-28 23:05:50 +01:00 • committed by roytam1
commit 80b30a8177
1 changed files with 22 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

23
layout/style/nsCSSParser.cpp
View file

@ -10542,7 +10542,7 @@ CSSParserImpl::ParsePlaceSelf()
return true;
}
// <color-stop> : <color> [ <percentage> | <length> ]?
// <color-stop> : <color> [ <percentage> | <length> ]? [ <percentage> | <length> ]?
bool
CSSParserImpl::ParseColorStop(nsCSSValueGradient* aGradient)
{
@ -10565,6 +10565,27 @@ CSSParserImpl::ParseColorStop(nsCSSValueGradient* aGradient)
}
stop->mLocation.SetNoneValue();
}
// Parse double-location stop second arg if present, no error if missing (normal stop).
// First, append another stop. For the parsing logic to work, we always need to append
// a stop first so the parsed values have somewhere to go. This does mean we're losing
// some performance because if the shorthand isn't present the stop has to be removed
// again, causing unnecessary array element juggling.
// See issue #2720
nsCSSValueGradientStop* stop2 = aGradient->mStops.AppendElement();
result = ParseVariant(stop2->mLocation, VARIANT_LP | VARIANT_CALC, nullptr);
if (result != CSSParseResult::NotFound) {
if (result == CSSParseResult::Error) {
// We didn't get a parseable stop, remove the additional stop again and throw.
aGradient->mStops.SetLength(aGradient->mStops.Length()-1);
return false;
}
stop2->mColor = stop->mColor; // copy color from first stop arg
} else {
// We didn't get a second stop after all, remove the additional stop again.
aGradient->mStops.SetLength(aGradient->mStops.Length()-1);
}
return true;
}