wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-26 09:07:30 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #2033 - Temporary fix of R<->B channel swap.

Browse source 
We have a BGR/RGB channel ordering mismatch here. to at least
provide proper display, a quick&dirty byte swap on the output
buffer will fix this for now, but we should look into seeing where
the surface mismatch is caused.
std::swap() should optimize pretty well in any of the used
compilers, but if necessary, a full buffer ASM routine can be
slotted in (although on current hardware I doubt this will be
even noticeable as it is)
This commit is contained in:
Moonchild 2022-11-24 12:37:28 +00:00 • committed by roytam1
commit 77ca4ae9db
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
image/decoders/nsJXLDecoder.cpp
View file

@ -141,6 +141,11 @@ nsJXLDecoder::ReadJXLData(const char* aData, size_t aLength)
Nothing(), SurfacePipeFlags()); Nothing(), SurfacePipeFlags());
for (uint8_t* rowPtr = mOutBuffer.begin(); rowPtr < mOutBuffer.end(); for (uint8_t* rowPtr = mOutBuffer.begin(); rowPtr < mOutBuffer.end();
rowPtr += mInfo.xsize * 4) { rowPtr += mInfo.xsize * 4) {
// FIXME: Quick and dirty BGRA to RGBA conversion.
// We currently have a channel ordering mis-match here.
for (uint8_t* pixPtr = rowPtr; pixPtr < rowPtr + mInfo.xsize * 4; pixPtr+=4){
std::swap(pixPtr[0], pixPtr[2]);
}
pipe->WriteBuffer(reinterpret_cast<uint32_t*>(rowPtr)); pipe->WriteBuffer(reinterpret_cast<uint32_t*>(rowPtr));
} }