wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-06 07:48:38 +09:00
Code Issues Projects Releases Packages Wiki Activity

Issue #2078 - Part 6: Replace empty list head with the next non-empty list for forgiving selector lists

Browse source 
What happens here if aListHead is an empty selector list:
(1) next selector group is parsed and continues to the next iteration if it's empty or invalid
(2) if we're a forgiving selector list and aListHead is empty, replace it with the selector group that we've just parsed
(3) step 1 ignores invalid/empty, so we assert that step 2 should never have an empty selector list
This commit is contained in:
FranklinDM 2023-02-20 22:28:50 +08:00 • committed by roytam1
commit 6d77f755da
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
layout/style/nsCSSParser.cpp
View file

@ -5486,8 +5486,15 @@ CSSParserImpl::ParseSelectorList(nsCSSSelectorList*& aListHead,
}
break;
}
// add new list to the end of the selector list
list->mNext = newList;
// Replace the list head if: it's empty and we're a forgiving selector
// list. Otherwise, add the new list to the end of the selector list.
if (aIsForgiving && !aListHead->mSelectors) {
MOZ_ASSERT(newList->mSelectors,
"replacing empty list head with an empty selector list?");
aListHead = newList;
} else {
list->mNext = newList;
}
list = newList;
continue;
} else if (aStopChar == tk->mSymbol && aStopChar != char16_t(0)) {