wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-25 01:47:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

No issue: Clean up exceptionDialog.js

Browse source 
- Fix some quoting, comments and inconsistencies and code style
- Swap manually grabbing service components out for using `Services.*`
This commit is contained in:
wolfbeast 2019-08-17 22:33:51 +02:00 • committed by Roy Tam
commit 6c3b83022a
1 changed files with 11 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

25
security/manager/pki/resources/content/exceptionDialog.js
View file

@ -31,7 +31,7 @@ function initExceptionDialog() {
if (args[0].location) { if (args[0].location) {
// We were pre-seeded with a location. // We were pre-seeded with a location.
document.getElementById("locationTextBox").value = args[0].location; document.getElementById("locationTextBox").value = args[0].location;
document.getElementById('checkCertButton').disabled = false; document.getElementById("checkCertButton").disabled = false;
if (args[0].sslStatus) { if (args[0].sslStatus) {
gSSLStatus = args[0].sslStatus; gSSLStatus = args[0].sslStatus;
@ -108,15 +108,17 @@ function checkCert() {
/** /**
* Build and return a URI, based on the information supplied in the * Build and return a URI, based on the information supplied in the
* Certificate Location fields * Certificate Location fields
*
* @returns {nsIURI}
* URI constructed from the information supplied on success, null
* otherwise.
*/ */
function getURI() { function getURI() {
// Use fixup service instead of just ioservice's newURI since it's quite // Use fixup service instead of just ioservice's newURI since it's quite
// likely that the host will be supplied without a protocol prefix, resulting // likely that the host will be supplied without a protocol prefix, resulting
// in malformed uri exceptions being thrown. // in malformed uri exceptions being thrown.
let fus = Components.classes["@mozilla.org/docshell/urifixup;1"]
.getService(Components.interfaces.nsIURIFixup);
let locationTextBox = document.getElementById("locationTextBox"); let locationTextBox = document.getElementById("locationTextBox");
let uri = fus.createFixupURI(locationTextBox.value, 0); let uri = Services.uriFixup.createFixupURI(locationTextBox.value, 0);
if (!uri) { if (!uri) {
return null; return null;
@ -150,7 +152,7 @@ function resetDialog() {
* Called by input textboxes to manage UI state * Called by input textboxes to manage UI state
*/ */
function handleTextChange() { function handleTextChange() {
var checkCertButton = document.getElementById('checkCertButton'); var checkCertButton = document.getElementById("checkCertButton");
checkCertButton.disabled = !(document.getElementById("locationTextBox").value); checkCertButton.disabled = !(document.getElementById("locationTextBox").value);
if (gNeedReset) { if (gNeedReset) {
gNeedReset = false; gNeedReset = false;
@ -218,8 +220,7 @@ function updateCertStatus() {
pe.checked = !inPrivateBrowsing; pe.checked = !inPrivateBrowsing;
setText("headerDescription", gPKIBundle.getString("addExceptionInvalidHeader")); setText("headerDescription", gPKIBundle.getString("addExceptionInvalidHeader"));
} } else {
else {
shortDesc = "addExceptionValidShort"; shortDesc = "addExceptionValidShort";
longDesc = "addExceptionValidLong"; longDesc = "addExceptionValidLong";
gDialog.getButton("extra1").disabled = true; gDialog.getButton("extra1").disabled = true;
@ -231,11 +232,8 @@ function updateCertStatus() {
document.getElementById("viewCertButton").disabled = false; document.getElementById("viewCertButton").disabled = false;
// Notify observers about the availability of the certificate // Notify observers about the availability of the certificate
Components.classes["@mozilla.org/observer-service;1"] Services.obs.notifyObservers(null, "cert-exception-ui-ready");
.getService(Components.interfaces.nsIObserverService) } else if (gChecking) {
.notifyObservers(null, "cert-exception-ui-ready", null);
}
else if (gChecking) {
shortDesc = "addExceptionCheckingShort"; shortDesc = "addExceptionCheckingShort";
longDesc = "addExceptionCheckingLong2"; longDesc = "addExceptionCheckingLong2";
// We're checking the certificate, so we disable the Get Certificate // We're checking the certificate, so we disable the Get Certificate
@ -245,8 +243,7 @@ function updateCertStatus() {
document.getElementById("viewCertButton").disabled = true; document.getElementById("viewCertButton").disabled = true;
gDialog.getButton("extra1").disabled = true; gDialog.getButton("extra1").disabled = true;
document.getElementById("permanent").disabled = true; document.getElementById("permanent").disabled = true;
} } else {
else {
shortDesc = "addExceptionNoCertShort"; shortDesc = "addExceptionNoCertShort";
longDesc = "addExceptionNoCertLong2"; longDesc = "addExceptionNoCertLong2";
// We're done checking the certificate, so allow the user to check it again. // We're done checking the certificate, so allow the user to check it again.