Only set and show the dual-guid indicators when dual-guid has been built

This commit is contained in:
NTD 2018-05-01 12:26:01 -04:00 • committed by Roy Tam
commit 69920e72f2
4 changed files with 18 additions and 5 deletions

View file

@ -1,6 +1,7 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public <!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this - License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. --> - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<!ENTITY addons.windowTitle "Add-ons Manager"> <!ENTITY addons.windowTitle "Add-ons Manager">
<!ENTITY search.placeholder "Search all add-ons"> <!ENTITY search.placeholder "Search all add-ons">
@ -210,7 +211,7 @@
<!ENTITY addon.loadingReleaseNotes.label "Loading…"> <!ENTITY addon.loadingReleaseNotes.label "Loading…">
<!ENTITY addon.errorLoadingReleaseNotes.label "Sorry, but there was an error loading the release notes."> <!ENTITY addon.errorLoadingReleaseNotes.label "Sorry, but there was an error loading the release notes.">
<!ENTITY addon.nativeAddon "This add-on directly targets Pale Moon"> <!ENTITY addon.nativeAddon "This add-on directly targets &brandFullName;">
<!ENTITY addon.compatAddon "This add-on targets Mozilla Firefox and runs in compatibility mode"> <!ENTITY addon.compatAddon "This add-on targets Mozilla Firefox and runs in compatibility mode">
<!ENTITY addon.createdBy.label "By "> <!ENTITY addon.createdBy.label "By ">

View file

@ -9,6 +9,8 @@
%extensionsDTD; %extensionsDTD;
<!ENTITY % aboutDTD SYSTEM "chrome://mozapps/locale/extensions/about.dtd"> <!ENTITY % aboutDTD SYSTEM "chrome://mozapps/locale/extensions/about.dtd">
%aboutDTD; %aboutDTD;
<!ENTITY % brandDTD SYSTEM "chrome://branding/locale/brand.dtd" >
%brandDTD;
]> ]>
<bindings id="addonBindings" <bindings id="addonBindings"
@ -855,8 +857,10 @@
<xul:label anonid="name" class="name" crop="end" flex="1" <xul:label anonid="name" class="name" crop="end" flex="1"
xbl:inherits="value=name,tooltiptext=name"/> xbl:inherits="value=name,tooltiptext=name"/>
<xul:label anonid="version" class="version"/> <xul:label anonid="version" class="version"/>
#ifdef MOZ_PHOENIX_EXTENSIONS
<xul:label class="nativeIndicator nativeAddon" value="●" tooltiptext="&addon.nativeAddon;"/> <xul:label class="nativeIndicator nativeAddon" value="●" tooltiptext="&addon.nativeAddon;"/>
<xul:label class="nativeIndicator compatAddon" value="●" tooltiptext="&addon.compatAddon;"/> <xul:label class="nativeIndicator compatAddon" value="●" tooltiptext="&addon.compatAddon;"/>
#endif
<xul:label class="disabled-postfix" value="&addon.disabled.postfix;"/> <xul:label class="disabled-postfix" value="&addon.disabled.postfix;"/>
<xul:label class="update-postfix" value="&addon.update.postfix;"/> <xul:label class="update-postfix" value="&addon.update.postfix;"/>
<xul:spacer flex="5000"/> <!-- Necessary to make the name crop --> <xul:spacer flex="5000"/> <!-- Necessary to make the name crop -->
@ -1362,8 +1366,10 @@
[this.mAddon.name], 1); [this.mAddon.name], 1);
} else { } else {
this.removeAttribute("notification"); this.removeAttribute("notification");
#ifdef MOZ_PHOENIX_EXTENSIONS
if (this.mAddon.type == "extension") if (this.mAddon.type == "extension")
this.setAttribute("native", this.mAddon.native); this.setAttribute("native", this.mAddon.native);
#endif
} }
} }

View file

@ -6442,21 +6442,23 @@ AddonInternal.prototype = {
if (!aPlatformVersion) if (!aPlatformVersion)
aPlatformVersion = Services.appinfo.platformVersion; aPlatformVersion = Services.appinfo.platformVersion;
#ifdef MOZ_PHOENIX_EXTENSIONS
this.native = false; this.native = false;
#endif
let version; let version;
if (app.id == Services.appinfo.ID) { if (app.id == Services.appinfo.ID) {
version = aAppVersion; version = aAppVersion;
#ifdef MOZ_PHOENIX_EXTENSIONS
this.native = true; this.native = true;
} }
#ifdef MOZ_PHOENIX_EXTENSIONS
else if (app.id == FIREFOX_ID) { else if (app.id == FIREFOX_ID) {
version = FIREFOX_APPCOMPATVERSION; version = FIREFOX_APPCOMPATVERSION;
if (this.type == "locale") if (this.type == "locale")
//Never allow language packs in Firefox compatibility mode //Never allow language packs in Firefox compatibility mode
return false; return false;
}
#endif #endif
}
else if (app.id == TOOLKIT_ID) else if (app.id == TOOLKIT_ID)
version = aPlatformVersion version = aPlatformVersion

View file

@ -70,7 +70,11 @@ const PROP_JSON_FIELDS = ["id", "syncGUID", "location", "version", "type",
"skinnable", "size", "sourceURI", "releaseNotesURI", "skinnable", "size", "sourceURI", "releaseNotesURI",
"softDisabled", "foreignInstall", "hasBinaryComponents", "softDisabled", "foreignInstall", "hasBinaryComponents",
"strictCompatibility", "locales", "targetApplications", "strictCompatibility", "locales", "targetApplications",
"targetPlatforms", "multiprocessCompatible", "native"]; "targetPlatforms", "multiprocessCompatible",
#ifdef MOZ_PHOENIX_EXTENSIONS
"native"
#endif
];
// Time to wait before async save of XPI JSON database, in milliseconds // Time to wait before async save of XPI JSON database, in milliseconds
const ASYNC_SAVE_DELAY_MS = 20; const ASYNC_SAVE_DELAY_MS = 20;