[draft] CSS - linear-gradient - zero (0) angle value without degree unit is not correctly interpreted

This commit is contained in:
janekptacijarabaci 2017-08-17 20:34:01 +02:00 • committed by Roy Tam
commit 66276efa0a
2 changed files with 7 additions and 5 deletions

View file

@ -10404,7 +10404,8 @@ CSSParserImpl::ParseLinearGradient(nsCSSValue& aValue,
UngetToken();
// <angle> ,
if (ParseSingleTokenVariant(cssGradient->mAngle, VARIANT_ANGLE, nullptr) &&
if (ParseSingleTokenVariant(cssGradient->mAngle,
VARIANT_ANGLE_OR_ZERO, nullptr) &&
!ExpectSymbol(',', true)) {
SkipUntil(')');
return false;

View file

@ -132,6 +132,9 @@ var validGradientAndElementValues = [
"linear-gradient(to right bottom, red, 50%, green 50%, 50%, blue)",
"linear-gradient(to right bottom, red, 0%, green 50%, 100%, blue)",
/* Unitless 0 is valid as an <angle> */
"linear-gradient(0, red, blue)",
"-moz-linear-gradient(red, blue)",
"-moz-linear-gradient(red, yellow, blue)",
"-moz-linear-gradient(red 1px, yellow 20%, blue 24em, green)",
@ -388,10 +391,8 @@ var invalidGradientAndElementValues = [
"-moz-linear-gradient(10 10px -45deg, red, blue) repeat",
"-moz-linear-gradient(10px 10 -45deg, red, blue) repeat",
"linear-gradient(red -99, yellow, green, blue 120%)",
/* Unitless 0 is invalid as an <angle> */
"-moz-linear-gradient(top left 0, red, blue)",
"-moz-linear-gradient(5px 5px 0, red, blue)",
"linear-gradient(0, red, blue)",
/* Unitless nonzero numbers are valid as an <angle> */
"linear-gradient(30, red, blue)",
/* Invalid color, calc() or -moz-image-rect() function */
"linear-gradient(red, rgb(0, rubbish, 0) 50%, red)",
"linear-gradient(red, red calc(50% + rubbish), red)",