From 6525b2980c21a8dadfdab686e323f6689835fcf9 Mon Sep 17 00:00:00 2001
From: Moonchild <moonchild@palemoon.org>
Date: Fri, 28 Jun 2024 14:55:06 +0200
Subject: [PATCH] Issue #2537 - Don't assume username fields appear before
 password fields in forms.

---
 toolkit/components/passwordmgr/LoginManagerContent.jsm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/toolkit/components/passwordmgr/LoginManagerContent.jsm b/toolkit/components/passwordmgr/LoginManagerContent.jsm
index e8dcf8ad38..8a2f340a6b 100644
--- a/toolkit/components/passwordmgr/LoginManagerContent.jsm
+++ b/toolkit/components/passwordmgr/LoginManagerContent.jsm
@@ -760,11 +760,10 @@ var LoginManagerContent = {
     }
 
     if (!usernameField) {
-      // Locate the username field in the form by searching backwards
-      // from the first password field, assume the first text field is the
-      // username. We might not find a username field if the user is
+      // Locate the username field in the form by searching.
+      // We might not find a username field if the user is
       // already logged in to the site.
-      for (var i = pwFields[0].index - 1; i >= 0; i--) {
+      for (var i = 0; i < form.elements.length; i++) {
         var element = form.elements[i];
         if (!LoginHelper.isUsernameFieldType(element)) {
           continue;