wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-23 23:57:31 +09:00
Code Issues Projects Releases Packages Wiki Activity

Add nullcheck in nsSVGUtils::PaintFrameWithEffects

Browse source 
Some SVGs define a mask but an invalid mask frame. Check to make sure
we have a `maskFrame` that isn't null before trying to use it.
This resolves #1034
This commit is contained in:
wolfbeast 2019-04-06 22:12:00 +02:00 • committed by Roy Tam
commit 59d7005617
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
layout/svg/nsSVGUtils.cpp
View file

@ -734,9 +734,12 @@ nsSVGUtils::PaintFrameWithEffects(nsIFrame *aFrame,
RefPtr<SourceSurface> maskSurface; RefPtr<SourceSurface> maskSurface;
if (maskUsage.shouldGenerateMaskLayer) { if (maskUsage.shouldGenerateMaskLayer) {
maskSurface = // Make sure we have a mask frame.
maskFrame->GetMaskForMaskedFrame(&aContext, aFrame, aTransform, if (maskFrame) {
maskUsage.opacity, &maskTransform); maskSurface =
maskFrame->GetMaskForMaskedFrame(&aContext, aFrame, aTransform,
maskUsage.opacity, &maskTransform);
}
if (!maskSurface) { if (!maskSurface) {
// Entire surface is clipped out. // Entire surface is clipped out.