WIP fix 1

application/palemoon/base/content/browser.js

@@ -2661,6 +2661,11 @@ function getWebNavigation()
 }
 
 function BrowserReloadWithFlags(reloadFlags) {
+  
+  // Reset DOS mitigation for auth prompts when user initiates a reload.
+  let browser = gBrowser.selectedBrowser;
+  delete browser.authPromptCounter;
+  
   /* First, we'll try to use the session history object to reload so
    * that framesets are handled properly. If we're in a special
    * window (such as view-source) that has no session history, fall

application/palemoon/base/content/tabbrowser.xml

@@ -2458,7 +2458,10 @@
         <parameter name="aTab"/>
         <body>
           <![CDATA[
-            this.getBrowserForTab(aTab).reload();
+            let browser = this.getBrowserForTab(aTab);
+            // Reset DOS mitigation for basic auth prompt
+            delete browser.authPromptCounter;
+            browser.reload();
           ]]>
         </body>
       </method>

application/palemoon/base/content/urlbarBindings.xml

@@ -303,6 +303,10 @@
               Cu.reportError(ex);
             }
             
+            // Reset DOS mitigations for the basic auth prompt.
+            let browser = gBrowser.selectedBrowser;
+            delete browser.authPromptCounter;
+
             function loadCurrent() {
               let flags = Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP;
               // Pass LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL to prevent any loads from

toolkit/components/passwordmgr/nsLoginManagerPrompter.js

@@ -97,17 +97,25 @@ LoginManagerPromptFactory.prototype = {
       return;
     }
 
-    // Allow only a limited number of authentication dialogs when they are all
+    // Set up a counter for ensuring that the basic auth prompt can not
-    // canceled by the user.
+    // be abused for DOS-style attacks. With this counter, each eTLD+1
-    var cancelationCounter = (prompter._browser && prompter._browser.canceledAuthenticationPromptCounter) || { count: 0, id: 0 };
+    // per browser will get a limited number of times a user can
-    if (prompt.channel) {
+    // cancel the prompt until we stop showing it.
-      var httpChannel = prompt.channel.QueryInterface(Ci.nsIHttpChannel);
+    let browser = prompter._browser;
-      if (httpChannel) {
+    let baseDomain = null;
-        var windowId = httpChannel.topLevelContentWindowId;
+    if (browser) {
-        if (windowId != cancelationCounter.id) {
+      try {
-          // window has been reloaded or navigated, reset the counter
+        baseDomain = Services.eTLD.getBaseDomainFromHost(hostname);
-          cancelationCounter = { count: 0, id: windowId };
+      } catch (e) {
-        }
+        baseDomain = hostname;
+      }
+
+      if (!browser.authPromptCounter) {
+        browser.authPromptCounter = {};
+      }
+
+      if (!browser.authPromptCounter[baseDomain]) {
+        browser.authPromptCounter[baseDomain] = 0;
       }
     }
 
@@ -137,13 +145,14 @@ LoginManagerPromptFactory.prototype = {
           prompt.inProgress = false;
           self._asyncPromptInProgress = false;
 
-          if (ok) {
+          if (browser) {
-            cancelationCounter.count = 0;
+            // Reset the counter state if the user replied to a prompt and actually
-          } else {
+            // tried to login (vs. simply clicking any button to get out).
-            cancelationCounter.count++;
+            if (ok && (prompt.authInfo.username || prompt.authInfo.password)) {
-          }
+              browser.authPromptCounter[baseDomain] = 0;
-          if (prompter._browser) {
+            } else {
-            prompter._browser.canceledAuthenticationPromptCounter = cancelationCounter;
+              browser.authPromptCounter[baseDomain] += 1;
+            }
           }
         }
 
@@ -168,8 +177,9 @@ LoginManagerPromptFactory.prototype = {
 
     var cancelDialogLimit = Services.prefs.getIntPref("prompts.authentication_dialog_abuse_limit");
 
+    let cancelationCounter = browser.authPromptCounter[baseDomain];
     this.log("cancelationCounter =", cancelationCounter);
-    if (cancelDialogLimit && cancelationCounter.count >= cancelDialogLimit) {
+    if (cancelDialogLimit && cancelationCounter >= cancelDialogLimit) {
       this.log("Blocking auth dialog, due to exceeding dialog bloat limit");
       delete this._asyncPrompts[hashKey];