wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-30 12:27:29 +09:00
Code Issues Projects Releases Packages Wiki Activity

JS - Object - "TypeError: setting a property that has only a getter" without mentioning file and property name

Browse source
This commit is contained in:
janekptacijarabaci 2017-08-24 10:34:22 +02:00 • committed by Roy Tam
commit 5149d56104
6 changed files with 2 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

2
devtools/client/webconsole/test/browser_webconsole_strict_mode_errors.js
View file

@ -55,7 +55,7 @@ add_task(function* () {
webconsole: hud, webconsole: hud,
messages: [ messages: [
{ {
text: "TypeError: setting a property that has only a getter", text: 'TypeError: setting getter-only property "p"',
category: CATEGORY_JS, category: CATEGORY_JS,
severity: SEVERITY_ERROR, severity: SEVERITY_ERROR,
}, },

7
dom/workers/WorkerScope.cpp
View file

@ -968,11 +968,4 @@ IsDebuggerSandbox(JSObject* object)
SimpleGlobalObject::GlobalType::WorkerDebuggerSandbox; SimpleGlobalObject::GlobalType::WorkerDebuggerSandbox;
} }
bool
GetterOnlyJSNative(JSContext* aCx, unsigned aArgc, JS::Value* aVp)
{
JS_ReportErrorNumberASCII(aCx, js::GetErrorMessage, nullptr, JSMSG_GETTER_ONLY);
return false;
}
END_WORKERS_NAMESPACE END_WORKERS_NAMESPACE

8
dom/workers/Workers.h
View file

@ -362,14 +362,6 @@ IsDebuggerGlobal(JSObject* global);
bool bool
IsDebuggerSandbox(JSObject* object); IsDebuggerSandbox(JSObject* object);
// Throws the JSMSG_GETTER_ONLY exception. This shouldn't be used going
// forward -- getter-only properties should just use JS_PSG for the setter
// (implying no setter at all), which will not throw when set in non-strict
// code but will in strict code. Old code should use this only for temporary
// compatibility reasons.
extern bool
GetterOnlyJSNative(JSContext* aCx, unsigned aArgc, JS::Value* aVp);
END_WORKERS_NAMESPACE END_WORKERS_NAMESPACE
#endif // mozilla_dom_workers_workers_h__ #endif // mozilla_dom_workers_workers_h__

2
js/src/js.msg
View file

@ -65,7 +65,7 @@ MSG_DEF(JSMSG_BAD_GETTER_OR_SETTER, 1, JSEXN_TYPEERR, "invalid {0} usage")
MSG_DEF(JSMSG_BAD_ARRAY_LENGTH, 0, JSEXN_RANGEERR, "invalid array length") MSG_DEF(JSMSG_BAD_ARRAY_LENGTH, 0, JSEXN_RANGEERR, "invalid array length")
MSG_DEF(JSMSG_REDECLARED_VAR, 2, JSEXN_SYNTAXERR, "redeclaration of {0} {1}") MSG_DEF(JSMSG_REDECLARED_VAR, 2, JSEXN_SYNTAXERR, "redeclaration of {0} {1}")
MSG_DEF(JSMSG_UNDECLARED_VAR, 1, JSEXN_REFERENCEERR, "assignment to undeclared variable {0}") MSG_DEF(JSMSG_UNDECLARED_VAR, 1, JSEXN_REFERENCEERR, "assignment to undeclared variable {0}")
MSG_DEF(JSMSG_GETTER_ONLY, 0, JSEXN_TYPEERR, "setting a property that has only a getter") MSG_DEF(JSMSG_GETTER_ONLY, 1, JSEXN_TYPEERR, "setting getter-only property {0}")
MSG_DEF(JSMSG_OVERWRITING_ACCESSOR, 1, JSEXN_TYPEERR, "can't overwrite accessor property {0}") MSG_DEF(JSMSG_OVERWRITING_ACCESSOR, 1, JSEXN_TYPEERR, "can't overwrite accessor property {0}")
MSG_DEF(JSMSG_UNDEFINED_PROP, 1, JSEXN_REFERENCEERR, "reference to undefined property {0}") MSG_DEF(JSMSG_UNDEFINED_PROP, 1, JSEXN_REFERENCEERR, "reference to undefined property {0}")
MSG_DEF(JSMSG_INVALID_MAP_ITERABLE, 1, JSEXN_TYPEERR, "iterable for {0} should have array-like objects") MSG_DEF(JSMSG_INVALID_MAP_ITERABLE, 1, JSEXN_TYPEERR, "iterable for {0} should have array-like objects")

12
js/src/jsobj.cpp
View file

@ -3298,18 +3298,6 @@ GetObjectSlotNameFunctor::operator()(JS::CallbackTracer* trc, char* buf, size_t
} }
} }
bool
js::ReportGetterOnlyAssignment(JSContext* cx, bool strict)
{
return JS_ReportErrorFlagsAndNumberASCII(cx,
strict
? JSREPORT_ERROR
: JSREPORT_WARNING | JSREPORT_STRICT,
GetErrorMessage, nullptr,
JSMSG_GETTER_ONLY);
}
/*** Debugging routines **************************************************************************/ /*** Debugging routines **************************************************************************/
#ifdef DEBUG #ifdef DEBUG

3
js/src/jsobj.h
View file

@ -1320,9 +1320,6 @@ template<XDRMode mode>
bool bool
XDRObjectLiteral(XDRState<mode>* xdr, MutableHandleObject obj); XDRObjectLiteral(XDRState<mode>* xdr, MutableHandleObject obj);
extern bool
ReportGetterOnlyAssignment(JSContext* cx, bool strict);
/* /*
* Report a TypeError: "so-and-so is not an object". * Report a TypeError: "so-and-so is not an object".
* Using NotNullObject is usually less code. * Using NotNullObject is usually less code.