wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-10-28 10:07:30 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1326453 - Part 3: Don't throw a TypeError when SetPrototypeOf for module namespace objects is called with null

Browse source
This commit is contained in:
janekptacijarabaci 2018-04-14 08:51:05 +02:00 • committed by Roy Tam
commit 50765b944e
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
js/src/builtin/ModuleObject.cpp
View file

@ -345,6 +345,8 @@ bool
ModuleNamespaceObject::ProxyHandler::setPrototype(JSContext* cx, HandleObject proxy, ModuleNamespaceObject::ProxyHandler::setPrototype(JSContext* cx, HandleObject proxy,
HandleObject proto, ObjectOpResult& result) const HandleObject proto, ObjectOpResult& result) const
{ {
if (!proto)
return result.succeed();
return result.failCantSetProto(); return result.failCantSetProto();
} }

4
js/src/jit-test/tests/modules/import-namespace.js
View file

@ -39,7 +39,9 @@ assertEq(getModuleEnvironmentValue(b, "x"), 3);
// Test module namespace internal methods as defined in 9.4.6 // Test module namespace internal methods as defined in 9.4.6
assertEq(Object.getPrototypeOf(ns), null); assertEq(Object.getPrototypeOf(ns), null);
assertThrowsInstanceOf(() => Object.setPrototypeOf(ns, null), TypeError); assertEq(Reflect.setPrototypeOf(ns, null), true);
assertEq(Reflect.setPrototypeOf(ns, Object.prototype), false);
assertThrowsInstanceOf(() => Object.setPrototypeOf(ns, {}), TypeError);
assertThrowsInstanceOf(function() { ns.foo = 1; }, TypeError); assertThrowsInstanceOf(function() { ns.foo = 1; }, TypeError);
assertEq(Object.isExtensible(ns), false); assertEq(Object.isExtensible(ns), false);
Object.preventExtensions(ns); Object.preventExtensions(ns);