wuggy/Dactyloidae
wuggy/Dactyloidae
1
0
Fork 0
mirror of https://repo.dactyloidae.xyz/Dactyloidae/UXP.git synced 2026-09-06 07:48:38 +09:00
Code Issues Projects Releases Packages Wiki Activity

Bug 1331585 - Allow falsy "done" values for IteratorClose due to exception during array destructuring

Browse source 
Issue #74
This commit is contained in:
janekptacijarabaci 2018-03-25 14:48:34 +02:00 • committed by Roy Tam
commit 4ac4296fce
3 changed files with 25 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
js/src/vm/Interpreter.cpp
View file

@ -1205,8 +1205,9 @@ ProcessTryNotes(JSContext* cx, EnvironmentIter& ei, InterpreterRegs& regs)
// stack. The iterator object is second from the top.
MOZ_ASSERT(tn->stackDepth > 1);
Value* sp = regs.spForStackDepth(tn->stackDepth);
MOZ_ASSERT(sp[-1].isBoolean());
if (sp[-1].isFalse()) {
RootedValue doneValue(cx, sp[-1]);
bool done = ToBoolean(doneValue);
if (!done) {
RootedObject iterObject(cx, &sp[-2].toObject());
if (!IteratorCloseForException(cx, iterObject)) {
SettleOnTryNote(cx, tn, ei, regs);